Menu
▾
▴
fofredux-devel — Developers discussion, bug fixing, and coding of fofredux
You can subscribe to this list here.
| 2005 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(92) |
Dec
(142) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2006 |
Jan
(33) |
Feb
(65) |
Mar
(76) |
Apr
(172) |
May
(124) |
Jun
(45) |
Jul
(76) |
Aug
(78) |
Sep
(1) |
Oct
(20) |
Nov
(6) |
Dec
(2) |
| 2007 |
Jan
(12) |
Feb
(7) |
Mar
(17) |
Apr
(3) |
May
|
Jun
(2) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
|
From: Andrew T. <ajt...@hi...> - 2006-07-31 13:10:34
|
Any update on the SVN service avail for you? I was using it yesterday fine. On 7/28/06, Miles Beck <mil...@gm...> wrote: > Anyone know what's up with the SVN listing? > > I've tried for the past couple of days to check and see if anything > new has been checked in and I keep getting the message that the > service is unavailable. > > -Miles > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
|
From: Miles B. <mil...@gm...> - 2006-07-28 19:58:09
|
Anyone know what's up with the SVN listing? I've tried for the past couple of days to check and see if anything new has been checked in and I keep getting the message that the service is unavailable. -Miles |
|
From: Kevin <ke...@dr...> - 2006-07-24 18:05:09
|
> Anyone know why I might have a feed that is not updating? > > It does not update with update-quiet.php. I manually have to update > the feed to see if any new articles are there. What does update.php say for that feed. Both now use identical logic. --=20 Kevin |
|
From: Miles B. <mil...@gm...> - 2006-07-24 17:58:58
|
Anyone know why I might have a feed that is not updating? It does not update with update-quiet.php. I manually have to update the feed to see if any new articles are there. -Miles |
|
From: Miles B. <mil...@gm...> - 2006-07-24 03:43:36
|
On 7/23/06, Kevin <ke...@dr...> wrote: > A category table with no rows is a case that FOFR is not coded to work > with. There should always be a "None" category. The install page > creates it and it should not be possible to delete it. > > -Kevin Right, I meant delete everything but the None category. Since you cannot delete it. When I only have the None category, I get the error I reported. If someone could try what I outlined in the previous email that might prove beneficial. I'm not sure why I get the error, but it would be nice to get it fixed. -Miles |
|
From: Kevin <ke...@dr...> - 2006-07-23 21:33:00
|
Miles Beck wrote: > Could someone try the following? > > On a test database delete all your categories, then click on "add > feeds" or "edit feed" and see if you get the below error. > > Fatal error: Call to a member function on a non-object in > /var/www/fofreduxtest/lib/view_helper.php on line 272 > > If I add a category back into the database the error does not happen. > I was able to get my working copy of FoFRedux able to add/edit feeds > again after I exported and then re-imported the database. > > Then I was able to add a category and now adding and editing feeds > works again. Though the new feed is automatically assigned the first > category that's available. And you are unable to remove the category > from the feed unless you delete the category. There is no category > option of None when editing the feed. > > So it appears there is still a few problems with categories. > > 1. With no category in the database you will get the above fatal error. > 2. You are unable to have no category assigned to a feed. > > Also I did drop fr_categories in the database and then I ran > install.php. This did not help in regards to the fatal error. > A category table with no rows is a case that FOFR is not coded to work with. There should always be a "None" category. The install page creates it and it should not be possible to delete it. -Kevin |
|
From: Miles B. <mil...@gm...> - 2006-07-23 16:19:57
|
Could someone try the following? On a test database delete all your categories, then click on "add feeds" or "edit feed" and see if you get the below error. Fatal error: Call to a member function on a non-object in /var/www/fofreduxtest/lib/view_helper.php on line 272 If I add a category back into the database the error does not happen. I was able to get my working copy of FoFRedux able to add/edit feeds again after I exported and then re-imported the database. Then I was able to add a category and now adding and editing feeds works again. Though the new feed is automatically assigned the first category that's available. And you are unable to remove the category from the feed unless you delete the category. There is no category option of None when editing the feed. So it appears there is still a few problems with categories. 1. With no category in the database you will get the above fatal error. 2. You are unable to have no category assigned to a feed. Also I did drop fr_categories in the database and then I ran install.php. This did not help in regards to the fatal error. -Miles |
|
From: Andrew T. <ajt...@hi...> - 2006-07-23 01:03:59
|
I think we also need to start a database of violators of bad feed production. :) Do the feeds all validate? If so, seems like a failure in the standard that doesn't specify what should be the content link vs. feed link vs. guid. Thanks Kevin, Andrew On 7/21/06, Kevin <ke...@dr...> wrote: > > > On 7/20/06, Kevin <ke...@dr...> wrote: > >> > >> current logic to get the value for link. I know it needs to be changed > >> to > >> make it work better, but I don't know how. > > > > Thanks for showing the root of the issue. I would think the first step > > would be to re-order the priority of how a link is obtained. First if > > there is a "link", use that, then the enclosure url perhaps, and > > finally the GUID. > > > > I agree that I didn't really realize the possible problems either > > before. GUID was typically URL since that has to be unique. HOwever, > > the GUID doesn't *need* to be the URL. > > Right, I'm the one that changed the link resolution order to favor GUID > tag over the LINK tag. There was a feed where the link tag was constant > for all items, but the guid was a unique URL. > > I plan on adding an indexed column to the item table to hold a unique hash > for the item.(md5 or sha1) This will separate the link and uniqueness > concerns and make everyone happy. > > -- > Kevin > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
|
From: Miles B. <mil...@gm...> - 2006-07-22 22:31:48
|
On 7/22/06, Kevin <ke...@dr...> wrote:
> Already done. Should be in yesterday's snapshot.
>
>
> --
> Kevin
Hm, because I downloaded today's snapshot and I am still having the
problems with adding and editing a feed.
When I try and add a category I get the following error:
Fatal error: mysql error: [Column 'description' cannot be null] in
EXECUTE("INSERT INTO fr_categories (title,description)
VALUES('Test',NULL)")
Error performing database operation, Maybe you need to run the installer.
in /var/www/fofredux_0.4-dev/lib/model/base.php on line 251
-Miles
|
|
From: Kevin <ke...@dr...> - 2006-07-22 22:28:30
|
> Quick Q. Is your "Mark as Read" working? It stopped working for me > about 3 days ago, this may coincide with the upgrade to adodb_lite > 1.20 and other associated changes? On which page? I typically use the "mark as read"/"mark all as read" on view.php which still works for me.. > An update on UI is imminent ;) Cool! --=20 Kevin |
|
From: Kevin <ke...@dr...> - 2006-07-22 22:25:49
|
> On 7/20/06, Kevin <ke...@dr...> wrote: >> By any chance do you have *NO* categories in the database? ADODB Li= te >> has a quirk where it will return false when a query has no results. >> This causes weird errors after you wrap that in a few layers of >> abstraction. I now remember running into this problem with feed and >> items. I've fixed this for categories, users, and tags. That should >> cover everything. >> >> I also added a change where it's impossible to delete the None categor= y. > > Will this be checked in soon? If so I can test it again. > > Thanks for all your work on this. :) Already done. Should be in yesterday's snapshot. --=20 Kevin |
|
From: Miles B. <mil...@gm...> - 2006-07-22 21:33:58
|
On 7/20/06, Kevin <ke...@dr...> wrote: > By any chance do you have *NO* categories in the database? ADODB Lite > has a quirk where it will return false when a query has no results. > This causes weird errors after you wrap that in a few layers of > abstraction. I now remember running into this problem with feed and > items. I've fixed this for categories, users, and tags. That should > cover everything. > > I also added a change where it's impossible to delete the None category. Will this be checked in soon? If so I can test it again. Thanks for all your work on this. :) -Miles |
|
From: Miles B. <mil...@gm...> - 2006-07-22 21:31:27
|
On 7/22/06, Andrew Turner <ajt...@hi...> wrote: > Quick Q. Is your "Mark as Read" working? It stopped working for me > about 3 days ago, this may coincide with the upgrade to adodb_lite > 1.20 and other associated changes? It's working fine for me in the latest snapshot. -Miles |
|
From: Miles B. <mil...@gm...> - 2006-07-22 21:26:15
|
On 7/20/06, Kevin <ke...@dr...> wrote: > By any chance do you have *NO* categories in the database? ADODB Lite > has a quirk where it will return false when a query has no results. > This causes weird errors after you wrap that in a few layers of > abstraction. I now remember running into this problem with feed and > items. I've fixed this for categories, users, and tags. That should > cover everything. > > I also added a change where it's impossible to delete the None category. > > -Kevin In my working copy of FoFRedux I do not have any categories other than the default, which is None. Below is the sql command you asked me to run before. SELECT id, title, description FROM fr_categories ORDER BY title; +----+-------+-------------+ | id | title | description | +----+-------+-------------+ | 1 | None | No category | +----+-------+-------------+ 1 row in set (0.00 sec) |
|
From: Andrew T. <ajt...@hi...> - 2006-07-22 13:34:49
|
Quick Q. Is your "Mark as Read" working? It stopped working for me about 3 days ago, this may coincide with the upgrade to adodb_lite 1.20 and other associated changes? An update on UI is imminent ;) Heading out to the MI beer fest. Yay Andrew -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
|
From: Kevin <ke...@dr...> - 2006-07-21 16:21:14
|
> On 7/20/06, Kevin <ke...@dr...> wrote: >> >> current logic to get the value for link. I know it needs to be change= d >> to >> make it work better, but I don't know how. > > Thanks for showing the root of the issue. I would think the first step > would be to re-order the priority of how a link is obtained. First if > there is a "link", use that, then the enclosure url perhaps, and > finally the GUID. > > I agree that I didn't really realize the possible problems either > before. GUID was typically URL since that has to be unique. HOwever, > the GUID doesn't *need* to be the URL. Right, I'm the one that changed the link resolution order to favor GUID tag over the LINK tag. There was a feed where the link tag was constant for all items, but the guid was a unique URL. I plan on adding an indexed column to the item table to hold a unique has= h for the item.(md5 or sha1) This will separate the link and uniqueness concerns and make everyone happy. --=20 Kevin |
|
From: Kevin <ke...@dr...> - 2006-07-21 01:34:43
|
Miles Beck wrote: > On 7/20/06, Kevin <ke...@dr...> wrote: > >> I just made a few big commits tonight. Please retest this. I tried >> adding and deleting categories and all works for me. >> >> -Kevin >> > > Just tried out the 0720 snapshot and I am seeing the same problems > with adding and feed editing feeds. > > When trying to add a feed > Fatal error: Call to a member function on a non-object in > /var/www/fofreduxtest/lib/view_helper.php on line 272 > > When trying to edit a feed: > Fatal error: Call to a member function on a non-object in > /var/www/fofreduxtest/lib/view_helper.php on line 272 > > Both of these errors show up after "Category". > By any chance do you have *NO* categories in the database? ADODB Lite has a quirk where it will return false when a query has no results. This causes weird errors after you wrap that in a few layers of abstraction. I now remember running into this problem with feed and items. I've fixed this for categories, users, and tags. That should cover everything. I also added a change where it's impossible to delete the None category. -Kevin |
|
From: Miles B. <mil...@gm...> - 2006-07-20 22:22:46
|
On 7/20/06, Andrew Turner <ajt...@hi...> wrote: > What kevin means is that <category table name> is the table name as > set in your config.php > > so probably something like: fr_categories > > Andrew SELECT id, title, description FROM fr_categories ORDER BY title; +----+-------+-------------+ | id | title | description | +----+-------+-------------+ | 1 | None | NULL | | 2 | Test | NULL | +----+-------+-------------+ 2 rows in set (0.00 sec) |
|
From: Andrew T. <ajt...@hi...> - 2006-07-20 21:20:12
|
On 7/20/06, Miles Beck <mil...@gm...> wrote: > On 7/20/06, Kevin <ke...@dr...> wrote: > > I don't understand. This should never happen. Please turn on > > FOF_DB_DEBUG and let me know what error you get with this query: > > > > SELECT id, title, description > > FROM <category table name> > > ORDER BY title > > I'm not sure I am using the above command correctly. I issued the > following command from mysql. What kevin means is that <category table name> is the table name as set in your config.php so probably something like: fr_categories Andrew -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
|
From: Andrew T. <ajt...@hi...> - 2006-07-20 21:18:29
|
On 7/20/06, Kevin <ke...@dr...> wrote:
>
> current logic to get the value for link. I know it needs to be changed to
> make it work better, but I don't know how.
Thanks for showing the root of the issue. I would think the first step
would be to re-order the priority of how a link is obtained. First if
there is a "link", use that, then the enclosure url perhaps, and
finally the GUID.
I agree that I didn't really realize the possible problems either
before. GUID was typically URL since that has to be unique. HOwever,
the GUID doesn't *need* to be the URL.
Andrew
> in class FOF_RssItem (lib/model/rss.php)
>
>
> function getLink()
> {
> if(isset($this->item['guid'])) {
> $link = $this->item['guid'];
> }
> elseif (isset($this->item['link'])) {
> $link = $this->item['link'];
> }
> elseif (isset($this->item['enclosure@url'])) {
> $link = $this->item['enclosure@url'];
> }
> else {
> // generate hash for item
> $title = $this->getTitle();
> $content = $this->getContent();
>
> $hash = md5( $title . $content );
> $link = sprintf('%s#%s',$this->feed_link, $hash);
> }
>
> return $link;
> }
>
>
>
>
>
> --
> Kevin
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Fofredux-devel mailing list
> Fof...@li...
> https://lists.sourceforge.net/lists/listinfo/fofredux-devel
>
--
Andrew Turner
ajt...@hi... 42.4266N x 83.4931W
http://highearthorbit.com Northville, Michigan, USA
|
|
From: Miles B. <mil...@gm...> - 2006-07-20 19:32:42
|
On 7/20/06, Kevin <ke...@dr...> wrote: > I don't understand. This should never happen. Please turn on > FOF_DB_DEBUG and let me know what error you get with this query: > > SELECT id, title, description > FROM <category table name> > ORDER BY title I'm not sure I am using the above command correctly. I issued the following command from mysql. SELECT id, title, description FROM None ORDER BY title; I don't have any Categories added so I tried None as this is displayed in the category listing. And I get the following error: ERROR 1146 (42S02): Table 'fofreduxtest.None' doesn't exist Then I added a category thinking maybe I had to have a category other than "None" for this to work and I got the below error: ERROR 1146 (42S02): Table 'fofreduxtest.Test' doesn't exist |
|
From: Kevin <ke...@dr...> - 2006-07-20 19:31:36
|
> So there seems to be some oddity that's cropped up in how a item link
> is being set from Atom feeds such as Feedburner.
fr_item.link is a field with two purposes. It holds a URL for the item,
but also holds a unique identifier for the item. The problem is, a singl=
e
value can't always fulfill both purposes simultaneously. Here is the
current logic to get the value for link. I know it needs to be changed t=
o
make it work better, but I don't know how.
in class FOF_RssItem (lib/model/rss.php)
function getLink()
{
if(isset($this->item['guid'])) {
$link =3D $this->item['guid'];
}
elseif (isset($this->item['link'])) {
$link =3D $this->item['link'];
}
elseif (isset($this->item['enclosure@url'])) {
$link =3D $this->item['enclosure@url'];
}
else {
// generate hash for item
$title =3D $this->getTitle();
$content =3D $this->getContent();
$hash =3D md5( $title . $content );
$link =3D sprintf('%s#%s',$this->feed_link, $hash);
}
return $link;
}
--=20
Kevin
|
|
From: Kevin <ke...@dr...> - 2006-07-20 19:15:35
|
> On 7/20/06, Kevin <ke...@dr...> wrote: >> I just made a few big commits tonight. Please retest this. I tried >> adding and deleting categories and all works for me. >> >> -Kevin > > Just tried out the 0720 snapshot and I am seeing the same problems > with adding and feed editing feeds. > > When trying to add a feed > Fatal error: Call to a member function on a non-object in > /var/www/fofreduxtest/lib/view_helper.php on line 272 > > When trying to edit a feed: > Fatal error: Call to a member function on a non-object in > /var/www/fofreduxtest/lib/view_helper.php on line 272 I don't understand. This should never happen. Please turn on FOF_DB_DEBUG and let me know what error you get with this query: SELECT id, title, description FROM <category table name> ORDER BY title > Deleting the category no longer hides the feeds. Yea! --=20 Kevin |
|
From: Miles B. <mil...@gm...> - 2006-07-20 16:36:21
|
On 7/20/06, Kevin <ke...@dr...> wrote: > I just made a few big commits tonight. Please retest this. I tried > adding and deleting categories and all works for me. > > -Kevin Just tried out the 0720 snapshot and I am seeing the same problems with adding and feed editing feeds. When trying to add a feed Fatal error: Call to a member function on a non-object in /var/www/fofreduxtest/lib/view_helper.php on line 272 When trying to edit a feed: Fatal error: Call to a member function on a non-object in /var/www/fofreduxtest/lib/view_helper.php on line 272 Both of these errors show up after "Category". Deleting the category no longer hides the feeds. |
|
From: Andrew T. <ajt...@hi...> - 2006-07-20 13:50:40
|
So there seems to be some oddity that's cropped up in how a item link is being set from Atom feeds such as Feedburner. For example, the feed: http://feeds.feedburner.com/planetrubyonrails Has a valid link for articles. http://feeds.feedburner.com/%7Er/ApproachingNormal/%7E3/http://www.approachingnormal.com/articles/2006/07/20/links-for-7-19 However, it seems that the link for the item is actually being set to the guid. urn:uuid:dce39d8c-a40d-4be6-8183-94e9262d65df hrm.... Similar is happending to this RSS2 feed: http://www.macgeekery.com/feeds/macgeekery.xml where the guid is being used even though it explicity says "isPermaLink=false" is the "link" being returned by the RSS parser, or is our model using the GUID incorrectly? -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
5 messages has been excluded from this view by a project administrator.
