FMSLogo Code

Add assert(!is_freed(nd)) to nodetype().
This required making is_freed return false when given NIL.
This was done to make freed memory use bugs easier to find.

Fix a memory leak in LPUT when it had bad input and the :erract handler returned a newly allocated list.
The leak was introduced in recent refactoring when llput was made to use validate_list_argument().
The problem is that the list NODE* that should have been gcref'd was also used to walk the list,
so NIL ended up being gcref'd instead.

Refactoring: inline untreeify()
After recent changes, it was only called from untreeify_body() and that function only called untreeify().
Therefore, the existence of both functions wasn't justified.
I retained the function with the stronger name.

Cleanup: Remove unused function untreeify_line.
This because unneeded when treeifying a proc's bodylist stopped changing each body line into a TREE.

Fix a comment

Update the baseline testlog based on a recent test pass.

Fix a recent regression where, if treeifying a procedure resulted in loading a file that
redefined the procedure that was being treeified, the act of redefining the procedure
would free the tree that had been created thus far, causing a freed memory read.

The fix is to explicitly hold a reference the tree as it's being created, instead of
assuming that the procnode would keep a reference on it.

Fix the name of EVALTEST.SILENTLOADFROMTREEIFY (late change)

Add EVALTEST.SILENTLOADFROMTREEIFY
This is a test for a new regression that prevents ORIENTATIONTEST from running.
ORIENTATIONTEST test this bug incidentally, but EVALTEST.SILENTLOADFROMTREEIFY tests it explicitly.

Change the way reeification is implemented so that only trees are untreeified.
This enables the addition of "assert(is_tree(tree))" in settreepair__tree, which may make it easier to identify future bugs.