Re: [Flamerobin-devel] System tables progress

[Nando D. <na...@de...>]

Milan,

M> Done.

Why is the assigment to desc commented out?

    catch (IBPP::Exception &e)
    {
        // FB 2.0 supports descriptions for some objects that previous
        // FB versions don't
        //desc = _("Description could not be loaded.");
    }

BTW seeing exceptions misused as flow control constructs always
outrages me - I'll make an exception (pun intended) in this case
because I can see you took the easy way, and the correct way would
be complex. But, at least, could we check the exception type?
Something like:

    catch (IBPP::SQLException &e)
    {
        // FB 2.0 supports descriptions for some objects that previous
        // FB versions don't
        if (e.SqlCode() == -206) // column does not belong to referenced table.
            desc = _("Description not available.");
        else
            throw;
    }

P.S. Do we need a similar fix in saveDescription, or is the built-in
exception suitable for now? I guess so, since we're going to get back
to the problem of different Fb versions sooner or later.

Ciao
--
Nando Dessena