Re: [Flamerobin-devel] Context menu command structure

[Nando D. <na...@de...>]

 Michael,

> - The name is not really fitting. Single statements or sequences of
> them are created with these commands, but no scripts.

I disagree. Sequences of statements are commonly known as scripts. SQL
templates can generate whatever is supported by the SQL frame, which
include multiple statements and also pseudo-statements such as SET TERM.
So I think that "Generate script" is a more fitting name. Perhaps
"Generate code" would be better?

> - It's important, so it should come much earlier in the context menu.
> Especially as some existing commands (and the code behind them) can
> probably be replaced by statement templates.

Agreed.

> Proposed:
>
> &SELECT * FROM &INSERT INTO --- &Generate statements > --- Show
> &columns info &Add column... --- Dr&op --- Re&fresh P&roperties
>
> Or even
>
> &Open --- &Generate statements > --- Show &columns info &Add
> column... --- Dr&op --- Re&fresh P&roperties

I like this last option better. I'm not even sure the Add column item is
really needed there.

I didn't really think throughly about where to put the item, I just
found a place that would add the item to all menus I was interested in. ;-)

Wouldn't it be clearer to delete the code in
ContextMenuMetadataItemVisitor::visitMetadataItem() and just construct
each menu independently, with the aid of helper functions?
-- 
Nando Dessena