Re: [Flamerobin-devel] BLOB-Editor as Dialog - Patch 001

[Andreas M. <an...@we...>]

Milan Babuskov schrieb:
> Andreas Maier wrote:
>   
>> this patch includes the Blob-Editor:
>> - wxNotebook-tab with binary (readonly) and Text-Editor
>>     
>
> Hi Andreas,
>
> Screenshot looks very nice. Few notes about the patch:
>
> 1. There are some extra qualifications in DataGridRows. When you're 
> inside class declaration, there's no need for extra qualification. Example:
>
> class DataGridRows
> {
> ...	
> 	void DataGridRows::something();		// bad
> 	void something();			// good
>
> BTW, such code fails to compile on GCC, with error message like this:
>
> ../src/gui/controls/DataGridRows.h:139: error: extra qualification 
> 'DataGridRows
>
>
> 2. when adding new files, you should add .cpp and .h file to 
> flamerobin.bkl and use bakefile_gen program to regenerate the makefiles. 
> We currently use Bakefile 0.2.5.
>
> Please feel free to ask here if you have any questions/problems 
> regarding these (or any other) issues.
>   
Currently i'm using CodeBlocks and gcc (mingw) and it compiles great.

I've downloaded and installed bakefile 0.2.5. I will try it tomorrow.

BTW. My mainlanguage is delphi. I never worked on a real project in c++ 
nor wxWidgets.
So if i code some crazy line, please be patient. ;-).

Andy