Re: [Flamerobin-devel] BLOB-Editor as Dialog - Patch 001

[Michael H. <mg...@gm...>]

Hi,

Andreas Maier wrote:

> this patch includes the Blob-Editor:
> - wxNotebook-tab with binary (readonly) and Text-Editor
> 
> For layout see screenshot.
> Tested under Windows XP (32 Bit).

the screen shot looks really good.  As soon as I find the time I will 
try on Mac OS X and report back.

> Personally i would prefer to "chech" data on loading. If a 0 char is 
> detected text-tab will be disabled.
> Comments?

I don't know whether that's good.  If a BLOB contains UTF-16 characters 
chances are high that a 0 is found.  Actually I don't know at all what 
to do about character sets in BLOBs...

BTW: From a cursory glance over the patch I saw that you used indexed 
access to a wxString character - that's something we need to avoid if 
possible.  I will post another message regarding this issue.

Thanks for your work on this

-- 
Michael Hieke