fetchmail-devel — Development related discussion

Re: [fetchmail-devel] fetchmail-6.2.6.alpha2 released - please test

[Matthias A. <mat...@gm...>]

Brian Candler <B.C...@po...> writes:

> Attached - also fixes some gross XML errors. This document is still not
> well-formed according to xmlwf, but I don't have any better tools to isolate
> where the error now is. Looks like a missing </p> somewhere.

Thank you. I'd already fixed conformance (xmllint --noout --postvalid
had no complaints) for -pre3, so we're fine in this regard.

-- 
Matthias Andree

Re: [fetchmail-devel] Minor typo in the NEWS file

[Matthias A. <mat...@gm...>]

perry hutchison <phu...@be...> writes:

> ...
>> * Added Andrey Lelikov's recupe for Hotmail and Lycos Webmail.
> ...
>
> That should be recipe, I imagine :)

Probably. Will be fixed.

-- 
Matthias Andree

Re: [fetchmail-devel] fetchmail-6.2.6.alpha2 released - please test

[Brian C. <B.C...@po...>]

On Mon, Jul 04, 2005 at 12:30:56AM +0200, Matthias Andree wrote:
> Leaving differences /etc/ssl vs. /etc/openssl aside - my system uses
> /etc/ssl - would you care to write this up for fetchmail-FAQ.html?

Attached - also fixes some gross XML errors. This document is still not
well-formed according to xmlwf, but I don't have any better tools to isolate
where the error now is. Looks like a missing </p> somewhere.

Regards,

Brian.

[fetchmail-devel] Minor typo in the NEWS file

[perry h. <phu...@be...>]

...
> * Added Andrey Lelikov's recupe for Hotmail and Lycos Webmail.
...

That should be recipe, I imagine :)

Re: [fetchmail-devel] New Spanish PO file for `fetchmail'

[Nico G. <ni...@ng...>]

* Translation Project Robot <tra...@ir...> [2005-07-05 19:59]:
> Hello, gentle maintainer. This is a message from the Translation
> Project robot.

please have a look at the latest patch for the po file.
regards nico

-- 
Nico Golde - JAB: ni...@ja... | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org 
VIM has two modes - the one in which it beeps 
and the one in which it doesn't -- encrypted mail preferred

Re: [fetchmail-devel] [PATCH]

[Nico G. <ni...@ng...>]

Hallo Matthias,

* Matthias Andree <mat...@gm...> [2005-07-04 21:44]:
> Nico Golde <ni...@ng...> writes:
> 
> > diff -Nurb fetchmail-6.2.5/interface.c fetchmail.new/interface.c
> > --- fetchmail-6.2.5/interface.c	2003-07-17 17:27:29.000000000 +0200
> > +++ fetchmail.new/interface.c	2005-07-01 13:42:33.000000000 +0200
> > @@ -25,6 +25,7 @@
> >  #if defined(HAVE_UNISTD_H)
> >  #include <unistd.h>
> >  #endif
> > +#include <sys/utsname.h>
> >  #include <sys/ioctl.h>
> >  #include <sys/socket.h>
> >  #include <netinet/in.h>
> > @@ -75,22 +76,22 @@
> >  void interface_init(void)
> >  /* figure out which /proc/dev/net format to use */
> >  {
> > -    FILE *fp = popen("uname -r", "r");	/* still wins if /proc is out */
> > +    struct utsname ut;
> > +    int rc = uname(&ut);
> 
> ...
> 
> > -	if (fscanf(fp, "%d.%d.%*d", &major, &minor) >= 2
> > +	if (sscanf(ut.release, "%d.%d.%*d", &major, &minor) >= 2
> >  					&& major >= 2 && minor >= 2)
> 
> This is bogus. How about major == 3 and minor == 0?
> It'll assume the old 2.0 format.
> 
> A similar patch to get rid of the popen() by Paul Slootman has been
> merged in November 2004, see
> <http://decoy.wox.org/svn/fetchmail/trunk/interface.c> for the current
> state.

OK, then everything's fine, because removing popen() was the
patch's author's intention
Regards Nico
-- 
Nico Golde - JAB: ni...@ja... | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org 
VIM has two modes - the one in which it beeps 
and the one in which it doesn't -- encrypted mail preferred

[fetchmail-devel] New Spanish PO file for `fetchmail'

[Translation P. R. <tra...@ir...>]

Hello, gentle maintainer. This is a message from the Translation
Project robot.

A revised PO file, for programs using the textual domain `fetchmail',
has been submitted by the team of translators taking care of the
Spanish language.  This particular file, along with all other PO files
pertaining to the same textual domain, is available as:
>    http://www.iro.umontreal.ca/translation/maint/fetchmail/es.po

The file should soon be made available in mirror sites as:

>    ftp://ftp.unex.es/pub/gnu-i18n/po/maint/fetchmail/es.po
>    http://translation.sf.net/maint/fetchmail/es.po
>    ftp://tiger.informatik.hu-berlin.de/pub/po/maint/fetchmail/es.po

This file has already been sent to you separately on 2005-07-05,
as a MIME invoice unpacking the file `fetchmail-6.2.6-pre3.es.po'.

The following HTML page should also be updated by tomorrow.

>    http://www.iro.umontreal.ca/translation/HTML/domain-fetchmail.html

Please consider including all PO files, as they stand, in the `po/'
subdirectory of your next release of programs using that textual domain,
whether it is official or pretest.  Whenever you have a distribution ready
which holds a newer PO Template, please send the URL of this distribution
to the address below.  The distribution could be a pretest or a snapshot,
it does not even have to compile.  This is to be used by translators,
when they need to get some translation context from your sources.

Within the Translation Project, each PO Template file should have different
version numbers, but since it is not OK to have two different distributions
using same version numbers, this is not a problem in practice.

Contact me if any question arises.  Thanks for your collaboration,

                                The Translation Project robot, in the
                                name of your translation coordinator.
                                mailto:tra...@ir...

[fetchmail-devel] New Polish PO file for `fetchmail'

[Translation P. R. <tra...@ir...>]

Hello, gentle maintainer. This is a message from the Translation
Project robot.

A revised PO file, for programs using the textual domain `fetchmail',
has been submitted by the team of translators taking care of the
Polish language.  This particular file, along with all other PO files
pertaining to the same textual domain, is available as:
>    http://www.iro.umontreal.ca/translation/maint/fetchmail/pl.po

The file should soon be made available in mirror sites as:

>    ftp://ftp.unex.es/pub/gnu-i18n/po/maint/fetchmail/pl.po
>    http://translation.sf.net/maint/fetchmail/pl.po
>    ftp://tiger.informatik.hu-berlin.de/pub/po/maint/fetchmail/pl.po

This file has already been sent to you separately on 2005-07-05,
as a MIME invoice unpacking the file `fetchmail-6.2.6-pre3.pl.po'.

The following HTML page should also be updated by tomorrow.

>    http://www.iro.umontreal.ca/translation/HTML/domain-fetchmail.html

Please consider including all PO files, as they stand, in the `po/'
subdirectory of your next release of programs using that textual domain,
whether it is official or pretest.  Whenever you have a distribution ready
which holds a newer PO Template, please send the URL of this distribution
to the address below.  The distribution could be a pretest or a snapshot,
it does not even have to compile.  This is to be used by translators,
when they need to get some translation context from your sources.

Within the Translation Project, each PO Template file should have different
version numbers, but since it is not OK to have two different distributions
using same version numbers, this is not a problem in practice.

Contact me if any question arises.  Thanks for your collaboration,

                                The Translation Project robot, in the
                                name of your translation coordinator.
                                mailto:tra...@ir...

[fetchmail-devel] typo in msgid (fetchmail 6.2.6-pre3)

[Jakub B. <qb...@pl...>]

Hello,

I found a typo in msgid:

> #: fetchmail.c:1650
> msgid "  Idle after poll is diabled (idle off).\n"
                              ^^^^^^^

should be "disabled".


-- 
Jakub Bogusz    http://qboosh.cs.net.pl/

[fetchmail-devel] New PO Template file for `fetchmail'

[Translation P. R. <tra...@ir...>]

Hello, gentle maintainer. This is a message from the Translation
Project robot.

A new PO Template file, for programs using the textual domain
`fetchmail', has just been made available to language teams for
translation, and a copy is available as:
>    http://www.iro.umontreal.ca/translation/domains/POT/fetchmail-6.2.6-pre3.pot

The file should soon be made available in mirror sites as:

>    ftp://ftp.unex.es/pub/gnu-i18n/po/domains/POT/fetchmail-6.2.6-pre3.pot
>    http://translation.sf.net/domains/POT/fetchmail-6.2.6-pre3.pot
>    ftp://tiger.informatik.hu-berlin.de/pub/po/domains/POT/fetchmail-6.2.6-pre3.pot


In your releases, this file is usually found as `po/fetchmail.pot'.
It is created or updated automatically at `make dist' time, or
whenever you run `make update-po' in the `po/' subdirectory.  Whenever
you have a distribution ready which holds a newer PO Template, please
send the URL of this distribution to the address below.  The
distribution could be a pretest or a snapshot, it does not even have
to compile.  This is to be used by translators, when they need to get
some translation context from your sources.

Within the Translation Project, each PO Template file should have
different version numbers, but since it is not OK to have two
different distributions having same version numbers, this is not a
problem in practice.
Here is the URL information which has just been provided to translators for
your package.  Please inform the translation coordinator, at the address
given below, if the information does not appear to be adequate or current:

>    http://home.pages.de/~mandree/fetchmail/fetchmail-6.2.6-pre3.tar.bz2

Translated PO files will later be automatically e-mailed to you.

Thanks for your collaboration,

                                The Translation Project robot, in the
                                name of your translation coordinator.
                                mailto:tra...@ir...

Re: [fetchmail-devel] Fetchmail bounce message

[Nico G. <ni...@ng...>]

Hallo Matthias,

* Matthias Andree <mat...@gm...> [2005-07-04 21:44]:
> Nico Golde <ni...@ng...> writes:
> 
> > this is the newest bug in the debian bts:
> > When the local SMTP daemon rejects a message, Fetchmail generates a 
> > bounce messages with a non-null reverse-path, in violation of RFCs. In 
> > addition, the username it uses (FETCHMAIL-DAEMON) does not exist, so any 
> > responses will themselves bounce. This is likely to generate mail
> > loops.
> 
> I believe Holger Mauermann's patch fixes most of these issues, from NEWS:
> 
> * Holger Mauermann's bounce patch, to use a NULL envelope from, not
>   write a Return-Path header (both to meet RFC-2821), changed From,
>   added Subject header, rewording the human readable part. (Matthias Andree)

Ok. good.

> > In addition to generating a bounce, the original mail is forwarded to 
> > postmaster, as can be seen on the last couple of lines above. My 
> > understanding of the man page is that either a bounce should be 
> > generated *or* it should be forwarded to the postmaster address, but not 
> > both.
> 
> We'd need to check if the SVN version still forwards the message to the
> postmaster.
> 
> Perhaps time to roll 6.3.0-beta1 so that people can check if their
> favorite bugs persist?

Ok would be nice. But I will only provide a link to the beta
in the bts, I think a official package in the pool wouldn't
be a good idea.
Regards Nico
-- 
Nico Golde - JAB: ni...@ja... | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org 
VIM has two modes - the one in which it beeps 
and the one in which it doesn't -- encrypted mail preferred

Re: [fetchmail-devel] Query status

[Nico G. <ni...@ng...>]

Hallo Matthias,

* Matthias Andree <mat...@gm...> [2005-07-04 21:44]:
> Nico Golde <ni...@ng...> writes:
> 
> > * Matthias Andree <mat...@gm...> [2005-07-01 10:24]:
> >> Nico Golde <ni...@ng...> writes:
> >> > when does Query status=24 happen?
> >> 
> >> Where or how did you get that message?
> >> 
> >> 24 is PS_TRANSIENT.
> >
> > I took this from the debian bug tracking system.
> > Bug 250253
> 
> OK, the original reporter didn't provide sufficient information and has
> no way to reproduce the bug. I suggest that this bug be suspended until
> further information is available -- there are too many code paths to
> check.

Ok, I will wait some time and then close this.
Regards Nico
-- 
Nico Golde - JAB: ni...@ja... | GPG: 0x73647CFF
http://www.ngolde.de | http://www.muttng.org | http://grml.org 
VIM has two modes - the one in which it beeps 
and the one in which it doesn't -- encrypted mail preferred

[fetchmail-devel] fetchmail-6.2.6-pre3 released - please test

[Matthias A. <mat...@gm...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Greetings,

I have released a snapshot of the current fetchmail development code,
labelled as fetchmail-6.2.6-pre3. If fixes some things since .alpha2 and
was dubbed -pre3 rather than .alpha3 to help the translation project.

The chances since .alpha2 summarized:

- - IPv6 (--enable-inet6) fixes
- - the .html documents were fixed to be conformant XHTML
- - the .fetchmailrc parser was broken in .alpha1, now fixed.
- - the message when .fetchids was to be deleted contained garbage, now fixed
- - documentation was updated a bit

If you have a test machine available, please test this version and
report back if it worked for you, if it fixed your favourite 6.2.5 bugs,
or if it introduced new bugs, or if you tested it without anything in
particular. I am aware that some translations are not up to date, so in
that case, help out with the translation project instead.

In case it fails to compile, please state your ./configure option, the
exact error message, your operating system and version - or just gzip
and attach the config.log file.

Note this all comes without warranty, as usual.

Download from:
<http://home.pages.de/~mandree/fetchmail/fetchmail-6.2.6-pre3.tar.bz2>

Regards,

- -- 
Matthias Andree
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCyY0gvmGDOQUufZURAixtAJ4pZTBmvwM4GcqfE/mlbp21xFPYgwCgjhuZ
lhXMgR71t5j8bCQyr7CUV20=
=Et/R
-----END PGP SIGNATURE-----

Re: [fetchmail-devel] Re: [fetchmail]user help needed: please test fetchmail 6.2.6.alpha1 snapshot

[Matthias A. <mat...@gm...>]

Jakob Hirsch <jh...@pl...> writes:

> poll mx.freenet.de user xxxxx pass xxxxxxx fetchall ssl
> poll pop.gmail.com user yy...@gm... pass yyyy fetchall ssl
> [...]
>
> which worked here fine all the time. With the alpha:
>
> $ fetchmail -v
> fetchmail: 6.2.6.alpha1 querying cip.rz.fh-offenburg.de (protocol POP3) 
> at Sat, 02 Jul 2005 23:33:19 +0200 (CEST): poll started
> [...]
> fetchmail: POP3< +OK <105...@mx...>
> fetchmail: POP3> CAPA
> fetchmail: POP3< +OK
> fetchmail: POP3< EXPIRE NEVER
> fetchmail: POP3< TOP
> fetchmail: POP3< UIDL
> fetchmail: POP3< USER
> fetchmail: POP3< XAUTHLIST
> fetchmail: POP3< XSENDER
> fetchmail: POP3< STLS
> fetchmail: POP3< .
> fetchmail: POP3> USER xxxxxxx pass
> fetchmail: POP3< +OK user ok
> fetchmail: POP3> PASS *
> fetchmail: POP3< -ERR permission denied
>
> note the "pass" after "USER xxxxxxx", which seems to come from
> fetchmailrc.

Strange, I don't have this here.

Try reverting the attached patch (use patch -R) and let me know if that
fixes your problem. It was labelled "Fix memory leak." and committed
2005-03-06.

> fetchmail: terminated with signal 2
> fetchmail: Error deleting No such file or directory: ì
> ÿ0è/ÖþÿÄ
> PhZÿ5¨è

Confirmed & fixed for the next release.

-- 
Matthias Andree

Re: [fetchmail-devel] fetchmail-6.2.6.alpha2 released - please test

[Matthias A. <mat...@gm...>]

[Please reply to the fetchmail-devel list, I forgot to set the header on
my first post. Reply-To: is set now.]

On Sun, 03 Jul 2005, Brian Candler wrote:

> On Sun, Jul 03, 2005 at 09:41:17PM +0200, Matthias Andree wrote:
> > I have released a snapshot of the current fetchmail development code,
> > labelled as fetchmail-6.2.6.alpha2.
> 
> The INSTALL file is very Linux-specific (talking about required versions of
> glibc, for example).
> 
> I run FreeBSD 5.4 and I note:
> 
> "Fetchmail has had serious grief from buggy versions of the gettext suite.
> If your version is older than 1.10.40, you should use the configure
> option --with-included-gettext'."

Ah well. As long as the fetchmail build doesn't complain (--disable-nls
would be your workaround), you should be fine. I'm using 0.14.1 to build
fetchmail.

I've revised INSTALL a bit (attached). In the long run, the IPsec code
and all references to inet6-apps will disappear, inet6-apps is, to the
best of my knowledge, no longer available.

> Separate point: it might be worth documenting how to set up certificate
> verification. I always have to rummage through the OpenSSL source to find
> out how to do this. For reference I did the following:
> 
> - mkdir /etc/openssl/certs
> - from the openssl/certs directory: cp *.pem /etc/openssl/certs/
> - in the openssl/tools directory: edit c_rehash and set $dir = "/etc/ssl"
>   then run "perl c_rehash"
> - in .fetchmailrc, set option "sslcertpath /etc/ssl/certs"

Leaving differences /etc/ssl vs. /etc/openssl aside - my system uses
/etc/ssl - would you care to write this up for fetchmail-FAQ.html?

-- 
Matthias Andree

Re: [fetchmail-devel] fetchmail-6.2.6.alpha2 released - please test

[Brian C. <B.C...@po...>]

On Sun, Jul 03, 2005 at 09:41:17PM +0200, Matthias Andree wrote:
> I have released a snapshot of the current fetchmail development code,
> labelled as fetchmail-6.2.6.alpha2.

The INSTALL file is very Linux-specific (talking about required versions of
glibc, for example).

I run FreeBSD 5.4 and I note:

"Fetchmail has had serious grief from buggy versions of the gettext suite.
If your version is older than 1.10.40, you should use the configure
option --with-included-gettext'."

I have package gettext-0.14.1 installed, and the one in the ports tree is
currently 0.14.5. Any indication of the compatibility of those? It seems to
work for me, but then again, I'm not translating into any non-English
language.

Separate point: it might be worth documenting how to set up certificate
verification. I always have to rummage through the OpenSSL source to find
out how to do this. For reference I did the following:

- mkdir /etc/openssl/certs
- from the openssl/certs directory: cp *.pem /etc/openssl/certs/
- in the openssl/tools directory: edit c_rehash and set $dir = "/etc/ssl"
  then run "perl c_rehash"
- in .fetchmailrc, set option "sslcertpath /etc/ssl/certs"

Regards,

Brian.

[fetchmail-devel] fetchmail-6.2.6.alpha2 released - please test

[Matthias A. <mat...@gm...>]

Greetings,

I have released a snapshot of the current fetchmail development code,
labelled as fetchmail-6.2.6.alpha2.

If you have a test machine available, please test this version and
report back if it worked for you, if it fixed your favourite 6.2.5 bugs,
or if it introduced new bugs, or if you tested it without anything in
particular. I am aware that some translations are not up to date, so in
that case, help out with the translation project instead.

In case it fails to compile, please state your ./configure option, the
exact error message, your operating system and version - or just gzip
and attach the config.log file.

Note this all comes without warranty, as usual.

Download from:
<http://home.pages.de/~mandree/fetchmail/fetchmail-6.2.6.alpha2.tar.bz2>

Regards,

-- 
Matthias Andree

Re: [fetchmail-devel] i18n fixes

[Matthias A. <mat...@gm...>]

Miloslav Trmac <mi...@re...> writes:

> attached is a patch to avoid sentence pasting from separately
> translated segments and to use ngettext () more; an updated Czech
> translation against fetchmail with this patch is at
> http://carolina.mff.cuni.cz/~trmac/fetchmail-6.2.6.alpha1.po

Thanks a lot. This file committed as po/cs.po, rest committed, de.po
updated, too. cs.po appears to have three untranslated messages.

> I'm not sure whether it would be better to put this in now and
> either wait for updated translations or ship with obsolete
> translations, or to wait after the release and send a prerelease
> with these changes to the Translation Project immediately afterwards.

We'll put this in an send -alpha2 to the translation project and then
update translations as they come in. If a translation is then too
outdated, it will be dropped.

-- 
Matthias Andree

Re: [fetchmail-devel] user help needed: please test fetchmail 6.2.6.alpha1 snapshot

[Matthias A. <mat...@gm...>]

Miloslav Trmac <mi...@re...> writes:

> 6.2.6.alpha1 (with the patches I'll be sending shortly, although
> I don't think they made a difference) seems to work fine in a one-mail
> test here.  There's just a minor new annoyance: write_saved_lists()
> reports "Error deleting ....fetchids: ..." even for ENOENT (when the list
> was empty and is to be kept empty).

Thanks. I've added "&& errno != ENOENT" so we don't complain when the
file we're about to delete doesn't exist.

-- 
Matthias Andree

Re: [fetchmail-devel] fetchmail 6.3.0-beta1 next week?

[Matthias A. <mat...@gm...>]

Miloslav Trmac <mi...@re...> writes:

> Attached are patches used in Fedora / Red Hat packaging.  I'm not
> quite sure about their authorship, my best guess is that they
> are all by Nalin Dahyabhai.
>
> fetchmail-6.2.5-krb5.patch:

Merged.

> fetchmail-6.2.6.alpha1-crlf.patch:
>   The code uses snprintf () to avoid buffer overflows, and it adds '\r\n'
>   in another snprintf (); if the buffer is already full, the "\r\n" wouldn't
>   get added, corrupting the following line.  The patch reserves 2 bytes
>   for the line termination.
>   (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=114470)

Good catch. Committed.

> fetchmail-6.2.6.alpha1-krb5-config.patch:

Committed.

> Another thing is shipping the attached fetchmailconf.man so that
> (man fetchmailconf) works.

I needed to change this to ".so man1/fetchmail.1" so this works on my
FreeBSD and SUSE Linux machines.

> And finally, the current rpa.c doesn't compile; fixed by attached
> fetchmail-6.2.6.alpha1.rpa.patch.

Merged.

Thank you.

-- 
Matthias Andree

Re: [fetchmail-devel] Cleanups

[Matthias A. <mat...@gm...>]

Miloslav Trmac <mi...@re...> writes:

> fetchmail-6.2.6.alpha1-conf.patch is uncontroversial, I hope:
> it removes checks and definitions that the code doesn't use from
> configure.ac.

Committed.

> fetchmail-6.2.6.alpha1-warn.patch is large, therefore hard to review
> and somewhat risky: it modifies the code to avoid all warnings
> from gcc-4.0 with -W -Wall.

I'm not going to merge this, as I fear that just spraying casts all over
the code will make doing the *real* fix harder.

> Most of the changes are cosmetics, making the code more explicit,
> but the reply_hack () prototype change is a real bug fix: the
> code was using (int *) to point to a size_t, which can lead to
> unexpected behavior on 64-bit machines.

This one I merged manually and committed it. Good catch, thank you!

We'll review the rest of your patch after the next release. We'll
carefully have to review variable types, where are they signed, where
are they unsigned, as sometimes signed is dangerous.

> Other changes include removing unused parameters and variables
> (or silencing the warning if the parameters are a part of the driver
> interface and are used in other transports), adding casts to make
> comparisons of signed and unsigned types eplicit.

I'm willing to commit fixes that cast unused arguments to void.

> Eventually I'd like to clean up the code to assume an ISO C-90
> compliant compiler (STDC_HEADERS, HAVE_STDARG_H, ...), but those
> changes can really wait after the release.

I'd think so.

-- 
Matthias Andree

[fetchmail-devel] Cleanups

[Miloslav T. <mi...@re...>]

Hello,
To keep the tradition of destabilizing changes appearing as soon as
a freeze is called for, here are a few cleanups.

fetchmail-6.2.6.alpha1-conf.patch is uncontroversial, I hope:
it removes checks and definitions that the code doesn't use from configure.ac.


fetchmail-6.2.6.alpha1-warn.patch is large, therefore hard to review
and somewhat risky: it modifies the code to avoid all warnings
from gcc-4.0 with -W -Wall.

Most of the changes are cosmetics, making the code more explicit,
but the reply_hack () prototype change is a real bug fix: the
code was using (int *) to point to a size_t, which can lead to
unexpected behavior on 64-bit machines.

The largest part of the patch adds explicit casts between
(char *) and (unsigned char *); the C standard requires an explicit
cast for these conversions, although gcc currently accepts them.
Note that adding the casts like this is mostly a work-around; the
code should probably standardize on one kind of character pointers
(my vote would be (char *) to be consistent with string literals
and <string.h>) - but changing the pointer type requires a very
careful review of the affected code.

Other changes include removing unused parameters and variables
(or silencing the warning if the parameters are a part of the driver
interface and are used in other transports), adding casts to make
comparisons of signed and unsigned types eplicit.

Except for the reply_hack() change above, I'm not sure this patch
should go in before the freeze.  Anyway, I think it is better
to send it and see it rejected than to just delete it.

Eventually I'd like to clean up the code to assume an ISO C-90
compliant compiler (STDC_HEADERS, HAVE_STDARG_H, ...), but those
changes can really wait after the release.
	Mirek

Re: [fetchmail-devel] fetchmail 6.3.0-beta1 next week?

[Rob F. <rf...@fu...>]

Matthias Andree wrote:
> what are the opinions WRT freezing the current Subversion repository
> contents and releasing fetchmail 6.3.0-beta1 early next week so that we
> might be able to release the proper 6.3.0 in August?

Sounds good to me.

And thanks for all the work you've been putting into this!

-- 
==============================|   "A microscope locked in on one point
 Rob Funk <rf...@fu...> |Never sees what kind of room that it's in"
 http://www.funknet.net/rfunk |    -- Chris Mars, "Stuck in Rewind"

[fetchmail-devel] i18n fixes

[Miloslav T. <mi...@re...>]

Hello,
attached is a patch to avoid sentence pasting from separately
translated segments and to use ngettext () more; an updated Czech
translation against fetchmail with this patch is at
http://carolina.mff.cuni.cz/~trmac/fetchmail-6.2.6.alpha1.po

The patch doesn't add ngettext () usage to all the "(%d octets")
sentences because it isn't necessary for Czech (assuming there are
at least 5 octets); it might be necessary for other languages.

I'm not sure whether it would be better to put this in now and
either wait for updated translations or ship with obsolete
translations, or to wait after the release and send a prerelease
with these changes to the Translation Project immediately afterwards.
	Mirek

Re: [fetchmail-devel] fetchmail 6.3.0-beta1 next week?

[Miloslav T. <mi...@re...>]

Hello,
On Sat, Jul 02, 2005 at 02:02:39PM +0200, Matthias Andree wrote:
> what are the opinions WRT freezing the current Subversion repository
> contents and releasing fetchmail 6.3.0-beta1 early next week so that we
> might be able to release the proper 6.3.0 in August?
I guess I don't have any say in this, but having a release this year
would certainly be nice :)

Attached are patches used in Fedora / Red Hat packaging.  I'm not
quite sure about their authorship, my best guess is that they
are all by Nalin Dahyabhai.

fetchmail-6.2.5-krb5.patch:
  Don't use krb5_init_ets (), a private Kerberos function. 

fetchmail-6.2.6.alpha1-crlf.patch:
  The code uses snprintf () to avoid buffer overflows, and it adds '\r\n'
  in another snprintf (); if the buffer is already full, the "\r\n" wouldn't
  get added, corrupting the following line.  The patch reserves 2 bytes
  for the line termination.
  (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=114470)

fetchmail-6.2.6.alpha1-krb5-config.patch:
  Recent Kerberos libraries provide a krb5-config script that can be used
  to find out the necessary options, the patch adds support for that.

Another thing is shipping the attached fetchmailconf.man so that
(man fetchmailconf) works.

And finally, the current rpa.c doesn't compile; fixed by attached
fetchmail-6.2.6.alpha1.rpa.patch.

Thanks,
	Mirek