[eGroupWare-tracker] Patches #2975: Unescaped ampersand in XML not permitted

[<tr...@eg...>]

Ticket modified by Jörg Lehrke at 2011/09/24 19:35
Tracking SystemPatches
CategorySyncML
VersionVersion 1.8.001
StatusOpen
ResolutionFixed
Completed100%
Priority5 - medium
Created byMartino Dell'Ambrogio
Created on2011/05/24 17:48
Assigned toJörg Lehrke
Summary#2975 - Unescaped ampersand in XML not permitted
I am using the last official Debian version available of EGroupware, 1.8.001.20110216, and SyncEvolution on a N900 to synchronise via the SyncML protocol.

The SyncEvolution client validates all XML objects send by the server and EGroupware doesn't seem to escape correctly the ampersand sign within any Data element. We have currently more then 500 business contacts with an ampersand in their name, thefefore the synchronisation fails.

Attached is an ugly patch to make it just work. I guess there is some better place to insert the transformation in, I'll let you take care of that. Thanks !
Comment by Jörg Lehrke at 2011/09/24 19:35:
I tried a different approach with HTML encoding today (trunk Rev. 36709). Could you please check whether this is working for SyncEvolution.
Comment by Jörg Lehrke at 2011/09/24 12:37:
The usage of unquoted special characters within XML breaks the specification. CDATA is the correct way to address this issue but not supported by all clients, though. The HTML-enconding on the other hand does not work for all clients either. To support as many devices as possible EGw tries to serve all special needs but in case of conflicts we have to stick to the standard. Please complain to the affected applications, too.
Comment by Jörg Lehrke at 2011/07/08 22:01:
I hit the same bug today with Funambol v10 clients. It is fixed (if I use the correct manufacturer string) with revisions 35689++.
Thanks for your patients!
Comment by Jörg Lehrke at 2011/06/02 11:16:
I checked this issue again because I was wondering why other clients don't have a problem here. EGw uses  ..  for all content. So the XML-parser should ignore the unquoted ampersand. It really seems to be an bug within SyncEvolution to me now.
Comment by Jörg Lehrke at 2011/05/29 13:08:
You are absolutely right! I will fix this issue with my next update. Thanks for point it it out!


Linked entries:
https://community.egroupware.org/egroupware/index.php?menuaction=tracker.tracker_ui.edit&tr_id=2975&no_popup=1