[eGroupWare-tracker] Bugs #2991: Recurence rules: incorrect matching in monthly rules for Sony Ericsson J10i2

[<tr...@eg...>]

Ticket modified by Jörg Lehrke at 2011/09/24 15:59
Tracking SystemBugs
CategorySyncML
VersionVersion 1.8.001
StatusClosed
ResolutionFixed
Completed100%
Priority5 - medium
Created byJan K
Created on2011/06/19 23:19
Assigned toJörg Lehrke
Summary#2991 - Recurence rules: incorrect matching in monthly rules for Sony Ericsson J10i2
The attached patch copies the behaviour from the yearly rules and makes syncing of recurrent monthly(!) events with J10i2 work (yearly events already seem to be syncing properly).
Am not quite sure if it will badly affect other devices or not, but I'd guess that it shouldn't since they probably use the same format for yearly and monthly? In worst case scenario, maybe the changes should go under an if (J10i2)?

E.g. RRULE: "MD1 23 #0" ... that is, each month on the 23rd till forever and ever
Comment by Jörg Lehrke at 2011/06/25 16:16:
Fixed this issue, too. Revisions 35482++.
Thanks again!
Comment by Jan K at 2011/06/25 14:40:
What about the second part of the patch (2509 line onwards) which fixes monthly rules with a known end date (e.g. MD1 23 2011...)? Without the patch, it tries to pass "23 2011..." to _parseDateTime instead of just 2011...
Comment by Jörg Lehrke at 2011/06/25 14:15:
The first regular expression '/MD(\d+)(?: [^ ])? #(\d+)/' should have covered MD1 23 #0 but there was a '+' missing. The correct regex is
 '/MD(\d+)(?: [^ ]+)? #(\d+)/' now and should fix the issue.
Thanks for noticing this failure!
It is fixed now with revisions 35477++.


Linked entries:
https://community.egroupware.org/egroupware/index.php?menuaction=tracker.tracker_ui.edit&tr_id=2991&no_popup=1