[eGroupWare-tracker] #2035 - Problem replacing links in HTML-Mails

[<tr...@eg...>]

Ticket modified by Klaus Leithoff at 2009/05/22 14:19
Tracking System: Bugs
Category: FelamiMail
Version: Version 1.6.001
Status: Open
Resolution: Accepted
Completed: 30%
Priority: 5 - medium
Created By: Sebastian Meyer
Assigned to: Klaus Leithoff
Summary: #2035 - Problem replacing links in HTML-Mails
FelamiMail replaces all links in the mail-body with links using the /redirect.php, but it does not work on HTML-Mails.

Following content of the body: 
View Document
Normally this will create a link with the Text "Vie Document" with a link to the specified URL.

But viewing such a mail using FelamiMail creating following HTML-Code:
Vie Document

The problem seems inside the class.uidisplay.inc.php:
On line 1015 there is a pre_replace which modifies the link inside the mail because the regex matches the link.
On line 1019 there is also a pre_replace which modifies the linke because the regex matches the link.

It could help testing in line 1015 for a not existing href='|" in front of the link.

Greetings
Sebastian Meyer
Comment by Klaus Leithoff at 2009/05/22 14:19:
by using html::activate_link the problem seems to diminish
But: Still some open issues with that.
Comment by Klaus Leithoff at 2009/04/21 09:34:
commited Sebastian Meyers suggestion to trunk for broader availability to tests: Revision 26830
With my setup it looks o.k. up until now, but as Istvan states, further tests are needed.
Comment by István Pongrácz at 2009/04/08 10:04:
Hi,
I have similar problem with links inside < >, even displaying plain messages.
When this kind of link displayed, it is always include the > character and those characters, which follow it.

The link will be similar:
https : / / mydomain.hu / egroupware / redirect.php ? go=https %3A%2F%2F mydomain.hu %2F directory %2F action %2F52%23comment%3A6%26gt%3B%0ADomain

So, it would be nice to trim the character: '>' and all things after that. It seems, until the first space it includes all characters.

I try to solve it rewriting the preg_replace (thank you for the hint) but until now I failed :(
Comment by Sebastian Meyer at 1970/01/01 01:33:
Hmm... it seems the bug-tracker has the same problem, you can see it in my post.

Changing the pattern on line 1015 like this:
"/(?<!>|\/|\"|href='|href=\")((http(s?):\/\/)|(www\.))([\w,\-,\/,\?,\=,\.,&,!\n,\%,@,\*,#,:,~,\+]+)/ie"

Now the links in HTML-Mails will work.
Hope this will fix bug-tracker, too.


Regards
Sebastian Meyer


Linked entries:
http://www.egroupware.org/egroupware/index.php?menuaction=tracker.tracker_ui.edit&tr_id=2035&no_popup=1