[eGroupWare-tracker] [ egroupware-Bugs-1469897 ] mydms - descriptions with apostrophes

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Bugs item #1469897, was opened at 2006-04-13 15:44
Message generated for change (Comment added) made by icornish
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=554338&aid=1469897&group_id=78745

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: mydms
Group: 1.2 final, no more RC1-8 please !!!
Status: Closed
Resolution: Fixed
Priority: 5
Submitted By: Patrick Yokley (proximo)
Assigned to: Lars Kneschke (lkneschke)
Summary: mydms - descriptions with apostrophes

Initial Comment:
eGroupWare-1.2-1.tar.gz

Updating documents with descriptions having apostrophes
cause insert into mysql failure.

How to repeat:
1. Have an existing document/file in a folder in mydms.
2. Select document to update
3. Select update document
4. Select new file
5. Enter text with apostrophes.
6. Click update

Error inserting into mysql because the apostrophe is
not escaped out.  Error msg is posted below:

Also, side comment on the update screen in english the
comment field identification label is in german and not
english (Kommentar rather than Comment).

---------------error msg----------------
Database error: Invalid SQL: INSERT INTO
phpgw_mydms_DocumentContent (document, version,
comment, date, createdBy, dir, orgFileName, fileType,
mimeType) VALUES (3, 3, 'No change, retesting for
apostrophe (') error', 1144943029, 5, '00004/',
'test_document.doc', '.doc', 'application/msword')
mysql Error: 1064 (You have an error in your SQL
syntax; check the manual that corresponds to your MySQL
server version for the right syntax to use near
'error', 1144943029, 5, '00004/', 'test_document.doc',
'.doc'' at line 1)

File: /var/www/html/egroupware/mydms/inc/inc.DBAccess.php
Line: 47
Function: DatabaseAccess::getResult /
Document::addContent / bomydms::updateFile /
uimydms::updateFile / ExecMethod()

Session halted.

----------------------------------------------------------------------

Comment By: Ian (icornish)
Date: 2006-08-24 09:23

Message:
Logged In: YES 
user_id=1118657

This bug still appears, in 1.2.104 release, updated via 
SVN.

----------------------------------------------------------------------

Comment By: Lars Kneschke (lkneschke)
Date: 2006-07-21 04:17

Message:
Logged In: YES 
user_id=68218

This bug is fixed in our subversion repository now. 

You can update via subversion with the following commands:
cd /var/www/html/egroupware   # replace with your eGW install dir
svn update *

To check if you have cvs availible (on most *nix system it's
installed by default), try:
svn --version
If that gives you a version-number, you have it installed. More
infos about subversion can be found in our wiki:
http://egroupware.org/wiki/subversion

There is no more delay between anonymous access to the repository
and developer access / commits.

If you can't / won't update via subversion: our next packages
will include this bugfix anyway. 

Thank you for your bug report!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=554338&aid=1469897&group_id=78745