Menu

#98 Support of Contacts in CardDav REPORT

closed
3
2015-02-18
2014-09-05
Khaos
No

it would be really nice if you could change the CaldavConnection.reportItem method, so it supports contacts, too.
We love to use this tool, but really need this feature to proceed...

Discussion

  • Khaos

    Khaos - 2014-09-05

    P.S. You can find the right place at line: 774: // TODO: handle contacts ?

    This is what I came up with:

    ExchangeSession.Folder folder = session.getFolder(folderPath);
    if (folder.isContact()) {
    List<exchangesession.contact> contacts = session.getAllContacts(folderPath);
    appendContactsResponses(response, request, contacts);
    } else {
    if (request.vTodoOnly) {
    events = session.searchTasksOnly(request.getFolderPath());
    } else if (request.vEventOnly) {
    events = session.searchEventsOnly(request.getFolderPath(), request.timeRangeStart, request.timeRangeEnd);
    } else {
    events = session.searchEvents(request.getFolderPath(), request.timeRangeStart, request.timeRangeEnd);
    }
    appendEventsResponses(response, request, events);
    }</exchangesession.contact>

     
  • Khaos

    Khaos - 2014-10-10

    Not even a simple answer jet =/?!

     
  • Khaos

    Khaos - 2014-10-23

    Just found out that it wouldn't be bad if carriage return would be escaped in VProperty.appendMultilineEncodedValue, too.

    Find it at davmail.exchange.VProperty line 466:
    if (c == '\n') {
    buffer.append("\n");
    } else if (c == '\r') {
    buffer.append("\r");
    }

     
  • Mickael Guessant

    Looks good, first patch merged.

    Could you please provide more details for the second one, can you please provide a test case ?

     
  • Khaos

    Khaos - 2014-11-11

    Great! The secound one isn't important anymore. I got tasks descriptions of "n" without it, but this was an issue in our parser.

     
  • Mickael Guessant

    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB