Menu

#601 invalid davmail.server.certificate.hash format

v4.6.2
closed-fixed
nobody
None
5
2018-05-16
2015-08-20
olegvl
No

davmail.http.DavGatewayX509TrustManager class: checking acceptedCertificateHash

in method formatHash bytes format to string without leading zero (0x07 became 7 instead of 07)
so, for eample
davmail.server.certificate.hash=FA:09:26:E6:94:E6:17:17:E2:F7:C4:BC:9C:71:A8:5C:64:C3:06:9A
is not accepted, but
davmail.server.certificate.hash=FA:9:26:E6:94:E6:17:17:E2:F7:C4:BC:9C:71:A8:5C:64:C3:6:9A
is OK

Discussion

  • olegvl

    olegvl - 2015-08-20

    to resolve this issue, one can change
    builder.append(Integer.toHexString(buffer[i] & 0xFF));
    to
    builder.append(String.format("%02x", buffer[i] & 0xFF));

     
  • Mickael Guessant

    Patched merged, thanks for your feedback and sorry for the delay.

     
  • Mickael Guessant

    • status: open --> closed-fixed
     

Log in to post a comment.