#866 Remove wx28 code form wxSmith

[bluehazzard]

Hi, so we should slowly update the wxSmith code to use Bind instead of connect and other deprecated features...
The big question is how do we do this. I do not want introduce 100 #ifdegs to the code but a also do not want to break existing code...
One idea is to introduce a code comment with a flag that lets wxSmith recognize if the code is wx28 or wx3X compatible and let the code generation decide what to do...

related forum post

[Miguel Gimenez]

Connect() is not deprecated, Bind() is just a preferred option.

Connect() is not formally deprecated due to its existing widespread usage, it has no advantages compared to Bind()

I am mostly concerned by supression of wxNewId(): using wxID_ANY would force a call to GetId() after window creation in order to retrieve the assigned Id, or calling GetId() everywhere the Id is needed (p.e. Connect() or Bind())

IMHO the Connect() part don't need changes, and the wxNewId can be changed by a call to GetId() assigning the value to the same variable for compatibility with current code. This change is valid for all current wx versions. Example:

If the current code is

const long wxsBitmapIconEditorDlg::ID_RADIOBUTTON1 = wxNewId();
...
NoImage = new wxRadioButton(this, ID_RADIOBUTTON1, _("No image"), wxDefaultPosition, wxDefaultSize, 0, wxDefaultValidator, _T("ID_RADIOBUTTON1"));

change it to

NoImage = new wxRadioButton(this, wxID_ANY, _("No image"), wxDefaultPosition, wxDefaultSize, 0, wxDefaultValidator, _T("ID_RADIOBUTTON1"));
ID_RADIOBUTTON1 = NoImage->GetId();

defining ID_RADIOBUTTON1 as long in the class.