#1546 Fix crashes when building/running C::B on macOS-arm + clang++

[Federico Perini]

As suggested on the C::B forum, I’m filing a ticket with a patch that fixes two macOS issues:

1) Crash on startup with Apple Clang – null-pointer dereference during initialization. Clang++ seems stricter. The patch adds safe nullptr checks / early returns to avoid the crash.
2) Update bundled zlib to 1.3.1 – earlier version (1.2.8 I believe) that ships with C::B isn’t supported on modern macOS toolchains; it seems the only solution is to update to 1.3.1 (see i.e. https://github.com/google-ai-edge/mediapipe/issues/5943), I think this would be beneficial anyways.

Thank you,
Federico

[Federico Perini]

Sorry I uploaded an incomplete patch file - the correct one is attached.

Also - do let me know if we should split the zlib update from the codecompletion pointer crash update.

Thank you,
Federico

[Morten MacFly]

For 1) this is applied in [r13724], [r13725], [r13726] ad [r13727]
Thank you!
For 2) this was already fixed in an earlier commit.

Next time, please consider providing a single patch for each different item individually, this helps us applying patches easily.

[Federico Perini]

Thanks a lot @mortenmacfly (and previously @wh11204).
Yes I realize the patch was too big - sorry, it took quite a few changes to bootstrap C::B on macos.