#1435 Watch Window Context/Watch created invalid code

[Tiger Beard]

When the watch window shows a structure with subelements its possible to select a subelement and right click on it. Then a context menu pops up with the option "Watch". The single subelement appears as an own additional watch. It then creates the following watch line

*MyStruct.myVariable

This is the wrong syntax. The correct syntax should be

  (*MyStruct).myVariable           // this
   MyStruct->myVariable             // or this

The current workaround for this is to select "Rename" and change the line manually. Then it works fine.

Seen in 20.03 Linux but expected to be the same in other versions.
Can someone please confirm this.

[Miguel Gimenez]

This code

void GDBWatch::GetFullWatchString(wxString &full_watch) const
{
    cb::shared_ptr<const cbWatch> parent = GetParent();
    if (parent)
    {
        parent->GetFullWatchString(full_watch);
        full_watch += wxT(".") + m_symbol;
    }
    else
        full_watch = m_symbol;
}

generates that line. Changing it to this

void GDBWatch::GetFullWatchString(wxString &full_watch) const
{
    cb::shared_ptr<const cbWatch> parent = GetParent();
    if (parent)
    {
        parent->GetFullWatchString(full_watch);
        if (full_watch.StartsWith("*"))
            full_watch = "(" + full_watch + ")";

        full_watch += "." + m_symbol;
    }
    else
        full_watch = m_symbol;
}

should fix the issue.

[Miguel Gimenez]

Should be fixed in [r13404], thank you for reporting.