Menu
▾
▴
bodington-developers — Mailing list for Bodington developers
You can subscribe to this list here.
| 2005 |
Jan
|
Feb
|
Mar
|
Apr
(41) |
May
(353) |
Jun
(133) |
Jul
(534) |
Aug
(401) |
Sep
(219) |
Oct
(86) |
Nov
(144) |
Dec
(61) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2006 |
Jan
(200) |
Feb
(130) |
Mar
(345) |
Apr
(153) |
May
(247) |
Jun
(338) |
Jul
(222) |
Aug
(70) |
Sep
(39) |
Oct
(27) |
Nov
(76) |
Dec
(30) |
| 2007 |
Jan
(81) |
Feb
(44) |
Mar
(9) |
Apr
|
May
(3) |
Jun
(2) |
Jul
(34) |
Aug
(2) |
Sep
(1) |
Oct
|
Nov
|
Dec
(6) |
| 2008 |
Jan
|
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2009 |
Jan
(1) |
Feb
|
Mar
|
Apr
|
May
(7) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 11:34:33
|
yes, that's what I was afraid of, localising enums. The nested literals were there from day 1 so I just left them as is. > Shall I commit all my style_default/default changes back now!!?!! yes please Alistair On 14 Jul 2005, at 12:27, Alexis O'Connor wrote: > Alistair Young wrote: > >> Have you updated the templates I've already done in style_default/ >> default? >> Alistair >> > > Locally yes. I'm going to commit these back. > > Incidentally in style_default/default, applettop.html and > error403.html did not need to use nested <localise> elements with a > Facility call (as you'd hinted - #define, enumeration - a string > which is a programmatic command rather than one that would ever be > presented to an end-user). I've corrected that (it wouldn't have > worked as expected / intended in its current form anyway!). > > Shall I commit all my style_default/default changes back now!!?!! > > > Alexis > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in > dual > core and dual graphics technology at this free one hour event > hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/ > go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 11:27:24
|
Alistair Young wrote: > Have you updated the templates I've already done in style_default/ default? > > Alistair Locally yes. I'm going to commit these back. Incidentally in style_default/default, applettop.html and error403.html did not need to use nested <localise> elements with a Facility call (as you'd hinted - #define, enumeration - a string which is a programmatic command rather than one that would ever be presented to an end-user). I've corrected that (it wouldn't have worked as expected / intended in its current form anyway!). Shall I commit all my style_default/default changes back now!!?!! Alexis |
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 11:02:54
|
Have you updated the templates I've already done in style_default/ default? Alistair On 14 Jul 2005, at 11:56, Alexis O'Connor wrote: >> I will now proceed with style_default/default (just locally for >> starters!). If anyone really has strong objections to this >> mapping, speak now. Otherwise, I/we will proceed with this change. >> > > I'm ready to commit this back now. > > Any final objections !?! > > Alexis > > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in > dual > core and dual graphics technology at this free one hour event > hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/ > go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 10:56:07
|
> I will now proceed with style_default/default (just locally for > starters!). If anyone really has strong objections to this mapping, > speak now. Otherwise, I/we will proceed with this change. > I'm ready to commit this back now. Any final objections !?! Alexis |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 10:37:11
|
Alistair Young wrote: >> We'll probably also insert a default language setting lower down the >> object call graph for the sake of correctness. > > when will you do this? the templates won't compile from the commandline > until the task is updated. > > Alistair > We'll do this very soon. I'm currently updating the template to resource mapping in style_default/default! As a (very) short term solution, the template-compiler task within the compile-templates target is an implicit FileSet, so you can explictly [in | ex} clude the files you're interested in. Alexis |
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 10:31:12
|
I don't follow now. Is this not overkill? The problem was the ant task not setting the language. Changing the format of Facility calls is not a good idea so near a release, is it? All that needs done is to update the ant task to set the language from the build.properties. No other patches are required. You spotted an enhancement for dynamically localised Facility calls but it's not required for 2.6, unless you're confident it works in all templates. It would also mean we could bin the language propagation from Template to XmlTemplate. Can we just put the enhancement patches aside for now, update the ant task and see if template compilation works? If so, we can then proceed with any efficiency enhancements but I'm not happy about doing it so near the release. Alistair On 14 Jul 2005, at 11:18, Matthew Buckett wrote: > Alistair Young wrote: > >> nice one! that'll do. My only concern was it caused NPE with >> style_0/ recycler/main.html. >> > > Was that a NPE at compile or runtime? > > > That's nothing to do with the template compilation > >> problem. It's a nice enhancement for dynamic localisation though. >> Before you commit, can you make sure you're not seeing any NPE >> with non localised templates? >> > > Ok. I'll also remove your for localisation from getCharacterData(). > One thing to note is I change the syntax for localised facility > calls from: > > <call> > <target method="variable"><variable name="facility"/></target> > <parameters> > <variable name="request"/> > <variable name="writer"/> > <literal type="String"> > <localise id="page.title.text"/> > </literal> > </parameters> > </call> > > to: > > <call> > <target method="variable"><variable name="facility"/></target> > <parameters> > <variable name="request"/> > <variable name="writer"/> > <localise id="page.title.text"/> > </parameters> > </call> > > But my orginal patch include fixing the templates that were affected. > > -- > +--Matthew Buckett-----------------------------------------+ > | VLE Developer, Learning Technologies Group | > | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | > +------------Computing Services, University of Oxford------+ > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in > dual > core and dual graphics technology at this free one hour event > hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/ > go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Matthew B. <mat...@co...> - 2005-07-14 10:19:06
|
Alistair Young wrote:
> nice one! that'll do. My only concern was it caused NPE with style_0/
> recycler/main.html.
Was that a NPE at compile or runtime?
> That's nothing to do with the template compilation
> problem. It's a nice enhancement for dynamic localisation though.
> Before you commit, can you make sure you're not seeing any NPE with non
> localised templates?
Ok. I'll also remove your for localisation from getCharacterData(). One
thing to note is I change the syntax for localised facility calls from:
<call>
<target method="variable"><variable name="facility"/></target>
<parameters>
<variable name="request"/>
<variable name="writer"/>
<literal type="String">
<localise id="page.title.text"/>
</literal>
</parameters>
</call>
to:
<call>
<target method="variable"><variable name="facility"/></target>
<parameters>
<variable name="request"/>
<variable name="writer"/>
<localise id="page.title.text"/>
</parameters>
</call>
But my orginal patch include fixing the templates that were affected.
--
+--Matthew Buckett-----------------------------------------+
| VLE Developer, Learning Technologies Group |
| Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ |
+------------Computing Services, University of Oxford------+
|
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 10:18:33
|
> We'll probably also insert a default language setting lower down > the object call graph for the sake of correctness. when will you do this? the templates won't compile from the commandline until the task is updated. Alistair On 14 Jul 2005, at 11:12, Alexis O'Connor wrote: > Alistair Young wrote: > >> nice one! that'll do. My only concern was it caused NPE with >> style_0/ recycler/main.html. That's nothing to do with the >> template compilation problem. It's a nice enhancement for dynamic >> localisation though. Before you commit, can you make sure you're >> not seeing any NPE with non localised templates? >> Who's going to update the ant task to fix the template >> compilation problem? >> Alistair >> > > We're happy to do that (enable the language setting to be > overridden) from the ANT build. > > We'll probably also insert a default language setting lower down > the object call graph for the sake of correctness. > > > Alexis > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in > dual > core and dual graphics technology at this free one hour event > hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/ > go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 10:12:41
|
Alistair Young wrote: > nice one! that'll do. My only concern was it caused NPE with style_0/ > recycler/main.html. That's nothing to do with the template compilation > problem. It's a nice enhancement for dynamic localisation though. > Before you commit, can you make sure you're not seeing any NPE with non > localised templates? > > Who's going to update the ant task to fix the template compilation > problem? > > Alistair > We're happy to do that (enable the language setting to be overridden) from the ANT build. We'll probably also insert a default language setting lower down the object call graph for the sake of correctness. Alexis |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 10:07:48
|
Alistair Young wrote: > Now that localsation is sorted, I propose we leave the res dir as is, > i.e. an exact mirroring of the template dir, with template names as > directories, containig strings_en.properties, strings_gd.properties etc. > > I can't see anyone having multiple strings_en.properties open in an > editor as they would be for different templates. If multiple templates > share localised content then that content should be in res.generic, not > res.templates > > Alistair > I realize I should have replied to this yesterday, but I think Colin's suggested mapping *is* better and it would be better to get it right now. We at Oxford *are* happy to do this (and, yes, I did consult Matthew & Colin!). So we will do all the ones that are currently in style_default/default too. Just to re-cap, this mapping is: * the resource folder mirrors the template one (e.g. templates rooted at tomcatadd/webapps/bodington/templates, resources rooted at res/templates. * the name of the resource file is the name of the template, with the suffix _[lanaguage code], where the suffix for english would be _en. As an example tomcatadd/webapps/bodington/templates/style_default/messagingroom/useroptions.html, would have mapped to res/templates/style_default/messagingroom/useroptions/strings_en.properties. It now maps to res/templates/style_default/messagingroom/useroptions_en.properties. This example I have in fact committed back to CVS. I will now proceed with style_default/default (just locally for starters!). If anyone really has strong objections to this mapping, speak now. Otherwise, I/we will proceed with this change. Alexis |
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 10:05:51
|
nice one! that'll do. My only concern was it caused NPE with style_0/
recycler/main.html. That's nothing to do with the template
compilation problem. It's a nice enhancement for dynamic localisation
though. Before you commit, can you make sure you're not seeing any
NPE with non localised templates?
Who's going to update the ant task to fix the template compilation
problem?
Alistair
On 14 Jul 2005, at 10:57, Matthew Buckett wrote:
> Alistair Young wrote:
>
>> yep, no way round that. literals are passed to Facility methods so
>> I can't pass a Localiser method call instead of a string. It has
>> to be a java.lang.String that gets passed to Facility. It's a
>> fundamental i18n limitation of bod. You need to recompile the
>> template if you change a Facility literal string in a properties
>> file. For all other "normal" content, i.e. content that the
>> template class displays, you don't need to recompile if you
>> change the properties file.
>> Templates delegating content display to Facility causes the problem.
>>
>
> The reason I orginally wrote the patch is I couldn't see any
> support for dynamically changing and I didn't look inside
> getCharacterData().
>
> With my patch when you compile the call from default/applettop.html:
>
> <call>
> <target method="variable"><variable name="facility"/></target>
> <parameters>
> <variable name="request"/>
> <variable name="writer"/>
> <literal type="String">
> <localise id="page.title.text"/>
> </literal>
> </parameters>
> </call>
>
> you get this in the Java:
>
> facility .variable( request , writer , res.getString
> ("page.title.text") );
>
> otherwise you get the hardcoded string.
>
> facility .variable( request , writer , "title" );
>
> Is this better?
>
> --
> +--Matthew Buckett-----------------------------------------+
> | VLE Developer, Learning Technologies Group |
> | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ |
> +------------Computing Services, University of Oxford------+
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the 'Do More With Dual!' webinar
> happening
> July 14 at 8am PDT/11am EDT. We invite you to explore the latest in
> dual
> core and dual graphics technology at this free one hour event
> hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/
> go/dualwebinar
> _______________________________________________
> Bodington-developers mailing list
> Bod...@li...
> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>
|
|
From: Matthew B. <mat...@co...> - 2005-07-14 09:57:10
|
Alistair Young wrote:
> yep, no way round that. literals are passed to Facility methods so I
> can't pass a Localiser method call instead of a string. It has to be a
> java.lang.String that gets passed to Facility. It's a fundamental i18n
> limitation of bod. You need to recompile the template if you change a
> Facility literal string in a properties file. For all other "normal"
> content, i.e. content that the template class displays, you don't need
> to recompile if you change the properties file.
> Templates delegating content display to Facility causes the problem.
The reason I orginally wrote the patch is I couldn't see any support for
dynamically changing and I didn't look inside getCharacterData().
With my patch when you compile the call from default/applettop.html:
<call>
<target method="variable"><variable name="facility"/></target>
<parameters>
<variable name="request"/>
<variable name="writer"/>
<literal type="String">
<localise id="page.title.text"/>
</literal>
</parameters>
</call>
you get this in the Java:
facility .variable( request , writer , res.getString("page.title.text") );
otherwise you get the hardcoded string.
facility .variable( request , writer , "title" );
Is this better?
--
+--Matthew Buckett-----------------------------------------+
| VLE Developer, Learning Technologies Group |
| Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ |
+------------Computing Services, University of Oxford------+
|
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 09:35:43
|
yep, no way round that. literals are passed to Facility methods so I can't pass a Localiser method call instead of a string. It has to be a java.lang.String that gets passed to Facility. It's a fundamental i18n limitation of bod. You need to recompile the template if you change a Facility literal string in a properties file. For all other "normal" content, i.e. content that the template class displays, you don't need to recompile if you change the properties file. Templates delegating content display to Facility causes the problem. Alistair On 14 Jul 2005, at 10:28, Matthew Buckett wrote: > Alistair Young wrote: > >>> So you hardcode the resource >>> properties in the .java file that the compiler produces? >>> >> yes. There was a debate ages ago whether to substitute a <localise> >> element with the actual text or write code into the template class to >> dynamically call the Localiser. We choose the dynamic method as >> that lets >> you update the properties file without recompiling the template. >> > > But doesn't XmlTemplate.getCharacterData() insert an hard coded > string into the Java file? > parent.appendChild(parent.getOwnerDocument().createTextNode > (res.getString(idAttr.getNodeValue()))); > > -- > +--Matthew Buckett-----------------------------------------+ > | VLE Developer, Learning Technologies Group | > | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | > +------------Computing Services, University of Oxford------+ > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in > dual > core and dual graphics technology at this free one hour event > hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/ > go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Matthew B. <mat...@co...> - 2005-07-14 09:28:33
|
Alistair Young wrote: >>So you hardcode the resource >>properties in the .java file that the compiler produces? > > yes. There was a debate ages ago whether to substitute a <localise> > element with the actual text or write code into the template class to > dynamically call the Localiser. We choose the dynamic method as that lets > you update the properties file without recompiling the template. But doesn't XmlTemplate.getCharacterData() insert an hard coded string into the Java file? parent.appendChild(parent.getOwnerDocument().createTextNode(res.getString(idAttr.getNodeValue()))); -- +--Matthew Buckett-----------------------------------------+ | VLE Developer, Learning Technologies Group | | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | +------------Computing Services, University of Oxford------+ |
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 09:27:27
|
Now that localsation is sorted, I propose we leave the res dir as is, i.e. an exact mirroring of the template dir, with template names as directories, containig strings_en.properties, strings_gd.properties etc. I can't see anyone having multiple strings_en.properties open in an editor as they would be for different templates. If multiple templates share localised content then that content should be in res.generic, not res.templates Alistair |
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 09:22:14
|
I've found the probem.
TemplateBuilderTask.iterateTemplates() doesn't set the language of =20
the templates. That's where the NPE is coming from.
In BuildingServlet.doProcessing(), Template objects are used and =20
XmlTemplate is obtained indirectly at runtime but the ant task uses =20
XmlTemplate directly, thus bypassing the language initialisation.
Adding this line to TemplateBuilderTask.iterateTemplates():
template.setLanguage("en");
fixes the problem
At runtime this is called via Template.setProcessorLanguage()
"en" is a hard code though. Alexis, what's your opinion on adding a =20
language option to build.properties and setting it to "en" by =20
default. If you want to compile bod in another language you change =20
the language setting in build.properties?
XmlTemplate doesn't need patched, just =20
TemplateBuilderTask.iterateTemplates()
Alistair
On 13 Jul 2005, at 21:52, Alistair Young wrote:
>> [template-compiler] Error(s) found with
>> "style_default/default/applettop.html":
>> [template-compiler] Technical error trying to insert iteractive item.
>>
> got that without the patch. With the patch I couldn't get that far =20
> as it
> barfed on style_0/recycler/main.html instead. Without the patch, =20
> removing
> the localised literal fixed the problem. However, it shouldn't have =20=
> been
> localised in the first place. This is what I meant by #define. I =20
> should
> have said enumeration. The template is calling Facility and passing =20=
> what
> is essentially an enum to get the Facility method to do something.
>
>
>>> I'm getting a NullPointerException for style_0/recycler/main.html =20=
>>> when
>>>
>> Is this with my patch applied?
>>
> yes
>
>
>> I don't see the NPE.
>>
> sorry, I sort of hacked my way into it - XmlTemplate.compileCall() =20
> catches
> a RuntimeException, which turns out to be the NPE
>
>
>> So you hardcode the resource
>> properties in the .java file that the compiler produces?
>>
> yes. There was a debate ages ago whether to substitute a <localise>
> element with the actual text or write code into the template class to
> dynamically call the Localiser. We choose the dynamic method as =20
> that lets
> you update the properties file without recompiling the template.
>
>
>> Although if I set the build not to compile templates I was getting =20=
>> the
>> same error when Bodington was deployed localy.
>>
> interesting. Ant has deployed it ok here. It's localised as we had
> problems with the Localiser and whitespace, which we've fixed. The
> literals are being localised ok here. Ant doesn't have your patch =20
> though.
>
>
>> Are you on Jabber or IRC?
>>
> nope! never got that far! playing with the cat just now :)
>
> Maybe I'll have more ideas by the morning.
>
> Thanks for looking into it.
>
> Alistair
>
>
> --=20
> Alistair Young
> Senior Software Engineer
> UHI@Sabhal M=F2r Ostaig
> Isle of Skye
> Scotland
>
>
>> Alistair Young wrote:
>>
>>> Thanks Mathew,
>>>
>>> I copied this into my tree with no effect. I'm not convinced the =20
>>> problem
>>> lies here. Template compilation used to work. I think it was =20
>>> using the
>>> bat
>>> file before. It's using an ant task now.
>>>
>>
>> Ok. But with an up to date checkout of bodington HEAD (without my =20
>> patch)
>> do you see this error when attempting to compile the templates =20
>> through
>> the ant task?
>>
>> [template-compiler] Compiling 459 templates to
>> /home/buckett/workspace/bodington/build/bodington/WEB-INF/=20
>> template_classes
>> [template-compiler] Error(s) found with
>> "style_default/default/applettop.html":
>> [template-compiler] Technical error trying to insert iteractive item.
>>
>>
>>> I'm getting a NullPointerException for style_0/recycler/main.html =20=
>>> when
>>> it
>>> XmlTemplate tries to compile:
>>> <literal type=3D"String"></literal>
>>> There isn't any localisation in this template.
>>>
>>
>> Is this with my patch applied?
>>
>>
>>> The lack of a string causes the exception. Which leads me to =20
>>> think that:
>>> <literal type=3D"String"><localise id=3D"enter.website" /></literal>
>>> in style_default/default/login_anon.html
>>> has the same problem - I verified it has a NullPointerException too.
>>>
>>
>> I don't see the NPE.
>>
>>
>>> XmlTemplate.getCharacterData() replaces the <localise> element in a
>>> <literal> element with the text that the Localiser returns.
>>>
>>
>> Ok thanks, I hadn't spotted that, thanks. So you hardcode the =20
>> resource
>> properties in the .java file that the compiler produces?
>>
>>
>>> This seems to point to the Localiser not being either available =20
>>> or not
>>> finding the properties file when XmlTemplate is invoked from the ant
>>> task.
>>>
>>
>> Although if I set the build not to compile templates I was getting =20=
>> the
>> same error when Bodington was deployed localy.
>>
>>
>>> That wouldn't explain why <literal type=3D"String"></literal> causes =
a
>>> NullPointerException now. It didn't before.
>>>
>>
>> Indeed.
>>
>>
>>> any ideas?
>>>
>>
>> I'm looking..... Are you on Jabber or IRC?
>>
>> --
>> +--Matthew Buckett-----------------------------------------+
>> | VLE Developer, Learning Technologies Group |
>> | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ |
>> +------------Computing Services, University of Oxford------+
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by the 'Do More With Dual!' webinar
>> happening
>> July 14 at 8am PDT/11am EDT. We invite you to explore the latest =20
>> in dual
>> core and dual graphics technology at this free one hour event =20
>> hosted by
>> HP,
>> AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
>> _______________________________________________
>> Bodington-developers mailing list
>> Bod...@li...
>> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>>
>>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the 'Do More With Dual!' webinar =20
> happening
> July 14 at 8am PDT/11am EDT. We invite you to explore the latest in =20=
> dual
> core and dual graphics technology at this free one hour event =20
> hosted by HP,
> AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
> _______________________________________________
> Bodington-developers mailing list
> Bod...@li...
> https://lists.sourceforge.net/lists/listinfo/bodington-developers
>
|
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 08:54:25
|
Alistair Young wrote: > interesting, didn't realise that. Not ideal but if it works... Just > hope that the translator puts the slashes back in. > > Alistair I am an adherent of the '80 characters to a line' line of thumb. Imagine, the state of apoplexy I'd be in if what I described wasn't possible ;-) ... Alexis |
|
From: Alistair Y. <ali...@sm...> - 2005-07-14 08:44:33
|
interesting, didn't realise that. Not ideal but if it works... Just hope that the translator puts the slashes back in. Alistair On 14 Jul 2005, at 09:20, Alexis O'Connor wrote: > Alistair Young wrote: > >> I didn't include the markup in the localised text. I just split the >> paragraphs into separate entries. >> > > No, quite correct. See my reply to Brian. > > >> You also have to make sure all the text is on one line in the >> properties >> entry. >> > > Ahem, if this was true some of the templates I've already localised > would be highly unwieldy (I've had templates with whole > paragraphs!). What you do is escape the line-return with a > backslash, i.e. have the \ character as the last non-whitespace > character on a line. > > > Alexis > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in > dual > core and dual graphics technology at this free one hour event > hosted by HP, AMD, and NVIDIA. To register visit http://www.hp.com/ > go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 08:20:52
|
Alistair Young wrote: > I didn't include the markup in the localised text. I just split the > paragraphs into separate entries. No, quite correct. See my reply to Brian. > > You also have to make sure all the text is on one line in the properties > entry. Ahem, if this was true some of the templates I've already localised would be highly unwieldy (I've had templates with whole paragraphs!). What you do is escape the line-return with a backslash, i.e. have the \ character as the last non-whitespace character on a line. Alexis |
|
From: Alexis O'C. <ale...@co...> - 2005-07-14 08:17:42
|
Brian Peter Clark wrote: > Do you want a standard format for <h2></h2> etc? > > For example: > > h2.1 > h2.2 > > headingtwo.1 > headingtwo.2 > > heading_two.1 > heading_two.2 > > page.h2.1 > page.h2.2 > > page.headertwo.1 > > para.h2.1 > > Regards, > > Brian > > You shouldn't be adopting a markup-oriented approach, but a semantic / content oriented one. Seperation of presentation from content is a basic principle. If the template currently says: <h2>Messaging Room</h2> You should put something like ... messaging.room=Messaging Room ... in the (English) properties file, and leave behind ... <h2><localise id="messaging.room" /></h2> ... in the template. Let the template handle the markup / presentation concerns. Alexis |
|
From: Alistair Y. <ali...@sm...> - 2005-07-13 20:52:15
|
> [template-compiler] Error(s) found with > "style_default/default/applettop.html": > [template-compiler] Technical error trying to insert iteractive item. got that without the patch. With the patch I couldn't get that far as it barfed on style_0/recycler/main.html instead. Without the patch, removing the localised literal fixed the problem. However, it shouldn't have been localised in the first place. This is what I meant by #define. I should have said enumeration. The template is calling Facility and passing what is essentially an enum to get the Facility method to do something. >> I'm getting a NullPointerException for style_0/recycler/main.html when > Is this with my patch applied? yes > I don't see the NPE. sorry, I sort of hacked my way into it - XmlTemplate.compileCall() catche= s a RuntimeException, which turns out to be the NPE > So you hardcode the resource > properties in the .java file that the compiler produces? yes. There was a debate ages ago whether to substitute a <localise> element with the actual text or write code into the template class to dynamically call the Localiser. We choose the dynamic method as that lets you update the properties file without recompiling the template. > Although if I set the build not to compile templates I was getting the > same error when Bodington was deployed localy. interesting. Ant has deployed it ok here. It's localised as we had problems with the Localiser and whitespace, which we've fixed. The literals are being localised ok here. Ant doesn't have your patch though. > Are you on Jabber or IRC? nope! never got that far! playing with the cat just now :) Maybe I'll have more ideas by the morning. Thanks for looking into it. Alistair --=20 Alistair Young Senior Software Engineer UHI@Sabhal M=F2r Ostaig Isle of Skye Scotland > Alistair Young wrote: >> Thanks Mathew, >> >> I copied this into my tree with no effect. I'm not convinced the probl= em >> lies here. Template compilation used to work. I think it was using the >> bat >> file before. It's using an ant task now. > > Ok. But with an up to date checkout of bodington HEAD (without my patch= ) > do you see this error when attempting to compile the templates through > the ant task? > > [template-compiler] Compiling 459 templates to > /home/buckett/workspace/bodington/build/bodington/WEB-INF/template_clas= ses > [template-compiler] Error(s) found with > "style_default/default/applettop.html": > [template-compiler] Technical error trying to insert iteractive item. > >> I'm getting a NullPointerException for style_0/recycler/main.html when >> it >> XmlTemplate tries to compile: >> <literal type=3D"String"></literal> >> There isn't any localisation in this template. > > Is this with my patch applied? > >> The lack of a string causes the exception. Which leads me to think tha= t: >> <literal type=3D"String"><localise id=3D"enter.website" /></literal> >> in style_default/default/login_anon.html >> has the same problem - I verified it has a NullPointerException too. > > I don't see the NPE. > >> XmlTemplate.getCharacterData() replaces the <localise> element in a >> <literal> element with the text that the Localiser returns. > > Ok thanks, I hadn't spotted that, thanks. So you hardcode the resource > properties in the .java file that the compiler produces? > >> This seems to point to the Localiser not being either available or not >> finding the properties file when XmlTemplate is invoked from the ant >> task. > > Although if I set the build not to compile templates I was getting the > same error when Bodington was deployed localy. > >> That wouldn't explain why <literal type=3D"String"></literal> causes a >> NullPointerException now. It didn't before. > > Indeed. > >> any ideas? > > I'm looking..... Are you on Jabber or IRC? > > -- > +--Matthew Buckett-----------------------------------------+ > | VLE Developer, Learning Technologies Group | > | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | > +------------Computing Services, University of Oxford------+ > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dua= l > core and dual graphics technology at this free one hour event hosted by > HP, > AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Matthew B. <mat...@co...> - 2005-07-13 20:26:56
|
Alistair Young wrote: > Thanks Mathew, > > I copied this into my tree with no effect. I'm not convinced the problem > lies here. Template compilation used to work. I think it was using the bat > file before. It's using an ant task now. Ok. But with an up to date checkout of bodington HEAD (without my patch) do you see this error when attempting to compile the templates through the ant task? [template-compiler] Compiling 459 templates to /home/buckett/workspace/bodington/build/bodington/WEB-INF/template_classes [template-compiler] Error(s) found with "style_default/default/applettop.html": [template-compiler] Technical error trying to insert iteractive item. > I'm getting a NullPointerException for style_0/recycler/main.html when it > XmlTemplate tries to compile: > <literal type="String"></literal> > There isn't any localisation in this template. Is this with my patch applied? > The lack of a string causes the exception. Which leads me to think that: > <literal type="String"><localise id="enter.website" /></literal> > in style_default/default/login_anon.html > has the same problem - I verified it has a NullPointerException too. I don't see the NPE. > XmlTemplate.getCharacterData() replaces the <localise> element in a > <literal> element with the text that the Localiser returns. Ok thanks, I hadn't spotted that, thanks. So you hardcode the resource properties in the .java file that the compiler produces? > This seems to point to the Localiser not being either available or not > finding the properties file when XmlTemplate is invoked from the ant task. Although if I set the build not to compile templates I was getting the same error when Bodington was deployed localy. > That wouldn't explain why <literal type="String"></literal> causes a > NullPointerException now. It didn't before. Indeed. > any ideas? I'm looking..... Are you on Jabber or IRC? -- +--Matthew Buckett-----------------------------------------+ | VLE Developer, Learning Technologies Group | | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | +------------Computing Services, University of Oxford------+ |
|
From: Alistair Y. <ali...@sm...> - 2005-07-13 19:30:12
|
Thanks Mathew, I copied this into my tree with no effect. I'm not convinced the problem lies here. Template compilation used to work. I think it was using the ba= t file before. It's using an ant task now. I'm getting a NullPointerException for style_0/recycler/main.html when it XmlTemplate tries to compile: <literal type=3D"String"></literal> There isn't any localisation in this template. The lack of a string causes the exception. Which leads me to think that: <literal type=3D"String"><localise id=3D"enter.website" /></literal> in style_default/default/login_anon.html has the same problem - I verified it has a NullPointerException too. XmlTemplate.getCharacterData() replaces the <localise> element in a <literal> element with the text that the Localiser returns. This seems to point to the Localiser not being either available or not finding the properties file when XmlTemplate is invoked from the ant task= . That wouldn't explain why <literal type=3D"String"></literal> causes a NullPointerException now. It didn't before. any ideas? Alistair --=20 Alistair Young Senior Software Engineer UHI@Sabhal M=F2r Ostaig Isle of Skye Scotland > Alistair Young wrote: >> I'd rather you sent the source file - patches don't work too well here > > Attached. > > -- > +--Matthew Buckett-----------------------------------------+ > | VLE Developer, Learning Technologies Group | > | Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/ | > +------------Computing Services, University of Oxford------+ > |
|
From: Alistair Y. <ali...@sm...> - 2005-07-13 18:47:57
|
I didn't include the markup in the localised text. I just split the paragraphs into separate entries. You also have to make sure all the text is on one line in the properties entry. Alistair --=20 Alistair Young Senior Software Engineer UHI@Sabhal M=F2r Ostaig Isle of Skye Scotland > Do you want a standard format for <h2></h2> etc? > > For example: > > h2.1 > h2.2 > > headingtwo.1 > headingtwo.2 > > heading_two.1 > heading_two.2 > > page.h2.1 > page.h2.2 > > page.headertwo.1 > > para.h2.1 > > Regards, > > Brian > >> http://www.weblogs.uhi.ac.uk/sm00ay/?p=3D90 >> >> I mirrored the template structure in the res dir: >> >> res/templates/default/login_step2/strings_en.properties >> etc. >> >> I think in the first instance we can forget about picking out duplicat= es >> as we don't have much time. The first release will tell us what needs >> doing better. Don't forget this is nothing - 60 out of about 500, so >> let's >> get it right over a couple of iterations before we do the whole lot fo= r >> 2.8 >> >> Let's aim to finish these for the end of this week. It's about 10-15mi= ns >> per template but it's exceeeeeeedingly boring! >> >> Any queries drop me a line, if I'm still awake/sane ;) >> >> Leeds: >> >> building/main.html >> floor/main.html >> mediadocument/menu.html >> password/x509check.html >> room/main.html >> site/main.html >> suite/main.html >> directory/consentconfirm.html >> directory/consentform.html >> >> UHI: >> default/applettop.html * >> default/error403.html * >> default/index.html * >> default/left.html * >> default/login.html * >> default/login_anon.html * >> default/login_basic.html * >> default/login_logout_confirm.html * >> default/login_step1.html * >> default/login_step1big.html * >> default/login_step2.html * >> default/login_step3.html >> default/login_step4.html >> default/logout.html >> default/logout_confirm.html >> default/menu.html >> default/properties.html >> default/styletest.html >> default/top.html >> default/useroption1.html >> default/useroptions.html >> >> UHI: >> mcq/abouttool.html >> mcq/mcqdebrief.html >> mcq/mcqdebrieftech.html >> mcq/mcqhelp.html >> mcq/mcqhelp1.html >> mcq/mcqhelp2.html >> mcq/mcqhelp3.html >> mcq/mcqhelp4.html >> mcq/mcqhelp5.html >> mcq/mcqhelp6.html >> mcq/mcqtutorial.html >> >> Oxford: >> messagingroom/flatcontents1.html >> messagingroom/flatcontents2.html >> messagingroom/flatcontents3.html >> messagingroom/index.html >> messagingroom/messagetext.html >> messagingroom/newcontents.html >> messagingroom/newparticipants1.html >> messagingroom/newparticipants2.html >> messagingroom/newparticipants3.html >> messagingroom/newparticipants4.html >> messagingroom/newparticipants5.html >> messagingroom/newparticipants6.html >> messagingroom/newparticipantsm.html >> messagingroom/newreaders.html >> messagingroom/newreaders2.html >> messagingroom/newreaders3.html >> messagingroom/useroption2.html >> messagingroom/useroptions.html >> messagingroom/useroptiontest.html >> >> Alistair >> >> >> >> -- >> Alistair Young >> Senior Software Engineer >> UHI@Sabhal M=F2r Ostaig >> Isle of Skye >> Scotland >> >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by the 'Do More With Dual!' webinar >> happening >> July 14 at 8am PDT/11am EDT. We invite you to explore the latest in du= al >> core and dual graphics technology at this free one hour event hosted b= y >> HP, >> AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar >> _______________________________________________ >> Bodington-developers mailing list >> Bod...@li... >> https://lists.sourceforge.net/lists/listinfo/bodington-developers >> > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar > happening > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dua= l > core and dual graphics technology at this free one hour event hosted by > HP, > AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
|
From: Brian P. C. <bm...@bm...> - 2005-07-13 18:42:11
|
Do you want a standard format for <h2></h2> etc? For example: h2.1 h2.2 headingtwo.1 headingtwo.2 heading_two.1 heading_two.2 page.h2.1 page.h2.2 page.headertwo.1 para.h2.1 Regards, Brian > http://www.weblogs.uhi.ac.uk/sm00ay/?p=3D90 > > I mirrored the template structure in the res dir: > > res/templates/default/login_step2/strings_en.properties > etc. > > I think in the first instance we can forget about picking out duplicates > as we don't have much time. The first release will tell us what needs > doing better. Don't forget this is nothing - 60 out of about 500, so let= 's > get it right over a couple of iterations before we do the whole lot for > 2.8 > > Let's aim to finish these for the end of this week. It's about 10-15mins > per template but it's exceeeeeeedingly boring! > > Any queries drop me a line, if I'm still awake/sane ;) > > Leeds: > > building/main.html > floor/main.html > mediadocument/menu.html > password/x509check.html > room/main.html > site/main.html > suite/main.html > directory/consentconfirm.html > directory/consentform.html > > UHI: > default/applettop.html * > default/error403.html * > default/index.html * > default/left.html * > default/login.html * > default/login_anon.html * > default/login_basic.html * > default/login_logout_confirm.html * > default/login_step1.html * > default/login_step1big.html * > default/login_step2.html * > default/login_step3.html > default/login_step4.html > default/logout.html > default/logout_confirm.html > default/menu.html > default/properties.html > default/styletest.html > default/top.html > default/useroption1.html > default/useroptions.html > > UHI: > mcq/abouttool.html > mcq/mcqdebrief.html > mcq/mcqdebrieftech.html > mcq/mcqhelp.html > mcq/mcqhelp1.html > mcq/mcqhelp2.html > mcq/mcqhelp3.html > mcq/mcqhelp4.html > mcq/mcqhelp5.html > mcq/mcqhelp6.html > mcq/mcqtutorial.html > > Oxford: > messagingroom/flatcontents1.html > messagingroom/flatcontents2.html > messagingroom/flatcontents3.html > messagingroom/index.html > messagingroom/messagetext.html > messagingroom/newcontents.html > messagingroom/newparticipants1.html > messagingroom/newparticipants2.html > messagingroom/newparticipants3.html > messagingroom/newparticipants4.html > messagingroom/newparticipants5.html > messagingroom/newparticipants6.html > messagingroom/newparticipantsm.html > messagingroom/newreaders.html > messagingroom/newreaders2.html > messagingroom/newreaders3.html > messagingroom/useroption2.html > messagingroom/useroptions.html > messagingroom/useroptiontest.html > > Alistair > > > > -- > Alistair Young > Senior Software Engineer > UHI@Sabhal M=F2r Ostaig > Isle of Skye > Scotland > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by the 'Do More With Dual!' webinar happe= ning > July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual > core and dual graphics technology at this free one hour event hosted by = HP, > AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar > _______________________________________________ > Bodington-developers mailing list > Bod...@li... > https://lists.sourceforge.net/lists/listinfo/bodington-developers > |
19 messages has been excluded from this view by a project administrator.
