Re: [Audacity-devel] Debug build crash re-check-in

[Shane M. <smu...@um...>]

I've (re)committed the toolbar code, thanks to Dominic's perceptive
bug-finding.  I've compiled in under both windows and linux with both
the debug and non-debug wxwindows library, and it works *fairly well*.
The funny part is that when I originally defined toolbar, I had it as a
dynamic class, but took it out because it didn't appear to do anything.

I have seen a several bugs, which I will enumerate here.  I'll be
tackling them in the next few weeks. Please let me know if you see
anything else, or have ideas about these:

 1. There may be something wrong in the dynamic array code that handles
    adding and deleting toolbars.  The bug that Brian noted (crash on
    exit) may be a consequence of this, but I've also seen some assert
    failures I have seen in the windows debug build at other times.

 2. The Edit toolbar works by executing functions associated with
    current menu items.  I think this is a good policy in general,
    especially because some users will undoubtedly have accessibility
    problems and will not be able to use a mouse. But, some of
    zoom menu items that I hook on to don't work perfectly. (zoom in 
    should stay centered on the center of the window, and zoom-fit is
    misaligned.)

 3. I added a "Trim" function to the menu (and the edit toolbar). This
    could also be called "crop", as it is identical to graphical
    "crop"--it removes all of the file outside of the selection.  I did
    this quickly, and have a suspicion that it leaks all of the memory
    it "trims", because it doesn't give the memory to the clipboard.  
 
Fit and Finish:

 4. Under windows, when I drag a toolbar off the app, the bitmap that is
    produced "bleeds through" the previous bitmap--I see a ghost of the 
    last toolbar dragged.  This may depend on the color scheme
    and/or color depth rather than the platform, and may be present but
    undetectable in the "Palette" version as well. 

 5. The Windows (and presumably the mac) builds have several alignment 
    issues where buttons are a pixel too high or too low, or a line is a
    little off.  

 6. Some of the button images are a little corny and unclear--these are
    probably the one's I created. The nice ones were obtained from Abe
    Milde, who is creating a more consistent and attractive set, so
    stay tuned.


> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
-- 
====================================================
  Shane Mueller                       East Hall 4424
  (734) 647-3698            Cognition and Perception
  smu...@um...      The University of Michigan
       http://www-personal.umich.edu/~smueller
====================================================