Re: [Audacity-devel] [DUMP+FREEBSD] Closing audacity 2.3.3_1 leads to core dump

[Leland L. <ll...@ho...>]

Dude!!!  You are awesome!  I don't know about correctness, but the patch fixes crash for me on Windows and Linux!

I'll leave it to Paul to verify and commit though.  I've BCC'd him in case he's not following the thread.

Thanks!

> -----Original Message-----
> From: Hans Petter Selasky <hp...@se...>
> Sent: Wednesday, February 12, 2020 9:39 AM
> To: aud...@li...; Leland Lucius
> <ll...@ho...>; Paul Licameli <pau...@au...>
> Subject: Re: [Audacity-devel] [DUMP+FREEBSD] Closing audacity 2.3.3_1 leads
> to core dump
> 
> Hi Paul,
> 
> There appears to be a regression in:
> 
> commit a3b434be1cd42ff7c99821de4ea52c0945cb0baa
> Author: Paul Licameli <pau...@au...>
> Date:   Thu Jul 4 09:39:44 2019 -0400
> 
>      Move the scrub mouse event handler into ScrubUI...
> 
>      ... Making Scrubbing independent of AdornedRulerPanel.cpp
> 
> See attached patch. Not sure if it is correct. Needs review.
> 
> --HPS