Re: [Audacity-quality] Export Multiple progress dialog - recommended minor change
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
Menu
▾
▴
Re: [Audacity-quality] Export Multiple progress dialog - recommended minor change
|
From: Peter S. <pet...@gm...> - 2017-11-17 11:06:31
|
On Fri, Nov 17, 2017 at 9:19 AM, Steve the Fiddle <ste...@gm...> wrote: > On 17 November 2017 at 08:05, Peter Sampson > <pet...@gm...> wrote: > > > > > > On Thu, Nov 16, 2017 at 6:22 PM, Steve the Fiddle < > ste...@gm...> > > wrote: > >> > >> On 16 November 2017 at 18:09, Peter Sampson > >> <pet...@gm...> wrote: > >> > > >> > > >> > On Thu, Nov 16, 2017 at 6:00 PM, Steve the Fiddle > >> > <ste...@gm...> > >> > wrote: > >> >> > >> >> On 16 November 2017 at 17:32, Peter Sampson > >> >> <pet...@gm...> wrote: > >> >> > > >> >> > > >> >> > On Thu, Nov 16, 2017 at 5:15 PM, James Crook <cr...@in...> > >> >> > wrote: > >> >> >> > >> >> >> On 11/16/2017 4:28 PM, Steve the Fiddle wrote: > >> >> >>> > >> >> >>> On 16 November 2017 at 15:53, Peter Sampson > >> >> >>> <pet...@gm...> wrote: > >> >> >>>> > >> >> >>>> > >> >> >>>> On Thu, Nov 16, 2017 at 3:47 PM, Steve the Fiddle > >> >> >>>> <ste...@gm...> > >> >> >>>> wrote: > >> >> >>>>> > >> >> >>>>> On 16 November 2017 at 15:12, Peter Sampson > >> >> >>>>> <pet...@gm...> wrote: > >> >> >>>>>> > >> >> >>>>>> This is something that has bothered me for then entire ten > years > >> >> >>>>>> I > >> >> >>>>>> have > >> >> >>>>>> worked with Audacity - and I have made a *lot* of multiple > >> >> >>>>>> exports > >> >> >>>>>> in > >> >> >>>>>> that > >> >> >>>>>> time. > >> >> >>>>>> > >> >> >>>>>> The progress dilaog(s) in Export Multiple tell the user > >> >> >>>>>> "Exporting > >> >> >>>>>> the > >> >> >>>>>> entire project ..." > >> >> >>>>>> > >> >> >>>>>> This message is patently misleading and in many cases untrue > so > >> >> >>>>>> today > >> >> >>>>>> I > >> >> >>>>>> added the following to Wiki>Wording: > >> >> >>>>>> > >> >> >>>>>> > >> >> >>>>>> > >> >> >>>>>> > >> >> >>>>>> http://wiki.audacityteam.org/wiki/Wording#Error_messages. > 2C_warnings_and_advice_dialogs > >> >> >>>>>> > >> >> >>>>>> Export Multiple > >> >> >>>>>> > >> >> >>>>>> Currently the Export Multiple progress dialog identified in > the > >> >> >>>>>> dialog > >> >> >>>>>> header the name of the audio file being exported. > >> >> >>>>>> > >> >> >>>>>> In the body of the dialog it states: Exporting the entire > >> >> >>>>>> project > >> >> >>>>>> as > >> >> >>>>>> <audio > >> >> >>>>>> file format> > >> >> >>>>>> > >> >> >>>>>> This would be much better changed to: Exporting the audio file > >> >> >>>>>> as > >> >> >>>>>> <audio > >> >> >>>>>> file format> > >> >> >>>>> > >> >> >>>>> It's a bit peculiar how this is done, in that the message comes > >> >> >>>>> from > >> >> >>>>> the exporter, so each exporter has it's own messages. > >> >> >>>>> For each exporter there is a choice of two messages, depending > on > >> >> >>>>> whether the "selectionOnly" flag is set or not. > >> >> >>>>> > >> >> >>>>> Command line exporter: > >> >> >>>>> _("Exporting the selected audio using command-line encoder") : > >> >> >>>>> _("Exporting the entire project using command-line encoder")); > >> >> >>>>> > >> >> >>>>> FFmpeg exporter: > >> >> >>>>> wxString::Format(_("Exporting selected audio as %s"), > >> >> >>>>> ExportFFmpegOptions::fmts[mSubFormat].Description()) : > >> >> >>>>> wxString::Format(_("Exporting entire file as %s"), > >> >> >>>>> ExportFFmpegOptions::fmts[mSubFormat].Description())); > >> >> >>>>> > >> >> >>>>> FLAC exporter: > >> >> >>>>> _("Exporting the selected audio as FLAC") : > >> >> >>>>> _("Exporting the entire project as FLAC")); > >> >> >>>>> > >> >> >>>>> MP2 Exporter: > >> >> >>>>> wxString::Format(_("Exporting selected audio at %ld kbps"), > >> >> >>>>> bitrate) > >> >> >>>>> : > >> >> >>>>> wxString::Format(_("Exporting entire file at %ld kbps"), > >> >> >>>>> bitrate)); > >> >> >>>>> > >> >> >>>>> MP3 Exporter: > >> >> >>>>> if (rmode == MODE_SET) { > >> >> >>>>> title.Printf(selectionOnly ? > >> >> >>>>> _("Exporting selected audio with %s preset") : > >> >> >>>>> _("Exporting entire file with %s preset"), > >> >> >>>>> FindName(setRates, WXSIZEOF(setRates), brate).c_str()); > >> >> >>>>> } > >> >> >>>>> else if (rmode == MODE_VBR) { > >> >> >>>>> title.Printf(selectionOnly ? > >> >> >>>>> _("Exporting selected audio with VBR quality %s") : > >> >> >>>>> _("Exporting entire file with VBR quality %s"), > >> >> >>>>> FindName(varRates, WXSIZEOF(varRates), brate).c_str()); > >> >> >>>>> } > >> >> >>>>> else { > >> >> >>>>> title.Printf(selectionOnly ? > >> >> >>>>> _("Exporting selected audio at %d Kbps") : > >> >> >>>>> _("Exporting entire file at %d Kbps"), > >> >> >>>>> brate); > >> >> >>>>> } > >> >> >>>>> > >> >> >>>>> OGG exporter: > >> >> >>>>> _("Exporting the selected audio as Ogg Vorbis") : > >> >> >>>>> _("Exporting the entire project as Ogg Vorbis")); > >> >> >>>>> > >> >> >>>>> PCM exporter: > >> >> >>>>> wxString::Format(_("Exporting the selected audio as %s"), > >> >> >>>>> formatStr.c_str()) : > >> >> >>>>> wxString::Format(_("Exporting the entire project as %s"), > >> >> >>>>> formatStr.c_str())); > >> >> >>>>> > >> >> >>>>> > >> >> >>>>> It would probably be better if all of these messages were > handled > >> >> >>>>> in > >> >> >>>>> one place rather than multiple (near but inconsistent) > >> >> >>>>> duplications, > >> >> >>>>> but that is probably more than we want to change with an > imminent > >> >> >>>>> freeze, especially as RM is wanting to minimise translation > >> >> >>>>> string > >> >> >>>>> changes. > >> >> >>>>> > >> >> >>>>> I'd suggest logging this as a change for 2.2.2. > >> >> >>>> > >> >> >>>> > >> >> >>>> > >> >> >>>> I've lived with this for 10 years now - I can wait a little > >> >> >>>> loneger, > >> >> >>>> > >> >> >>>> It is logged by virtue of being in Wiki>Wording > >> >> >>>> > >> >> >>>> unless, that is, you want to write a Wiki proposal for > >> >> >>>> "Centralized > >> >> >>>> message > >> >> >>>> service" ;-)) > >> >> >>> > >> >> >>> We already have "centralise message service" for other types of > >> >> >>> message, most notably the Help system. > >> >> >>> This is more specific than that. There are a few translated > >> >> >>> messages > >> >> >>> that are common to multiple exporters, that could perhaps be > >> >> >>> centralised in Export.cpp rather than duplicating in each > exporter > >> >> >>> (for example, there's also _("Unable to open target file for > >> >> >>> writing" > >> >> >>> ) > >> >> >>> > >> >> >>> This probably doesn't have huge benefits for users, though it > will > >> >> >>> reduce work for new translations, and consistency is generally > good > >> >> >>> for users. > >> >> >>> What do you think James? Would this be a suitable item for the > >> >> >>> "Proposal Low Hanging Fruit" page? > >> >> >> > >> >> >> Nope. As you state above it has relatively small return for the > >> >> >> effort, > >> >> >> whereas that page contains proposals that have a good ROI. The > >> >> >> proposal > >> >> >> also > >> >> >> does not have a proposal page. The proposals on > >> >> >> http://wiki.audacityteam.org/wiki/Proposal_Low_Hanging_Fruit do. > >> >> > > >> >> > > >> >> > > >> >> > OK I agree that it does not belong on the Low Hanging Fruit page > >> >> > (you've > >> >> > persuaded me of that) > >> >> > > >> >> > But the fact remains that it is a GUI bug - it is inaccurate and > >> >> > misleading > >> >> > - it doesn't do "what it says on the tin" > >> >> > This is a GUI bug that has never been logged - if it were I'd give > it > >> >> > P3 > >> >> > so > >> >> > it gets Release Noted. > >> >> > > >> >> > It should be relatively small effort if we opt as I suggested > earlier > >> >> > for a > >> >> > revised common message for Export Audio and Export Multiple > >> >> > > >> >> >>But, if the problem is that we must have the same message for > Export > >> >> >> Audio > >> >> >> and for Export Multiple > >> >> >>then one that says Exporting the audio file as <audio file format> > >> >> >>would be much preferable and appropriate in both cases > >> >> > > >> >> > I'm inferring from what Steve says that the message for both is a > >> >> > common > >> >> > one > >> >> > - my suggestion above would be suitable for > >> >> > both use cases - and should be a very simple textual changed. > >> >> > >> >> Yes, these messages are common to both single file export and Export > >> >> Multiple. > >> >> The simple solution is to just change the wording so that it is > >> >> appropriate for both cases. > >> > > >> > > >> > > >> > > >> > Ohhhh, then *please do* - then I won't need to log it at all :-)) > >> > > >> > > >> > > >> >> > >> >> > >> >> > > >> >> > If we're not going to fix it (and not put it on Low Hanging Fruit) > >> >> > then I would want to log it as P3 to keep some focus on it. > >> >> > >> >> I think that P4 is more appropriate. I'm not keen on artificially > >> >> elevating the P rating just so that it gets done. > >> > > >> > > >> > > >> > I was thinking P3 not to elevate - byt rather to ensure that it gets > an > >> > aut0 > >> > exported Release Note > >> > > >> > > >> > > >> >> > >> >> However, if you > >> >> remind me after 2.2.1 has been released, then I'll be happy to work > >> >> with you and do at least the simple solution of updating the > messages. > >> >> For now, you could perhaps look through the existing text (from my > >> >> previous email) and devise a list of updated messages. > >> > > >> > > >> > > >> > > >> > I can try to do that. > >> > > >> > > >> > > >> >> > >> >> It will then be > >> >> easy to change those straight after the 2.2.1 release. > >> > > >> > > >> > > >> > Any chance of doing just this simple one for 2.2.1? > >> > >> > >> I don't think it's essential to release note it. I'm not aware of > >> anyone on the forum (or feedback@) saying they are confused by it, and > >> as you say, we've lived with it for 10 years. > >> I also expect that RM will say no because it will break the existing > >> translations. > > > > > > > > I'm failing to understand why the translations should be an impediment to > > doing this now. > > Because RM wrote: > > [quote] > Additions to the translatable strings will be allowed until Friday, 10 > Nov, after which I want to freeze again and invite translators to > catch up, but I expect most probably will not in the short window.. I > would discourage changing translatable strings that already exist. > > I propose then this tentative schedule of Fridays: > > 10 Nov -- string freeze > 17 Nov -- RC1 > 24 Nov -- possible RC2 > 1 Dec -- release > [/quote] > > If those dates have been revised, I missed it. > Sorry, but I missed that post. - and it does ay it is a proposal and not a definite plan. And I note that: http://wiki.audacityteam.org/wiki/Next_Release which is our normal worktool for this does not have that plan' (In fact it has out out of date and inaccurate plan for 2.2.0 still.) So 2.2.2 it is then ... And in the meantime I'll take a look at the other Export progress messages in your earlier email in this this thread. For completeness can you pleaswe add what the WAV exporter does. Since there are so many different ones I shall probably put together a little proposal in the Wiki for this. It'll give me something to do in the freeze up to 2.2.1 release. Cheers, Peter. > > Steve > > > > > > > We are not in "freeze" or even in declared "semi-freddo" - this is > supposed > > to be a bug-fix release > > and this is a bug, albeit an unlogged one at the moment. > > > > > > > >> > >> Let's just remember to do it after the release of 2.2.1. > > > > > > > > Well, it's already logged in Wiki > Wording > > > > Peter. > > > > > > > >> > >> > >> Steve > >> > >> > > >> > It'll give me a lot more work in the Manual than you will have to make > >> > the > >> > textual change > >> > but I'm more than happy to shoulder that effort. > >> > > >> > Peter. > >> > > >> > > >> >> > >> >> > >> >> Steve > >> >> > >> >> > > >> >> > Peter. > >> >> > > >> >> > > >> >> > > >> >> >> > >> >> >> --James. > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> > >> >> >> ------------------------------------------------------------ > ------------------ > >> >> >> Check out the vibrant tech community on one of the world's most > >> >> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> >> >> _______________________________________________ > >> >> >> Audacity-quality mailing list > >> >> >> Aud...@li... > >> >> >> https://lists.sourceforge.net/lists/listinfo/audacity-quality > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > ------------------------------------------------------------ > ------------------ > >> >> > Check out the vibrant tech community on one of the world's most > >> >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >> >> > _______________________________________________ > >> >> > Audacity-quality mailing list > >> >> > Aud...@li... > >> >> > https://lists.sourceforge.net/lists/listinfo/audacity-quality > >> >> > > >> > > >> > > > > > > |