Re: [Audacity-devel] Removing Leveller effect

[Steve t. F. <ste...@gm...>]

On 2 July 2016 at 12:52, Peter Sampson <pet...@gm...> wrote:
> I don't see the old "Leveller" effect in the latest W10 nightly
> audacity-win-rdab59cb-2.1.3-alpha-02-jul-16

Good. Currently it is disabled by default on Windows.
On Linux it is not built at all. That needs to be the same on Windows
and Mac OS X and then the Leveller.cpp and Leveller.h files can be
removed from Git (they will still exist in the Git history).

>
> And note that the "Leveller" option in the "Distortion type"
> dropdown should be spelled in US Eglish as "Leveler".

I think this is an exception to the rule.
The setting "Leveller" in the Distortion effect is modelled on the old
"Leveller" effect from Audacity 2.1.2 and earlier. The name itself is
fairly meaningless, as the original intention was for it to be a
simple "dynamic compressor" effect, but for whatever reason, the
released effect acted on samples rather than on "frames" (the code
refers to "frames" but those "frames" are actually single samples).
The word "Leveller" in the Distortion effect is therefore referring to
the "name" of the old effect, which was spelt "Leveller".

>
> And the same applies to "Degree of Levelliing" in the main
> Distortion dialog.

Again, this is a direct copy from the old effect.

>
> Personally I always think it looks better with the double-L, but
> ths house-rules are US English for the GUI and documentation.

If the old Leveller effect has been spelt with a silent "p", then I
would have spelt it with a silent "p" in this emulation :-)
In other words, the name "Leveller" is being used as a proper noun, so
the spelling should match the original.

Steve

>
> Peter
>
> On Fri, Jul 1, 2016 at 4:55 PM, Steve the Fiddle <ste...@gm...>
> wrote:
>>
>> As the Leveller effect is now included in the Distortion effect (with
>> real-time preview), I've removed it as a separate effect from
>> LoadEffects, and from the Linux makefile.
>>
>> I've not removed the files Leveller.cpp and Leveller.h from Git as I
>> presume that would break the Windows and Mac builds until it has been
>> removed from those builds. Could someone take care of Windows and Mac
>> and then remove the files from Git.
>>
>> Thanks
>> Steve
>>
>>
>> ------------------------------------------------------------------------------
>> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
>> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
>> present their vision of the future. This family event has something for
>> everyone, including kids. Get more information and register today.
>> http://sdm.link/attshape
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>