Re: [Audacity-quality] Bug 1024 - Check for updates fails

[Steve t. F. <ste...@gm...>]

Cc: to Leland as he has commented on bugzilla.


On 31 July 2015 at 18:59, Peter Sampson <pet...@ya...> wrote:
> http://audacityteam.org/download/?from_ver=2.1.2-alpha-Jul%2031%202015

I'm surprised to see the %20 substitutions happening automatically,
That does not happen here. On Linux the URL gets thrown out before it
gets to the web browser (as per
https://bugs.launchpad.net/leo-editor/+bug/951739).

Steve

>
> Peter.
>
> Peter Sampson
> Tel: +44 (0)1625 524 780
>
> ________________________________
> From: Steve the Fiddle <ste...@gm...>
> To: Peter Sampson <pet...@ya...>; audacity-quality
> <aud...@li...>
> Sent: Friday, July 31, 2015 6:03 PM
> Subject: Re: [Audacity-quality] Bug 1024 - Check for updates fails
>
> On 31 July 2015 at 16:01, Peter Sampson <pet...@ya...> wrote:
>> Works on W7-HP 64-bit with latest  alpha nightly 2.1.2 r3715b21 31-jul-15
>
> What address is shown in your web browser when you check for updates?
>
> Steve
>
>>
>> Peter.
>>
>> Peter Sampson
>> Tel: +44 (0)1625 524 780
>>
>>
>>
>> ________________________________
>> From: Steve the Fiddle <ste...@gm...>
>> To: "for identification, characterization, and prioritization of bugs."
>> <aud...@li...>
>> Sent: Friday, July 31, 2015 3:31 PM
>> Subject: [Audacity-quality] Bug 1024 - Check for updates fails
>>
>> I reopened this bug because "Check for updates" fails with the current
>> build.
>>
>> In this case, the reason for the failure is different. The URL that is
>> passed to OpenInDefaultBrowser is:
>> http://audacityteam.org/download/?from_ver=
>> and then the version string.
>> The problem is that for alpha builds, the version string ends with the
>> date, which has spaces that produce a malformed URL.
>>
>> I can fix this by stripping the suffix from the end of the URL, which
>> fixes it for now, but if we ever use the URL on the web server to tell
>> the user if Audacity is the latest version, then the web server will
>> not see the "alpha" status.
>>
>> An alternative approach would be to replace the spaces in the URL with
>> hyphens. This would need to be done where we determine the URL because
>> we use the full version string elsewhere (for example in AUP files).
>> or
>> We could strip the date from the URL in alpha builds.
>> or
>> For alpha builds we could add the commit id.
>>
>> The commit id is mentioned in the "build info" in "About Audacity",
>> but in my builds it always shows as "No revision identifier was
>> provided". Is this something that needs to be manually added when
>> building?
>>
>> I think that the "best" solution will depend on what we intend to do
>> on the web server. Currently we just return the main download page.
>>
>> Steve
>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> Audacity-quality mailing list
>> Aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>
>
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>>
>> _______________________________________________
>> Audacity-quality mailing list
>> Aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
>
>