Re: [Audacity-quality] Use of "-" in Spectral Selection Toolbar

[Peter S. <pet...@ya...>]

Ok I've updated the P2 in the Manual for this.
Once I get a build with it in and can test it then I can update the text of the Manual.
Thanks for that Paul,Peter. Peter Sampson
Tel: +44 (0)1625 524 780

      From: Paul Licameli <pau...@gm...>
 To: Peter Sampson <pet...@ya...> 
Cc: audacity-quality <aud...@li...> 
 Sent: Wednesday, July 29, 2015 5:16 PM
 Subject: Re: [Audacity-quality] Use of "-" in Spectral Selection Toolbar
   
Done: https://github.com/audacity/audacity/commit/910e7f87bd180f0a9c3e16ae90508228370eddb7

Delete key not -, and it works in center and width control.  Typing Delete in either of those controls will leave spectral selection top and bottom both undefined.

PRL




On Wed, Jul 29, 2015 at 10:35 AM, Paul Licameli <pau...@gm...> wrote:

All right, but it may be worth documenting that when center and width show hyphens, that means at least one of low and high is undefined, not necessarily both.
PRL


On Wed, Jul 29, 2015 at 10:19 AM, Peter Sampson <pet...@ya...> wrote:

Paul wrote:>I like the suggestion to use Delete instead. 
+1   I like that suggestion too - *much* better than the minus sign :-)
And it saves real estate on the Toolbar by avoiding a reset button.
I'd still prefer to see it operating on both views of the SE toolbar though.
Cheers,Peter.
Peter Sampson
Tel: +44 (0)1625 524 780

      From: Paul Licameli <pau...@gm...>
 To: audacity-quality <aud...@li...> 
 Sent: Wednesday, July 29, 2015 3:10 PM
 Subject: Re: [Audacity-quality] Use of "-" in Spectral Selection Toolbar
   


On Wed, Jul 29, 2015 at 10:05 AM, Steve the Fiddle <ste...@gm...> wrote:

On 29 July 2015 at 14:52, Paul Licameli <pau...@gm...> wrote:
> Suppose sample rate is 44100, low frequency is 1 and high frequency is
> 22050; then the geometric mean is about 148 Hz, and Spectral Edit Multi-Tool
> would do a notch filter centered there.
> Suppose low frequency is 1 and high frequency is undefined.  Then Spectral
> Edit Multi-Tool would do a lowpass filter at 1 Hz.  Very different results!
>
> So that example illustrates why making high frequency undefined is not the
> same as making it the maximum possible for the track.
>
> Why don''t I make the center and width controls responsive to the - key?  I
> suppose I could, but it would have to be that typing - in either control
> would put -'s in both controls, because unlike with low and high, it makes
> no sense to define only one of center and width without the other.

Why not use a "clear" or "reset" button, or use the "Delete" key, or
some other standard method for resetting rather than inventing a new
and unfamiliar way to remove / reset the values? Plenty of options to
choose from, so no need to invent a better wheel.

Steve



Most of the work was needed to make any key clear the control, and changing which key that is, is easily done.

Backspace in the text box controls already does something -- it moves your highlight left one digit and makes a zero -- but Delete does nothing yet and is passed through to the application and deletes the selection.

I like the suggestion to use Delete instead.

PRL
 


>
> But also note that if only one of low or high is undefined, then if you
> switch the toolbar to center and width, then both of those are undefined.
> Yet, the spectral selection is not completely undefined.  So you see?  The
> state in which center and width show all - is not necessarily a completely
> undefined spectral selection.  The -'s there do not reflect the spectral
> selection -- they underspecify it.  So that made me think I should not allow
> you to type - into them because you would be underspecifying the selection.
>
> That could the the wrong choice, we might agree, "make the selection totally
> undefined in that case."
>
> PRL
>
> On Wed, Jul 29, 2015 at 8:36 AM, Peter Sampson <pet...@ya...>
> wrote:
>>
>> Hi Paul,
>>
>> you wrote in an ednote in the Manual on the Tools Toolbar page
>> a couple of days ago:
>> > now typing hyphen ('-') in any digit position of the low or high
>> > frequency
>> >control resets it to undefined, which is distinct from making it defined
>> >but maximal or minimal.
>> http://manual.audacityteam.org/man/Toolbars_Overview
>>
>> I have tested this on W7-HP 64-bit 2.1.2 alpha nightly  r504d4b5 27-jul-15
>> and it does what you say.
>>
>> But is there any reason that you have not made this work when in
>> "Center frequency and Width" view of the Spectral Selection Toolbar?
>>
>>
>> Oh, and for the purposes of documenting the Manual for non-techie users
>> can you please explain the subtle differences alluded to in the statement:
>> "resets it to undefined, which is distinct from making it defined but
>> maximal
>> or minimal" - as I'm confused by that (easily done).
>>
>> Peter.
>>
>> Peter Sampson
>> Tel: +44 (0)1625 524 780
>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Audacity-quality mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality


>

------------------------------------------------------------------------------
_______________________________________________
Audacity-quality mailing list
Aud...@li...
https://lists.sourceforge.net/lists/listinfo/audacity-quality



------------------------------------------------------------------------------

_______________________________________________
Audacity-quality mailing list
Aud...@li...
https://lists.sourceforge.net/lists/listinfo/audacity-quality