Re: [Audacity-quality] Sync lock and "editing a clip can move other clips" preference

[Steve t. F. <ste...@gm...>]

On 19 January 2015 at 05:24, Chrysophylax <chr...@ya...> wrote:
> Here's what I am thinking.
>
> To adjust a sync-locked track, when the edited selection changes length, one or two things happen:
>
> 1) If the right edge of the selection, before the edit, was inside a clip of the sync-locked track -- then change that clip, either deleting from it (and possibly earlier clips too), or inserting silence; and --
>
> 2) If other clips are (completely) to the right of that time, then move them all either left or right.
>
> Now the preference disallows (2).  So if (2) would be required, should the program do nothing and fail the entire edit?  That would enforce the preference.  Or should it quietly ignore that and let the edit proceed with no effect on the sync locked track?  That is not honoring the preference.  Or should it do only part (1) and quietly skip part (2)?  But that's not really doing a complete sync-lock.
>
> What if part (2) is not required?

The preference should be enforced because
that_is_what_the_user_has_told_it_to_do.

>  Should it do part (1) as needed?

When Sync-Lock can be performed without moving other clips, then it
should do so.

It may not be particularly useful in most cases to have Sync-Lock
enabled and the preference to move other clips disabled, but it is
logically valid, and other than it being tricky  to implement I see no
reason to disable it.

>  Then that might be a complete sync-lock in that case, but then, sync lock would sometimes be completed and sometimes not.

If that is what the user has told the computer to do, then that, imho,
is what the computer should do.

>
>
> What does Audacity actually do now?

I think that most of the behaviour is quite reasonable in that it
performs Sync-Lock as far as possible without moving other clips. The
notable exception being the bug that we are discussing.


> I think it is not a consistent implementation of any of those choices, as documented in bug 825.
>
> So I think it may be simplest to sidestep this messy question and just say, no sync-locked allowed, when the preference does not allow moving of clips.

Yes that would be the simplest, but not the right thing to do imo.

Steve

>
>
>
>
>
> On Friday, January 16, 2015 11:08 AM, Chrysophylax <chr...@ya...> wrote:
> See but 825, one of several I recently added after my own review of WaveTrack.cpp for my own education.
>
> When the "editing a clip can move other clips" check box is off, Sync Lock causes strange things to happen.  How should correct behavior be defined?
>
> Perhaps Sync Lock should just be disabled when that preference is off.
>
> ------------------------------------------------------------------------------
> New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
> GigeNET is offering a free month of service with a new server in Ashburn.
> Choose from 2 high performing configs, both with 100TB of bandwidth.
> Higher redundancy.Lower latency.Increased capacity.Completely compliant.
> http://p.sf.net/sfu/gigenet
> _______________________________________________
> Audacity-quality mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality