Re: [Audacity-quality] GUI dialogs for Hard Limiter & SC4

[Martyn S. <mar...@gm...>]

On 23/03/2014 22:33, Vaughan Johnson wrote:
> IIRC, we agreed a while ago to stop shipping both of those, in favor
> of the comprehensive LADSPA zip file (because both are included
> there). But I just did a fresh install, and they're there.
>
> We removed them from our code repository, so I think what happened is
> that Martyn made the installer, and still has them in his
> audacity-src\plug-ins folder, so they just got put into the installer
> with all the others in that folder.
>
> So Martyn please remove them from your audacity-src\plug-ins folder,
> so this won't happen again.

They are not there.

I just follow

http://wiki.audacityteam.org/wiki/Release_Process/Win

when I make a build, and I think this point relates to

http://wiki.audacityteam.org/wiki/Release_Process/Win#Copy_Other_Necessities_to_Release_Build_Folder

which perhaps needs updating?

I don't recall us agreeing to stop shipping those (but I don't 
remember many things), and it obviously wasn't recorded in that 
relevant place if we did.

TTFN
Martyn

> So, actually, Peter, the question should be moot. But iirc:
>
> * We use the same dialog width for all LADSPA plugins.
>
> * Those are not in our code base, so we use whatever text the plugin
> says it wants to display. In other words, author attribution is not
> under our control for LADSPA (or VST), only for our own plugins.
>
> - Vaughan
>
>
>
> On 3/23/2014 8:49 AM, Peter Sampson wrote:
>> For both of the effects "Hard Limiter" and "SC4" the width of the
>> GUI dialogs seems to me to be unnecessarily wide, inconsistently
>> so when compared to all other shipped effects in Audacity.
>>
>> Also both of these effects still carry author attribution - and I
>> thought
>> that policy was for such attribution to be removed.
>>
>> Thanks,
>> Peter.
>>
>> Peter Sampson
>> Tel: +44 (0)1625 524 780
>> Mob: +44 (0)7732 278 299
>>