Re: [Audacity-devel] Greater range on vertical zoom
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Martyn S. <mar...@gm...> - 2013-11-28 01:09:16
|
Hi again Thinking about this further (and this is distracting me from organising something else)... On 27/11/2013 01:49, Martyn Shaw wrote: > Hi Norm > > This looks useful, and I am supporting the idea. > > The value of 0.001 is purely arbitrary, and does not take into account > the bit-depth of the track, it perhaps should be reliant on that. And > there may be issues there with many tracks of different bit-depths. ...but it's better than we have. At the very least the 0.001 should be in as, like #define ZOOMLIMIT 0.001 so that it is easy to play with in one place. So I did that. There is actually an error with this in the patch I think, around line 3610, where 'l = wxMax( 0.0005, (c - min));' should be 'l = wxMax( 0.001, (c - min));'. Substituted ZOOMLIMIT, since the 0.5* happens a few lines below. > I think I have seen a problem with the 'top' and 'bottom' values > reversed, (but I have no idea how to repeat that). I did that again, I have it repeatable, and a bug (but a very ancient one): Waveform view Right-click on the vertical ruler, to go to +-2 view Right-click drag a small region around -1.5, maybe you have -1.35 (top) to -1.5 (bottom) displayed Right-click, now I get -1.20 (top), -1.00 (bottom) which has the scale upside-down! At this point we are wrong! Repeatedly right-click for further (non-crash) effect, like zooming out to -1000000 (top), +1000000 (bottom). I just tried this in 1.2.6, same problem. Age-old, but could do with fixing. Somebody could take that on. > And then there are the bugs you mention. > > I don't have much time right now, but I think this should be followed > up. Is anybody else up for it? > > TTFN > Martyn > > On 23/11/2013 23:36, Norm C wrote: >> Here's the patch. As a reminder, it allows vertical zooming down to >> a range >> of 0.001 in waveform view, and allows you to return to normal zoom >> (in any >> view) by doing a shift-right-click. Would that work on a Mac? I'm guessing not. Is there some other reasonable combination that would? I have committed it as 'better than we had', but it needs some work for other platforms, perhaps. While testing it I noticed 4 >> bugs, but I >> don't think I caused any of these: >> >> - if range is -2 to 2, then zooming in by dragging to get values >> below -1 or >> above 1 can result in the blue being drawn too far down or up. In >> fact, it >> looks like it's at the middle of the screen, vertically Probably/possibly related to the ancient bug I wrote about above. Not a biggy. >> - in waveform dB view, you can get repeated values on the Y axis, when >> zoomed in This is possibly a problem with the Ruler code, and when it switches resolution to using decimal places. I am seeing a 'minor' marker at -50.6 and a 'major' (bold) marker further up at -50.6, for example. Is that what you mean? If so, barely worth fixing. I didn't look into this further. >> - same in spectrum log view >> - pitch view doesn't seem to work at all A more global question: Why do we restrict the 'zoom out' to +-2? I think this dates from when we 'artificially' clipped audio outside +-1, even for 32-bit float, but we dropped that some time ago; now we do not lose any resolution of the audio if it is many dB outside the +-1 limit, when using 32-bit floats. TTFN Martyn >> Norm >> >> TrackPanel_VZoomImproved.diff >> <http://audacity.238276.n2.nabble.com/file/n7560700/TrackPanel_VZoomImproved.diff> >> >> >> >> >> -- >> View this message in context: >> http://audacity.238276.n2.nabble.com/Greater-range-on-vertical-zoom-tp7560541p7560700.html >> >> Sent from the audacity-devel mailing list archive at Nabble.com. >> >> ------------------------------------------------------------------------------ >> >> Shape the Mobile Experience: Free Subscription >> Software experts and developers: Be at the forefront of tech >> innovation. >> Intel(R) Software Adrenaline delivers strategic insight and >> game-changing >> conversations that shape the rapidly evolving mobile landscape. Sign >> up now. >> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk >> >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> |