Re: [Audacity-quality] Numerical input validation
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2013-11-23 04:25:43
|
On 11/22/2013 7:02 AM, Steve the Fiddle wrote: > On 22 November 2013 00:05, Vaughan Johnson <va...@au...> wrote: >> Most validators (where they were even used) were written over a number >> of years by different people, and some were even less complete, e.g., >> just allowing digits and punctuation. For most of that time span, >> wxWidgets validators were very limited, e.g., text-only or digits-only. >> >> Leland backported some more elaborate validators from wxWidgets 3.0rc1, >> into valnum.*, and used them in Nyquist.cpp. >> >> +1 to going through all controls and applying the most appropriate >> validator from the valnum classes. > > The main problem that we have with using the new validator is that > wxFloatingPointValidator limits the precision to a specified number of > decimal places. For some Nyquist plug-ins (such as "Tempo" in Click > Track) this is clearly a regression (bug 685). > > All Nyquist plug-ins use the same widgets and the same validators, and > the only way that I can see to restore "unlimited" precision for typed > values is to revert back to the old wxFILTER_NUMERIC validator, but > then we lose validation of the decimal separator character. > I don't see any way to allow unlimited precision for typed values > while using the new wxFloatingPointValidator (though that could just > be down to my lack of experience), > > There are also accessibility issues due to range validation with the > new validators (bug 681). Again this could easily be resolved for > Nyquist plug-ins by reverting to old validation methods, but again we > lose the benefits of the new validators. Aren't they overall better than what we have? Implement them, then override those classes to do what we want? Write our own and ditch those? I think the options are clear, and we want to be consistent within Audacity. - V > > I suppose the real question here is, can bugs 681 and 685 be fixed > while still using the new validators? (I have a patch on bugzilla for > bug 681 but Gale tells me that it does not work correctly on Windows). > If these bugs can be fixed (cross platform) then I guess that we would > want to roll this out across other effects? > > Steve > > >> - V >> >> >> On 11/21/2013 8:25 AM, Steve the Fiddle wrote: >>> I've been looking at bug 685 (Limited precision for Nyquist plug-in >>> sliders) and comparing the validation of typed input with that in >>> other effects. I've discovered there is a lot of variation. >>> >>> In most cases validation is against any numerical character, that is: >>> 0 to 9, +, -, e, "." (dot) and "," (comma). >>> Although comma can be typed, when the language setting is English the >>> comma and any characters after the comma are ignored. I've not tested >>> with other language settings. >>> >>> In Change Pitch "Frequency" control, validation is against: >>> 0 to 9 and "." only. >>> This control will not accept a comma as the decimal separator in any language. >>> >>> If we decided that it was acceptable to only allow "dot" as the >>> decimal separator, then all effects (including Nyquist plug-ins) could >>> be made consistent with this. >>> >>> Thoughts, comments? >>> >>> Steve >>> >>> ------------------------------------------------------------------------------ >>> Shape the Mobile Experience: Free Subscription >>> Software experts and developers: Be at the forefront of tech innovation. >>> Intel(R) Software Adrenaline delivers strategic insight and game-changing >>> conversations that shape the rapidly evolving mobile landscape. Sign up now. >>> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> Audacity-quality mailing list >>> Aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-quality >>> >> >> ------------------------------------------------------------------------------ >> Shape the Mobile Experience: Free Subscription >> Software experts and developers: Be at the forefront of tech innovation. >> Intel(R) Software Adrenaline delivers strategic insight and game-changing >> conversations that shape the rapidly evolving mobile landscape. Sign up now. >> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk >> _______________________________________________ >> Audacity-quality mailing list >> Aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-quality > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > Audacity-quality mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-quality > |