Re: [Audacity-devel] bug 675. Track Drop-down Menu commands (enhancement)

[Steve t. F. <ste...@gm...>]

On 29 October 2013 22:56, Steve the Fiddle <ste...@gm...> wrote:
> On 29 October 2013 21:51, Richard Ash <ri...@au...> wrote:
>> On Tue, 29 Oct 2013 15:17:02 +0000
>> Steve the Fiddle <ste...@gm...> wrote:
>>>
>>> If preferred, here's a more thorough version that also cleans up
>>> trailing spaces (attached).
>>
>> Also applied. I also made blank lines properly blank, i.e. removed
>> spaces and tabs on them, whilst I was at it (egrep -n "^[[:space:]]+$"
>> src/TrackPanel.cpp)
>>
>> Richard
>
> Thanks Richard.
>
> Attached is the "refactor Split Tracks" part.
>
> It's not obvious with this being out of context, but the main reason
> for this patch is so that I can use the existing
> TrackPanel::SplitStereo in TrackPanel::OnSwapChannels (not in this
> patch) rather than duplicating code. It seemed to be to be a lot
> simpler and easier to read to move PushState into
> TrackPanel::OnSplitStereo and TrackPanel::OnSplitStereoMono rather
> than adding some convoluted conditional statement to correctly handle
> being used in three different commands, and much better than
> duplicating code.
>
> Does that make sense?
> Any reason not to do this?
>
> Steve

By the way, I've not put this patch on bugzilla yet. I can do if you
think it's reasonable to move the "PushState" like this.

Steve