Re: [Audacity-devel] Patch: unused defines & code cleanup

[Vaughan J. <va...@au...>]

On 9/23/2013 1:16 PM, Richard Ash wrote:
> On Sun, 22 Sep 2013 12:31:25 +1000
> Campbell Barton <ide...@gm...> wrote:
>
>> This patch removes unused defines and comments some unused blocks of
>> code (maybe whoever checks the patch would prefer to remove this code
>> instead).
>>
>> http://www.graphicall.org/ftp/ideasman42/audacity_unused_defines_and_code_r12582.diff
>
> I have committed all of this (converting #if 0 to deletion), except the
> unused SortCallback() function in prefs/KeyConfigPrefs.cpp.

I know that Leland's habit is to use #if 0 instead of commenting out 
code, so I'll ask him to check the commit, to see whether there's 
actually anything he wants left in there.

It's good practice to comment on why something is commented out (or #if 
0 -ed).

- V


>
> There are two reasons for not deleting this now:
> 1. It's called from a commented line of code at the foot of the
> RepopulateBindingsList() method
>
> 2. Various people have been working on that file and I'm not entirely
> sure any of them have finished, and therefore whether the function is
> intended for use in something that isn't working yet.
>
> Richard
>