Re: [Audacity-devel] Assert on launching revision 12479

[James C. <cr...@in...>]

On 25/08/2013 21:37, Vaughan Johnson wrote:
> Thanks for the follow-up. Why does r12464 just comment out the
> conditionals, rather than eliminate them or give a comment about why
> they're commented out?
Removed now.

I was commenting out those lines without being 100% sure why they were 
there in the first place.  So leaving them commented out was a hint as 
to what had been going on previously in case something later 'blew up' 
in that area.

--James.



> - V
>
>
> On 8/25/2013 6:53 AM, James Crook wrote:
>> This is to do with revision r12464.
>>
>> I've made a check in that might help (can't tell for sure as I am not on
>> Linux).
>> I've not properly understood why the problem happens.  It's as if for
>> some reason your code is passing multi as false for menu creation for
>> nyquist generators/effects when I expect it to be true - so that name
>> comes out the same every time and we're attempting to create the same entry.
>>
>> With this change:
>> Does exporting and importing of key bindings for nyquist effects work on
>> linux?
>> Does remembering of key bindings for nyquist effects work on linux?
>>
>> --James.
>>
>>
>>
>>
>>
>>
>>
>> On 25/08/2013 12:39, Steve the Fiddle wrote:
>>> Debug build on Linux, revision 12479.
>>>
>>> commands/CommandManager.cpp(705): assert "!prev" failed in
>>> NewIdentifier().
>>>
>>>
>>> ASSERT INFO:
>>> commands/CommandManager.cpp(705): assert "!prev" failed in
>>> NewIdentifier().
>>>
>>> BACKTRACE:
>>> [1] CommandManager::NewIdentifier(wxString, wxString, wxMenu*,
>>> CommandFunctor*, bool, int, int)
>>> /home/steve/sourcecode/audacity-clean/src/commands/CommandManager.cpp:708
>>> [2] CommandManager::AddItemList(wxString, wxArrayString,
>>> CommandFunctor*, bool)
>>> /home/steve/sourcecode/audacity-clean/src/commands/CommandManager.cpp:563
>>> [3] AudacityProject::CreateMenusAndCommands()
>>> /home/steve/sourcecode/audacity-clean/src/Menus.cpp:843
>>> [4] AudacityProject::AudacityProject(wxWindow*, int, wxPoint const&,
>>> wxSize const&) /home/steve/sourcecode/audacity-clean/src/Project.cpp:837
>>> [5] AProjectArray::Add(AudacityProject*, unsigned int)
>>> /home/steve/sourcecode/audacity-clean/src/Project.h:89
>>>
>>> After 32 repetitions Audacity launches.
>>>
>>> With Nyquist effects disabled the assert occurs 4 times and the debug log:
>>>
>>> 12:32:28: Audacity 2.0.4-alpha-Aug 25 2013
>>> 12:32:30: Debug: DirManager: Created new instance.
>>> 12:32:30: Debug: Command 'GeneratePlugin:Sine Oscillator
>>> (Freq:control, Amp:control)...' defined by 'Sine Oscillator
>>> (Freq:control, Amp:control)...' and 'Sine Oscillator (Freq:control,
>>> Amp:control)...'
>>> 12:32:30: Debug: commands/CommandManager.cpp(705): assert "!prev"
>>> failed in NewIdentifier().
>>> 12:32:56: Debug: Command 'EffectPlugin:Sine Oscillator (Freq:audio,
>>> Amp:audio)' defined by 'Sine Oscillator (Freq:audio, Amp:audio)' and
>>> 'Sine Oscillator (Freq:audio, Amp:audio)'
>>> 12:32:56: Debug: commands/CommandManager.cpp(705): assert "!prev"
>>> failed in NewIdentifier().
>>> 12:32:58: Debug: Command 'EffectPlugin:Sine Oscillator (Freq:audio,
>>> Amp:control)...' defined by 'Sine Oscillator (Freq:audio,
>>> Amp:control)...' and 'Sine Oscillator (Freq:audio, Amp:control)...'
>>> 12:32:58: Debug: commands/CommandManager.cpp(705): assert "!prev"
>>> failed in NewIdentifier().
>>> 12:32:58: Debug: Command 'EffectPlugin:Sine Oscillator (Freq:control,
>>> Amp:audio)...' defined by 'Sine Oscillator (Freq:control,
>>> Amp:audio)...' and 'Sine Oscillator (Freq:control, Amp:audio)...'
>>> 12:32:58: Debug: commands/CommandManager.cpp(705): assert "!prev"
>>> failed in NewIdentifier().
>>>
>>> The other 28 occurrences happen if Nyquist plug-ins are enabled and
>>> LADSPA disabled.
>>>
>>>
>>> Steve