Re: [Audacity-devel] Libsndfile patch: Request from Erik de Castro Lopo

[Joel B. <bo...@ho...>]

Hello Richard,

i have received a mail from Mr de Castro Lopo.
Our patch does not apply to git HEAD...

Here is the mail:

> Date: Tue, 20 Aug 2013 18:31:11 +1000
> From: er...@me...
> To: lib...@me...
> Subject: [libsndfile-devel] Re: patch submit: 0001-Add-support-for-Album-and-Track-tags-in-RIFF-files
>
> Joel Bouchat wrote:
>
>> being a new contributor to Audacity, i submit a patch to upgrade libsndfile.
>> This patch has already be reviewed by Richard Ash who is a member of
>> libsndfile development list.
>
> Sorry, this patch doesn't apply to current git HEAD.
>
> Is it possible to send a pull request on github?
>
> Cheers,
> Erik

==> Could you perform this pull request from your platform ? I can't from my PC...

Thank you,

Best regards,

Joel

Her----------------------------------------
Date: Fri, 16 Aug 2013 22:48:59 +0100
From: ri...@au...
To: aud...@li...
Subject: Re: [Audacity-devel] Back to ID3v2 metadata in WAV files


On Mon, 12 Aug 2013 10:12:25 +0200
Joel Bouchat <bo...@ho...> wrote:
>From the programming side, this patch is finished and it could be a
>>candidate for commitment.
> But before the commitment i think that two questions still need the
> agreement of the developer group:
>
> - the patch modifies "libsndfile": is it acceptable? and, if it is,
> there is certainly a procedure to update
> "lib-src/audacity-patches.txt"

See the existing content in there - the main things are:
* Commit the patch (to the single library code only) as a file, so it
  can be re-applied in future
* List the file name of the patch in the text file, with a description
  of what the patch is for
* Record whether the patch has been submitted upstream, and if so
  whether it has been accepted there (and in what version).

I've started looking at your patch to see what would be needed to get
it upstream into libsndfile (as I'm on their development list already).
It's particularly important to get libsndfile library patches upstream
because most Linux users will have an upstream copy from the system not
Audacity's patched one. Thus my first question:
* if the patches to Audacity are applied, but Audacity is then compiled
  against an un-patched libsndfile, what happens? (hopefully, neither a
  compile error nor a runtime crash!).

Assuming this is the case (and I think libsndfile's design makes it
likely), then we can press on with the patch in Audacity in parallel
with upstream libsndfile - if not, we will need either conditional
compilation or runtime error handling, depending on the problem.

The changes to support read and write in Audacity don't look
problematic, so I've concentrated on the libsndfile patch. A couple of
comments:
* "added to fix foo" comments in the code won't get accepted - either
  a free-standing comment or none.
* try and match the indentation style of the upstream source, i.e. if
  they are using tabs, use the same number of tabs. It makes a hasty
  rejection less likely.

I've taken these out of my testing version of the libsndfile patch, and
tried it on libsndfile git. The wav_write_stringspatch doesn't apply
straight off, but that's just because someone else has added support
for another metadata item ("IAUT") in the meantime - it's easy enough
to fix up.

The implementation of wav_write_strings() has changed in the git
version, so I just copied the other cases in the hope it works the same.

With this done I can make and make test the changes against libsndfile
git from tonight, so it looks in a good shape to submit upstream.

I've attached my modified version of the patch (having extricated it
from git after some tribulations), if you are happy with it, do you
want to send it to the libsndfile-devel mailing list? (that list
doesn't accept attachments, so patch in email body).

Richard

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with
_______________________________________________
audacity-devel mailing list
aud...@li...
https://lists.sourceforge.net/lists/listinfo/audacity-devel