Re: [Audacity-quality] REverb button spacing (was other command/title isses for effects)

[Gale A. <ga...@au...>]

| From Steve the Fiddle <ste...@gm...> 
| Fri, 28 Jun 2013 16:02:28 +0100
| Subject: [Audacity-quality] REverb button spacing (was other command/title isses for effects)
> On 28 June 2013 03:22, Vaughan Johnson <va...@au...> wrote:
> > On 6/27/2013 5:12 PM, Gale Andrews wrote:
> >>
> >> | From Vaughan Johnson <va...@au...>
> >> | Wed, 26 Jun 2013 18:42:09 -0700
> >>> On 6/26/2013 2:22 AM, Gale Andrews wrote:
> >>>>
> >>>> | From Vaughan Johnson <va...@au...>
> >>>> | Tue, 25 Jun 2013 21:27:09 -0700
> >>>>> On 6/25/2013 5:20 PM, Gale Andrews wrote:
> >>>>>>
> >>>>>> | From Steve the Fiddle <ste...@gm...>
> >>>>>> | Tue, 25 Jun 2013 18:22:55 +0100
> >>>>>>> On 25 June 2013 14:50, Gale Andrews <ga...@au...> wrote:
> >>>>>>>>
> >>>>>>>> | From Steve the Fiddle <ste...@gm...>
> >>>>>>>> | Tue, 25 Jun 2013 00:46:08 +0100
> >>>>>>>>> On 24 June 2013 23:53, Gale Andrews <ga...@au...> wrote:
> >>>> [...]
> >>>>>>>>> A "Dry Preview" button could be useful for most of the effects.
> >>>>>>>> ...
> >>>>>>>>
> >>>>>>>>> It was introduced with, and currently only used in the Reverb effect.
> >>>>>>>>> The button spacing does not look quite right - the two preview buttons
> >>>>>>>>> look to be rather cramped compared to the other buttons.
> >>>>>>>> ..
> >>>>>>
> >>>>>> Yes. Is it fixable so that it has the standard spacing between
> >>>>>> buttons?
> >>>>>
> >>>>> Of course. Done. Please test.
> >>>>
> >>>> Thanks. On Windows as you'll have seen, the gap between "Preview"
> >>>> and "Dry Preview" appears the same as the gap between other
> >>>> buttons.
> >>>>
> >>>> On Ubuntu there is slightly more gap between those two buttons
> >>>> than between the other buttons.
> >>>>
> >>>> On Mac I see the same as Ubuntu, but also the "Dry Preview" button is
> >>>> higher then the other buttons in that row (please see attached):
> >>>>
> >>>
> >>> Thanks. I tried doing it a different way, r 12392, that should be better
> >>> cross-platform.
> >>
> >> Thanks. On Mac and Linux, there is still a larger space (one-third of a
> >> button width) between "Preview" and "Dry Preview" than between
> >> other buttons.
> >>
> >> The Mac problem where Dry Preview was too high has been fixed.
> >>
> >> Actually I don't think it looks awful on Mac/Linux. It separates the
> >> two Preview buttons so makes it easier to distinguish them. If it
> >> doesn't violate too many principles I think Windows might even
> >> look better like that?
> >
> > The actual positioning is done per-platform by wxWidgets (see
> > wxStdDialogButtonSizer). I can only give it more-or-less suggestions, as
> > I understand it. I think the two Preview buttons should be as close
> > together as OK and Cancel
> 
> +1, but unfortunately it does not do that on Linux. The space between
> Preview and Dry Preview is now about double the space between OK and
> Cancel. The problem is more apparent if a Preview button is added to
> one of the effects with a small interface (for example the Bass and
> Treble effect). The whole interface is pushed quite a lot wider than
> is really necessary (and looks crap).
> 
> R12385 looks the best here - it would be better if the space between
> Dry Preview and Cancel went smaller on a small windows, but it looks a
> lot better than later versions.

Would we not have to test whether that specific revision has the 
problem with the too-high button on Mac?

I think I actually tested r12386. Or do you mean 12386?



Gale

> > -- they are as much related as those. In other
> > words, I think it looks right on Windows, and I do not know how to tweak
> > it further for the others.
> >
> > - V