Re: [Audacity-devel] Nyquist Generate Prompt

[Vaughan J. <va...@au...>]

On 5/14/2013 7:33 PM, Steve the Fiddle wrote:
> Thanks for the comments Vaughan,
>
> On 15 May 2013 02:23, Vaughan Johnson <va...@au...> wrote:
>> Overall, I think this could turn into a bigger effort than has been
>> considered, possibly be several months, and I don't want it to delay the
>> next release. I don't think it would be tragic to release with only some
>> effects having Help, but it needs to be considered whether that's a
>> gating factor.
>
> I've no intention of holding up 2.0.4 for the Help buttons - so far
> this is just me poking around in the code to see what is there.
> Perhaps I'll have something concrete in time for 2.0.5 :=)

Okay, good.


>...
>> On 5/14/2013 4:26 PM, Martyn Shaw wrote:
>>> ...
>>> On 14/05/2013 17:38, Steve the Fiddle wrote:
>>>> On 14 May 2013 00:51, Martyn Shaw <mar...@gm...> wrote:
>>>>> On 13/05/2013 12:02, Steve the Fiddle wrote:
>>>>>> On 13 May 2013 00:41, Martyn Shaw <mar...@gm...> wrote:
>>>>> ...
>> There was something earlier in this thread about ErrorDialog. This is
>> the user asking for help, not having made an error.
>
> I thought that was a bit strange, but that is where ShowHelpDialog is
> currently located.
> Would it perhaps be better to move ShowHelpDialog and the common
> EffectHelp together in a new HelpDialog class that can handle both?

I would expect what happened was accretion, and not well justified, as I 
see it. From the function names, only 3 of the 6 functions in 
ErrorDialog.h have anything to do with errors. :-(

And none of them is OO. I'd think at least ShowHelpDialog could be a 
method on AudacityProject (and then it wouldn't have to call 
GetActiveProject()!).

> ...
>> If it's all Greek to you, I could do the infrastructure and a sample
>> effect to use as a model, after which it would be pretty mechanical to
>> add new Help buttons.
>
> Thanks for the tips - I can work with that.

Great.

- V