Re: [Audacity-devel] Patch: reverb effect

[Vaughan J. <va...@au...>]

I've completed getting Rob's patch to build on Windows.

Rob was doing some interesting stuff with nested preprocessor directives 
that made the code a lot more compact. Unfortunately, the MSVC 
preprocessor choked on it. I tried several ways around it, to no avail, 
so I manually expanded all of them. The code is bulkier, but doing 
clever things tends to not be cross-platform.

Rob, please look it over, especially my questions in "//vvvvv" comments. 
Btw, our convention in interface is that text on a button is considered 
a title, so for example, I changed "Dry preview" to "Dry Preview".

- Vaughan


On 4/22/2013 6:54 PM, Steve the Fiddle wrote:
> On 23 April 2013 02:48, Vaughan Johnson <va...@au...> wrote:
>> I'll get back to the code, but if this is such an improvement, do we
>> stop shipping GVerb?
>>
>> - V
>
> I see little need to continue shipping GVerb once we have a better reverb.
> While GVerb remains compatible with Audacity, we could perhaps host it
> on the wiki in case anyone specifically wants it? (though I would not
> expect many downloads).
>
> Steve
>