Re: [Audacity-devel] Patch to fix freeze when using Shift+Play on a track that's not 44100Hz

[Gale A. <ga...@au...>]

Maarten wrote:
> >> - draw vruler for time tracks
> >> - use double instead of long for the time track range (90% = 0.9, 110% = 1.1) 
> >> because this simplifies the code that has to do the resampling and also improves 
> >> accuracy (now I just need to find an alternative to wxGetNumberFromUser that 
> >> allows doubles so you can actually use this ...)
> >> - copy time track range (and mHeight) on Init() rather than setting it to a 
> >> fixed value
> >> - rescale time track values (envelope) when the range changes
> >> - save/load time track range  

Many thanks, Maarten. I just tested the patch on Windows so far,
mostly for the save/load time track range which seems to work well. 

I really like the vertical ruler. :=)


> - Create a sine wave.
> - Create a time track, make some changes so you can clearly hear the
> pitch change.
> - Change the range of the time track to something much larger, e.g.
> 50%-500%. Notice how the values are not centered around 100% now (well
> you can't see this because there's no vertical ruler, my patch adds
> that too).
>   -Play the sine wave. The pitch is now much higher and the change in
> pitch is too. This is wrong, it should sound exactly the same, so you
> don't have to redo any work that you did previously

I couldn't figure what you meant because I thought the intention 
was for the zero line on the envelope to represent the mid-point 
of the range. 

So if you have range 80 to 120 or 90 to 110, the zero point on the
envelope sounds identical to there not being any time track. 

If you then say change the range to be from 90 to 190, the zero 
point becomes 140% and the pitch of the whole track moves up.   

Isn't that going to suit some uses of Time Track? If you set envelope 
points and then decide you want the whole thing higher or lower 
pitched, you then just have to change the range. With your patch,
you would have to change all the envelope points. 

Can we preserve that old behaviour somehow by an addition to 
the time track drop-down menu?  



Gale 


Rob wrote:
> >This is all great stuff. Should the user need to manually set ranges though? How about starting off with a viewed range of say 50% to 200% and allowing the user to left and right click on the vertical scale to zoom in and out, per an ordinary track.  Also a choice of linear or log (pitch) scale would be useful.
> >
> >/Rob