Re: [Audacity-devel] working round bug 152

[Steve t. F. <ste...@gm...>]

I've been discussing bug 152 with Edgar Franke (edgar-rft).

We are in agreement that my original patch to nyquist/dspprims.lsp is incorrect.
We are also in agreement that the new patch is a much better fix.

The problem actually arises in the snd-biquad function in
/lib-src/libnyquist/nyquist/tran/biquadfilt.c
but patching at that point is *highly problematic*. (more information
about this in this forum post:
http://forum.audacityteam.org/viewtopic.php?p=180062#p180062 )

The only known conditions to cause snd-biquad to generate infinites
and NANs are when functions that use nyq:lowpass2 or nyq:highpass2
pass a frequency value that is out of range. The patch addresses these
cases directly by throwing an error for out of range frequency values
in nyq:lowpass2 and nyq:highpass2.

The functions that use nyq:lowpass2 and nyq:highpass2 are intended to
be called directly by user code, so I think it is totally appropriate
to tests for obviously wrong argument values, and that is what this
patch does.

+1 for committing this patch.

Steve


On 21 May 2012 22:34, Gale (Audacity Team) <ga...@au...> wrote:
> Replying just to -devel to save cross-posts.
>
> I would suggest the patch is committed and Steve releases the unpatched
> plug-in
> to Wiki after 2.0.1 (or a developer says the patch is incorrect or the wrong
> way
> to go so Steve knows to release a patched plug-in).
>
> Here is a diff of the patch:
> http://bugzilla.audacityteam.org/attachment.cgi?id=256&action=diff .
>
>
>
> Gale
>
> --
> View this message in context: http://audacity.238276.n2.nabble.com/working-round-bug-152-tp7555241p7555246.html
> Sent from the audacity-devel mailing list archive at Nabble.com.
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel