Re: [Audacity-devel] Memory leak caught in Sequence.cpp

[Vaughan J. <va...@au...>]

Thanks, Mike. Will contact you off list.

- V

On 10/6/2011 10:28 AM, Michael Mueller wrote:
> Hey Vaughan,
> 
> I'd be happy to do something like this, but we don't have a
> straightforward way of providing you all the issues right now (without
> you actually running the tool yourself).  If you'd like to get a trial
> license to play with it, feel free to contact me off list.
> 
> Either way, we'll continue sending in issues as they are discovered  :)
> 
> Mike
> 
> On Fri, Sep 30, 2011 at 3:22 PM, Vaughan Johnson
> <va...@au...> wrote:
>> Great, Mike. I'd be happy to get a snapshot of all issues it finds on
>> the current HEAD, and then welcome updates as they arise. Are you
>> willing to send a list of all issues Sentry sees in the current code base?
>>
>> Thanks,
>> Vaughan
>>
>>
>>
>> On 9/29/2011 3:30 PM, Michael Mueller wrote:
>>> Hi Vaughan,
>>>
>>> As a matter of fact, it did. :)
>>>
>>> 732:     if (!XMLValueChecker::IsGoodInt(strValue) ||
>>> !strValue.ToLong(&nValue) || (nValue < 0))
>>> 733:     {
>>> 734:         mErrorOpening = true;
>>> 735:         return false;
>>> Error: Variable wb leaked
>>> 736:     }
>>>
>>> We're analyzing a lot of OSS projects on a daily basis, but only
>>> reporting brand new issues (bugs that newly appeared in that run).
>>> Usually, if there's an old piece of code that has been working for
>>> years, there isn't a lot of motivation to go modify it.
>>>
>>> Glad I could help. :)
>>>
>>> Mike
>>>
>>> On Thu, Sep 29, 2011 at 3:14 PM, Vaughan Johnson
>>> <va...@au...> wrote:
>>>> Excellent. Thanks for that.
>>>>
>>>> I also noticed the longstanding one just a few lines above it, where it
>>>> also returns false without deleting wb. Did Sentry find that one?
>>>>
>>>> I just made commit 11272, which fixes both.
>>>>
>>>> Thanks!
>>>>
>>>> - Vaughan
>>>>
>>>>
>>>> On 9/29/2011 1:07 PM, Michael Mueller wrote:
>>>>> Hi all,
>>>>>
>>>>> Sentry (our static analyzer) picked up a new memory leak in Audacity
>>>>> today.  It occurs in src/Sequence.cpp, function HandleXMLTag():
>>>>>
>>>>>     SeqBlock *wb = new SeqBlock();
>>>>>     ...
>>>>>     if (nValue > mMaxSamples) // mMaxSamples should already have been
>>>>> set by calls to the "sequence" clause below.
>>>>>     {
>>>>>         mErrorOpening = true;
>>>>>         return false;
>>>>>     }
>>>>>
>>>>> Just introduced in this commit:
>>>>> http://code.google.com/p/audacity/source/detail?spec=svn11271&r=11270
>>>>>
>>>>> The block 'wb' should be deleted before returning from the function.
>>>>>
>>>>> Best,
>>>>> Mike
>>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> All the data continuously generated in your IT infrastructure contains a
>>>> definitive record of customers, application performance, security
>>>> threats, fraudulent activity and more. Splunk takes this data and makes
>>>> sense of it. Business sense. IT sense. Common sense.
>>>> http://p.sf.net/sfu/splunk-d2dcopy1
>>>> _______________________________________________
>>>> audacity-devel mailing list
>>>> aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>>
>>>
>>>
>>>
>>
>> ------------------------------------------------------------------------------
>> All of the data generated in your IT infrastructure is seriously valuable.
>> Why? It contains a definitive record of application performance, security
>> threats, fraudulent activity, and more. Splunk takes this data and makes
>> sense of it. IT sense. And common sense.
>> http://p.sf.net/sfu/splunk-d2dcopy2
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> 
> 
>