Re: [Audacity-devel] Nyquist Prompt in Chains
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2011-09-02 19:10:23
|
Thanks for all your work on this Martyn. Your quite right that Nyquist effects in chains do not work with the current patch unless some Nyquist effect has been run prior to the chain. I've spoken to Leland about this and he suggested: "the call to SetXlistPath() could be from from the EffectNyquist constructor. Just add it at the end, right after the "ParseFile()" line." I 'think' I understand what he means, so I've had a go at making a new patch. I don't really know what I'm doing so this 'will' need checking, but it seems to work. Steve On Fri, Sep 2, 2011 at 12:55 AM, Martyn Shaw <mar...@gm...> wrote: > > > On 26/08/2011 01:15, Martyn Shaw wrote: >> >> >> On 26/08/2011 00:00, Martyn Shaw wrote: >>> >>> >>> On 24/08/2011 01:36, Steve the Fiddle wrote: >>>> On Wed, Aug 24, 2011 at 12:20 AM, Martyn >>>> Shaw<mar...@gm...> wrote: >>>>> >>>>> >>>>> On 21/08/2011 21:38, Steve the Fiddle wrote: >>>>>> I've now had time to test the "Nyquist support in Chains" patch on >>>>>> r11238. >>>>>> Pleased to say that I've found no problems at all. >>>>> >>>>> I would commit this patch (with a couple on changes to avoid compile >>>>> messages on Win) but I have an intermittent problem resulting in the >>>>> "Nyquist did not return audio." message. I have tried and tried to >>>>> debug it but with no success. Intermittent problems are a pain!! >>>>> >>>>> TTFN >>>>> Martyn >>>> >>>> Is this occurring with specific Nyquist plug-ins? >>>> If you can give details I can try to reproduce the problem >>> >>> I have been testing on Win 7 under the VS 2008 under the debugger, a >>> very different environment to yours I believe. That may, or may not, >>> be relevant. >>> >>> I have mostly just tried 'Cross Fade In' (thinking it was a nice >>> short/simple one) on 10s of generated noise. I find this problem when >>> I have 'Cross Fade In' in a chain (with just an EQ before that, or an >>> Echo), but once it stops working it stops working for the normal menu >>> item as well. And all the other Nyquist menu items that I sampled. >>> >>> I know that the Nyquist effects are getting loaded properly as I put >>> test statements in LoadNyquist.cpp. I know that >>> EffectNyquist::ProcessOne() is getting called with the correct mCmd, >>> as I tested that as well. >>> >>> I am now in the (possibly repeatable, I haven't rebooted) state that >>> if I open Audacity from the debugger, generate audio, run 'Cross Fade >>> In', then run my chain (Echo, Cross Fade In) it works, but if I open >>> Audacity, generate audio and then run the chain it fails. So it looks >>> like something happens in the GUI part of Nyquist that doesn't happen >>> in the chain/non-GUI version that is to blame. But I may be wrong. >>> Earlier today I was blaming my environment. >> >> I tried this again tonight (I wrote that yesterday) using Unicode >> Release without the debugger. Slightly more detailed result. If I run >> 'Cross Fade In' before my chain with it in, the chain works. If I run >> Hard Limiter... before my chain, my chain fails. So it may be >> something that a particular effect does, rather than the GUI part >> specifically (which I stepped through under debug). > > Damn! Fooled myself there! 'Hard Limiter...' is not a Nyquist > plug-in, and so irrelevant here! The problem is in the 'GUI' part, > even though there is no GUI. > > The call to > bool EffectNyquist::PromptUser() > is calling SetXlispPath() to set up mXlispPath (and returning without > a GUI, since this effect doesn't need one). But PromptUser() doesn't > get called when using batch, so the path never gets set. I betting > that Nyquist effects in chains don't work for anybody with the current > patch, unless some Nyquist effect has been run prior to the chain. > But please tell me if I'm wrong. > > So where should we call SetXlispPath()? It only really needs calling > once for each session/project, but should remain in the Effects part > of the code. > > I currently have SetXlispPath() in EffectNyquist::EffectNyquist, but > that means it gets called once for every Nyquist plugin. Not a > disaster but not ideal. Any better ideas? We could go with what I > have, after some tidying. > > TTFN > Martyn > >> TTFN >> Martyn >> >>>> Could it be a problem with the Nyquist plug-in code rather than the >>>> patch? >>> >>> I don't think so. Again, I may be wrong, and reserve the right to be >>> wrong again in the future! >>> >>> TTFN >>> Martyn >>> >>>> >>>> Steve >>>> >>>> >>>>> >>>>>> On Fri, Aug 19, 2011 at 1:09 AM, Martyn >>>>>> Shaw<mar...@gm...> wrote: >>>>>>> >>>>>>> >>>>>>> On 18/08/2011 18:23, Steve the Fiddle wrote: >>>>>>>> On Wed, Aug 17, 2011 at 1:00 AM, Martyn >>>>>>>> Shaw<mar...@gm...> wrote: >>>>>>> <snip> >>>>>>>>> Who wrote that patch and is it any good? I only scanned it >>>>>>>>> quickly. >>>>>>>> >>>>>>>> The patch as linked to on that proposal page was written by >>>>>>>> Leland Lucius. >>>>>>>> I've tested it thoroughly on SVN head up to August 1st (I've just >>>>>>>> returned from my holiday) and in my opinion it is very good (it >>>>>>>> does >>>>>>>> what it says on the tin). I can test it again this week to >>>>>>>> ensure that >>>>>>>> it isn't broken or doesn't break anything due to code changes >>>>>>>> since >>>>>>>> I've been away. >>>>>>> >>>>>>> Thanks Steve. I've tried and reviewed that patch and it mostly >>>>>>> looks >>>>>>> good to me. And since Leland wrote it and you've found it good I'm >>>>>>> trusting it, and am inclined to commit it. This is, after all, >>>>>>> quite >>>>>>> an obscure part of Audacity (perhaps). >>>>>>> >>>>>>> Here the 'Select Command' dialog box isn't big enough (and not >>>>>>> resizeable) with all the nyquist effects as well. >>>>>> >>>>>> I've got a horizontal scroll bar - is that not enough? >>>>>> >>>>>>> >>>>>>>> In particular I don't yet know if/how the changes in r11233/4 >>>>>>>> will affect it. >>>>>>>> >>>>>>>> Personally I'm very keen to see this implemented as it extends >>>>>>>> Audacity's functionality considerably for batch processing. Of >>>>>>>> course >>>>>>>> if it were to be included before 2.0 there must be no doubt >>>>>>>> about it >>>>>>>> introducing any problems elsewhere. >>>>>>> >>>>>>> Do you have any doubts? >>>>>> >>>>>> No, it all works fine here, though I've only tested on Linux. >>>>>> >>>>>> Steve >>>>>> >>>>>>> >>>>>>> TTFN >>>>>>> Martyn >>>>>>> >>>>>>>> >>>>>>>> Steve >>>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> >>>>>> >>>>>> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, >>>>>> user administration capabilities and model configuration. Take >>>>>> the hassle out of deploying and managing Subversion and the >>>>>> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 >>>>>> _______________________________________________ >>>>>> audacity-devel mailing list >>>>>> aud...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> >>>>> >>>>> EMC VNX: the world's simplest storage, starting under $10K >>>>> The only unified storage solution that offers unified management >>>>> Up to 160% more powerful than alternatives and 25% more efficient. >>>>> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev >>>>> _______________________________________________ >>>>> audacity-devel mailing list >>>>> aud...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> >>>> EMC VNX: the world's simplest storage, starting under $10K >>>> The only unified storage solution that offers unified management >>>> Up to 160% more powerful than alternatives and 25% more efficient. >>>> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev >>>> _______________________________________________ >>>> audacity-devel mailing list >>>> aud...@li... >>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > ------------------------------------------------------------------------------ > Special Offer -- Download ArcSight Logger for FREE! > Finally, a world-class log management solution at an even better > price-free! And you'll get a free "Love Thy Logs" t-shirt when you > download Logger. Secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsisghtdev2dev > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |