Re: [Audacity-devel] Mac and source re-uploaded

[Benjamin D. <bd...@ub...>]

Am Mittwoch, den 30.03.2011, 09:55 -0500 schrieb Leland:
> On 3/30/11 9:01 AM, Benjamin Drung wrote:
> > Am Mittwoch, den 30.03.2011, 08:55 -0500 schrieb Leland:
> >> On 3/30/11 5:31 AM, Benjamin Drung wrote:
> >>>>
> >>>> However, on Ubuntu 10.10, if it detects the system library, then
> >>>> portmixer configuration will fail because the portaudio system includes
> >>>> do not include pa_unix_oss.h, pa_linux_alsa.h, etc.  This isn't a bug in
> >>>> your patch, it is a bug in the portmixer configure.ac.
> >>>
> >>> Yes and no. Audacity's configure should check if pa_unix_oss.h and
> >>> pa_linux_alsa.h are available on the system. Should I come up with an
> >>> updated patch?
> >>>
> >> Nah, I think your patch is fine since your audacity_checklib_portaudio
> >> is doing exactly what it should be doing...checking for portaudio.
> >> Those other headers are prereqs for portmixer, so they should be checked
> >> for there.
> >
> > Audacity and portmixer have to use the same portaudio version.
> That is taken care of by the presence of --with-pa-include since it 
> either lets portmixer configure find the portaudio headers via system 
> path (not specified) or local path (specified).
> 
> > Therefore
> > audacity_checklib_portaudio should check if the system portaudio is
> > sufficient for portmixer too.
> >
> Not really since portmixer is entirely optional and it can tolerate 
> building with both, either, or neither oss and alsa.  It's just that 
> configure couldn't tolerate it.

Valid point.

-- 
Benjamin Drung
Debian & Ubuntu Developer