Re: [Audacity-devel] Mac and source re-uploaded

[Benjamin D. <bd...@ub...>]

Am Mittwoch, den 30.03.2011, 10:30 -0500 schrieb Leland:
> On 3/30/11 9:01 AM, Benjamin Drung wrote:
> > Am Mittwoch, den 30.03.2011, 08:55 -0500 schrieb Leland:
> >> On 3/30/11 5:31 AM, Benjamin Drung wrote:
> >>>>
> >>>> However, on Ubuntu 10.10, if it detects the system library, then
> >>>> portmixer configuration will fail because the portaudio system includes
> >>>> do not include pa_unix_oss.h, pa_linux_alsa.h, etc.  This isn't a bug in
> >>>> your patch, it is a bug in the portmixer configure.ac.
> >>>
> >>> Yes and no. Audacity's configure should check if pa_unix_oss.h and
> >>> pa_linux_alsa.h are available on the system. Should I come up with an
> >>> updated patch?
> >>>
> >> Nah, I think your patch is fine since your audacity_checklib_portaudio
> >> is doing exactly what it should be doing...checking for portaudio.
> >> Those other headers are prereqs for portmixer, so they should be checked
> >> for there.
> >
> > Audacity and portmixer have to use the same portaudio version. Therefore
> > audacity_checklib_portaudio should check if the system portaudio is
> > sufficient for portmixer too.
> >
> > Then configure can tell you: The system portaudio is available, but
> > lacks the required headers; using the local portaudio instead. If
> > portmixer checks for the header files, it will fail. Probably both
> > should have the checks for the header files.
> >
> I've attached the portmixer configure.ac.  What d'ya think?  Should the 
> "no mixer interfaces" message be a warning or an error?  I made a 
> warning, but have been rethinking that and am not thinking an error is 
> more appropriate.

1) The "no mixer interfaces" message should be an error.

2) configure should be more verbose. It should spit out an information
if the first AC_CHECK_HEADER doesn't find the system headers (e.g.
alsa/asoundlib.h for ALSA). It should spit out a warning if the second
AC_CHECK_HEADER doesn't find the portaudio headers (e.g.
pa_linux_alsa.h)

3) Your 'if [[ $variable = "something" ]] ; then' fail if the variable
is empty. You need to add double quote: 'if [[ "$variable" = "something"
]] ; then' or with test (which I prefer): 'if test "$variable" =
something; then'

-- 
Benjamin Drung
Debian & Ubuntu Developer