Re: [Audacity-devel] Mac and source re-uploaded

[Benjamin D. <bd...@ub...>]

Am Dienstag, den 29.03.2011, 09:04 -0500 schrieb Leland:
> On 3/29/11 6:14 AM, Benjamin Drung wrote:
> > I tested the rc1 source tarball and found more issues. :)
> >
> > 1) The tarball contains 'svn-commit.tmp'. Fix: Do not include this file
> > in the tarball.
> 
> Oops...thought I'd gotten rid of those.
> 
> > 2) The file 'lib-src/portmixer/configure.ac' contains this line 'if
> > 3) src/FFmpeg.h includes<libavutil/fifo.h>, but configure does not
> 
> So, with these 2 and the previous 3, that should bring the "16 patches" 
> you mentioned in a previous message down to 11.  Are there any more 
> build related patches?

These five patches would reduce the packing patches count by four. One
of the previous 3 patches fixes an issue that I discovered yesterday.

I have three build related patches remaining:

1) Add a autogen.sh script that runs the commands required to update the
configure script (and cleans the intermediate files). Don't forget to
make autogen.sh executable after applying autogen-script.patch by
running 'chmod +x autogen.sh'.

2) Support compiling against system portaudio:

The portaudio package in Debian unstable and Ubuntu 11.04 (natty)
contains the patch from Audacity. The Debian/Ubuntu package will build
against this system version. The system-portaudio-v2.patch makes
audacity configurable to either use the local or system version of
portaudio. configure will check if the patch from Audacity is applied by
checking if the function Pa_GetStreamHostApiType is available.

This patch depends on portmixer-include-directory.patch. Otherwise it
will fail to find the system portaudio. Don't forget to update configure
after applying this patch.

3) The third patch fixes the autoconf warnings:

configure.in:289: warning: AC_CONFIG_SUBDIRS: you should use literals
../../lib/autoconf/status.m4:1098: AC_CONFIG_SUBDIRS is expanded from...
configure.in:289: the top level
configure.in:452: warning: AC_CONFIG_SUBDIRS: you should use literals
configure.in:452: the top level

The attached autoconf-warning-v3.patch will fix them. It applies cleanly
if you have portmixer-include-directory.patch applied. Don't forget to
update the configure script after applying the patch.

Then there are three patches left:

4) Bug #274 [1] should be fixed if the FFmpeg >= 0.6 patch is not
applied. The patch is attached to comment 5.

5+6) These two patches are for disabling dynamic loading.

[1] http://bugzilla.audacityteam.org/show_bug.cgi?id=274

-- 
Benjamin Drung
Debian & Ubuntu Developer