Re: [Audacity-devel] Mac and source re-uploaded

[Benjamin D. <bd...@ub...>]

Am Montag, den 28.03.2011, 22:14 -0500 schrieb Leland:
> The Mac binaries contain no changes, I just renamed to "rc1" to match 
> Gale's.
> 
> The source binaries contain Benjamin's fixes.  There should be no need 
> to rebuild Mac or Windows binaries for these fixes.
> 
> Leland
> 
> http://audacity.googlecode.com/files/audacity-minsrc-1.3.13rc1.tar.bz2
> http://audacity.googlecode.com/files/audacity-fullsrc-1.3.13rc1.tar.bz2
> http://audacity.googlecode.com/files/audacity-macosx-ub-1.3.13rc1.zip
> http://audacity.googlecode.com/files/audacity-macosx-ub-1.3.13rc1.dmg

I tested the rc1 source tarball and found more issues. :)

1) The tarball contains 'svn-commit.tmp'. Fix: Do not include this file
in the tarball.

2) The file 'lib-src/portmixer/configure.ac' contains this line 'if
[[ with_portaudio != "" ]] ; then'. This test will always return true,
because 'with_portaudio' is always not ''. The $ sign was forgotten to
compare the variable instead of a string. The test will fail if
$with_portaudio is empty (see my previous mails). The test can be
simplified to 'test -n "$with_portaudio"' which tests if the value has a
non-zero length.

The attached portmixer-include-directory.patch will fix it. Don't forget
to
run 'autoreconf' in the lib-src/portmixer directory to refresh
portmixer's configure.

3) src/FFmpeg.h includes <libavutil/fifo.h>, but configure does not
check if the system labavutil is available. The build will fail if you
configure audacity to use the system ffmpeg, but do not have libavutil
installed. The fix is to also check if libavutil is available.

The attached ffmpeg-configure-v2.patch will fix it. Don't forget to
run 'aclocal -I m4 && autoconf' to refresh configure.


As previously: The two patches should be included in the 1.3.13 release.
They are
relatively small and they touch only the Unix build system (so no bad
effects for Windows).

-- 
Benjamin Drung
Debian & Ubuntu Developer