Re: [Audacity-devel] Remove trailing whitespaces

[Benjamin D. <bd...@ub...>]

Hi,

I manually checked the three patches

remove-trailing-whitespaces-in-src.patch
remove-trailing-whitespaces-in-portmixer.patch
remove-trailing-whitespaces-in-filediag.patch

and checked that everything works afterwards. They modify files in src/,
lib-src/portmixer, and lib-src/FileDialog. Therefore no foreign
libraries are touched.

Only remove-trailing-whitespaces-remaining.patch needed checking. I
dropped it and attached a smaller safe one.

Am Donnerstag, den 24.02.2011, 14:24 -0800 schrieb Vaughan Johnson:
> Why is this important? I'd have no worry about it except for the
> presumably-manual "removed the changes to patches and binary files" and
> "Please check" (also presumably manually). On the road to 2.0, I think
> we should make no unnecessary changes, especially mechanical ones.
> 
> - Vaughan
> 
> 
> On 2/22/2011 5:52 AM, Benjamin Drung wrote:
> > Hi,
> > 
> > I ran [1] to remove all trailing whitespaces from the files in trunk. Do
> > not run it directly in your svn checkout, because this command will
> > alter the files in the hidden .svn directory too.
> > 
> > I split the output in four different patches (attached). I removed the
> > changes to patches and binary files, because the trailing whitespaces
> > are needed there. Please check that
> > remove-trailing-whitespaces-remaining.patch does not touch files it
> > shouldn't touch.
> > 
> > [1] find * -type f -exec sed -i 's/[ \t]*$//' {} \;

-- 
Benjamin Drung
Debian & Ubuntu Developer