Re: [Audacity-devel] [Bug 243] Default EQCurves.xml should be populated and added to Windows and Mac installers

[Leland <le...@au...>]

On 12/29/10 5:38 PM, Martyn Shaw wrote:
> Hi Leland!
>
> On 29/12/2010 17:06, Leland wrote:
>>>> --- Comment #15 from Bill Wharrie<bi...@go...>     2010-12-21 13:26:26 EST ---
>>>> (In reply to comment #14)
>>>> With Audacity 1.3.13-alpha Dec 18, on Mac, everything works beautifully, except
>>>> that EQDefaultCurves.xml is still not in the app directory
>>>> (Audacity/Contents/MacOS).
>>
>> Looking for the xml file in PlatformCompatibility::GetExecutablePath()
>> causes Aduacity to look for the EQDefaultCurves.xml file in
>> Audacity.app/Contents/MacOS which really isn't the correct location for
>> this type of file.
>
> That wasn't the intention, the intention was to get
> EQDefaultCurves.xml from a standard place.  This was OK on Win ;-), I
> didn't know about the others.
>
>> It should really go into the Audacity.app/Contents/Resources directory.
>>     This can be achieved by changing the
>> PlatformCompatibility::GetExecutablePath() in
>> EqualizationDialog::LoadCurves() to wxStandardPaths::GetResourcesDir().
>>
>> It would provide the following results:
>>
>> Windows: the directory where the executable file is located
>> Mac: appname.app/Contents/Resources bundle subdirectory
>> Linux: prefix/share/appname
>
> I see that now on
> http://docs.wxwidgets.org/trunk/classwx_standard_paths.html#5514bf6288ee9f5a0acaf065762ad95d
>
>> The Linux one is interesting.  Without testing, I suspect that currently
>> the EQDefaultCurves.xml file is expected to be found in the same
>> directory as the Audacity executable.  This would be incorrect is almost
>> any case where a user installs Audacity from an RPM, DEB, or the like.
>> (.xml files don't belong in /usr/bin, /usr/local/bin, etc.)
>
> I've no idea about how that works, which is probably why I made the
> mistake.  Thanks for catching it!  Is it better now?
>
Looks good to me, but Bill might want to test it out again on the Mac to 
ensure the wxWidgets manual isn't fibbing.  :-)

Now Michael can just add EQDefaultCurves.xml to the Xcode project under 
the Audacity/mac/Resources branch and it will automatically be copied to 
the .app bundle without having to do anything else.

Leland