Re: [Audacity-devel] [Audacity-quality] Default EQCurves and Manage Curves dialog
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
Menu
▾
▴
Re: [Audacity-devel] [Audacity-quality] Default EQCurves and Manage Curves dialog
|
From: Bill W. <bi...@go...> - 2010-12-09 15:54:13
|
On 9-Dec-10, at 10:39 AM, Gale Andrews wrote:
>
> | From Bill Wharrie <bi...@go...>
> | Thu, 9 Dec 2010 09:29:15 -0500
> | Subject: [Audacity-quality] Default EQCurves and Manage Curves
> dialog
>> On 5-Dec-10, at 8:54 PM, Martyn Shaw wrote:
>>> Anything I have missed? Yet to be committed.
>>
>> So commits r10802 and r10803 don't address this?
>
> 10804 added /audacity-src/trunk/presets/EQDefaultCurves.xml
> to the source tree.
>
> 10803 made the following improvements to the missing EQCurves.xml
> error dialog:
>
> --- /audacity-src/trunk/src/effects/Equalization.cpp Sun Nov 7
> 15:17:51
> 2010
> +++ /audacity-src/trunk/src/effects/Equalization.cpp Thu Dec 2
> 16:57:56
> 2010
> @@ -985,9 +985,10 @@
> wxString fullFn = fn.GetFullPath();
> if( !fn.FileExists() )
> { // Default file not found. Give up and advise user
> - wxString errorMessage = _("EQCurves.xml not found on your
> system.\nPlease press 'help' to visit the download page.");
> + wxString errorMessage;
> + errorMessage.Printf(_("EQCurves.xml not found on your
> system.\nPlease press 'help' to visit the download page.\n\nSave the
> curves
> at %s"), FileNames::DataDir().c_str());
> ShowErrorDialog(this, _("EQCurves.xml missing"),
> - errorMessage,
> wxT("http://wiki.audacityteam.org/wiki/Default_EQCurves"));
> + errorMessage,
> wxT("http://wiki.audacityteam.org/wiki/EQCurvesDownload"));
> mCurves.Add( _("unnamed") ); // we still need a default
> curve
> to use
> return;
> }
OK, that's the advice I saw on the error dialog telling me where to
download EQDefaultCurves.xml to. And the opening of the correct page
in the web browser.
>
>
>> EQCurvesDefault.xml is not included in exePath on Mac as of Dec 9.
>
> Do you mean it's still not bundled in the .dmg image?
Yes, that is the case as of the Dec 9 Mac alpha. EQDefaultCurves.xml
should be in Audacity/Contents/MacOS.
>
>
>
>
>
> Gale
>
>
>
>>> On 03/12/2010 01:07, Martyn Shaw wrote:
>>>> Hi there
>>>>
>>>> I don't think this will get to -quality, since I'm not currently
>>>> subscribed. Maybe somebody could forward.
>>>>
>>>> <snip>
>>>>
>>>>> The following was done with Audacity 1.3.13-alpha-Nov 27 2010
>>>>> (Unicode), Mac PPC OS X 10.5.8.
>>>>>
>>>>> - Start Audacity with initialized cfg and no "EQCurves.xml" in ~/
>>>>> Library/Application Support/audacity
>>>>> - Generate something so you can access the Effect menu
>>>>> - Effect> Equalization
>>>>> - dialog appears: "EQCurves not found on your system. Please press
>>>>> 'help' to visit the download page."
>>>>> - Click help button and go to wrong page?
>>>>> http://wiki.audacityteam.org/wiki/Default_EQCurves
>>>>
>>>> Indeed. That is a discussion page about what the defaults should
>>>> be.
>>>> The button should go to
>>>> http://wiki.audacityteam.org/wiki/EQCurvesDownload or
>>>> http://wiki.audacityteam.org/wiki/
>>>> EQCurvesDownload#Default_curves. My
>>>> mistake. I've fixed it in the code.
>>>>
>>>> This should be a rare case when somebody has deleted EQCurves.xml
>>>> or
>>>> the installation has not been done properly. I have also made the
>>>> dialog give an indication as to where the file should be put. I
>>>> have
>>>> made that the 'standard' DataDir(), not the place it would have
>>>> gone
>>>> with an installer. That will then be picked up the next time EQ is
>>>> run.
>>>>
>>>> We need to make the 'help' button not dismiss that dialog but still
>>>> launch the browser, so that you can get the default curves and then
>>>> press 'OK' and see them. That should easily be possible, but not
>>>> tonight. This such a rare case that it isn't a show-stopper.
>>>>
>>>>> [I assume this page will eventually have the default file
>>>>> available
>>>>> - the default EQCurves.xml is actually available on this page
>>>>> http://wiki.audacityteam.org/wiki/EQCurvesDownload
>>>>> ]
>>>>> - Fake it by copying EQCurves.xml into ~/Library/Application
>>>>> Support/
>>>>> audacity. [As if the user knew exactly what do download, how to
>>>>> download it, and where to put it]
>>>>> - Default presets do not show up in Select Curve menu
>>>>> - Cancel Equalization
>>>>> - Effect> Equalization
>>>>> - Default curves show up in Select Curve menu.
>>>>>
>>>>> PROBLEMS:
>>>>>
>>>>> 1) As noted in the steps above, the Select Curve menu is not
>>>>> populated
>>>>> on first use of the Equalization effect when EQCurves.xml is not
>>>>> found, since clicking the "help" button boots the user into their
>>>>> web
>>>>> browser while also opening the Equalization effect window. Perhaps
>>>>> the
>>>>> Equalization effect should not be opened immediately if the user
>>>>> selects "help".
>>>>
>>>> Noted above.
>>>>
>>>>> 2) The user must know where to put EQCurves.xml. On Mac this would
>>>>> (normally) be ~/Library/Application Support/audacity, but would be
>>>>> the
>>>>> Portable Settings folder if they're using one. Would detailed
>>>>> instructions on the web page be enough? Is there some way Audacity
>>>>> can
>>>>> take control of this?
>>>>
>>>> Hopefully the error dialog will now show this. Does it work for
>>>> you?
>>>>
>>>>> 3) The Mac distribution does not include an installer. One merely
>>>>> copies the entire contents of the .dmg into one's Applications
>>>>> folder
>>>>> (preferably into a new folder created in the Applications folder
>>>>> per
>>>>> the instructions on the Mac download page
>>>>> http://audacity.sourceforge.net/download/beta_mac
>>>>> ). So how is the user going to know to copy the EQCurves.xml
>>>>> file to
>>>>> the correct location when installing Audacity from the .dmg?
>>>>
>>>> Again, hopefully the error dialog will now show this. Does it work
>>>> for
>>>> you?
>>>>
>>>> TTFN
>>>> Martyn
>>>>
>>>>
>>>>> 4) Moving EQCurves to the "app directory" (on Mac, this would
>>>>> either
>>>>> be the Applications folder or the user-created folder into which
>>>>> they
>>>>> copied the contents of the .dmg) results in the "EQCurves not
>>>>> found"
>>>>> message, so clearly Audacity is not looking in the "app
>>>>> directory".
>>>>>
>>>>> Perhaps this is still under development. But there have been no
>>>>> updates since Oct 18 on the bugzilla page, and I can't find
>>>>> anything
>>>>> in -devel on this topic after July 3.
>>>>>
>>>>> -- Bill
>
>
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
|