Re: [Audacity-quality] Save Compressed Copy of Project

[Michael C. <mc...@gm...>]

On Sat, Nov 20, 2010 at 12:12 AM, Vaughan Johnson
<va...@au...> wrote:
> Hi, Steve. In short, it's a bug, but not quite as pervasive as stated.
> The problem occurs only if you're doing a Save Compressed of the
> currently open project. In fact, Save As does the same thing (and Save
> Compressed uses that same code for checking). If you Save As the
> currently open project, it saves the project all over again, even if
> there are no changes to be written. Here's the comment in the code:
>
>   //We should only overwrite it if this project already has the same
> name, where the user
>   //simply chose to use the save as command although the save command
> would have the effect.
>
> But that seems like a bug to me. Two cases:
>
> 1) If there are no changes since the last Save, Save is disabled but
> Save As is not. So Save As will overwrite the same data, and it's
> wasteful to spend cycles doing the Save As in that case.
>
> 2) If there are changes since the last Save, then by choosing Save As, I
> think we should expect the user intends to save a separate copy, and if
> user accidentally gives it the same name, then overwriting the existing
> version will lose that copy. Danger, Will Robinson.
>
> According to SVN, Michael wrote the comment and the check to work this
> way, but I think it should disallow overwriting in every case, for both
> Save As and Save Compressed. But it's easy to change it to do so only
> for Save Compressed, if consensus is for that.

I can't find the thread where the discussion was, but I thought case 2
was a valid use case - for some reason I select "save as" but end up
wanting just to do a plain "save" - but it might just be something
that not enough people do.
I don't feel strongly one way or another on this, so if the consensus
is to remove that then it's completely fine by me.

>
> Btw, according to a comment by James:
>
> // We disallow overwrite because we would have to delete the many
> // smaller files too, or prompt to move them.
>
>
> Comments? Michael?

Sorry for the slow replies - I don't have internet at home now but it
will be back in a few days.

Michael