Re: [Audacity-quality] Mixer Board issues

[Vaughan J. <va...@au...>]

On 11/10/2010 5:53 PM, Gale Andrews wrote:
> 
> | From Vaughan Johnson <va...@au...> 
> | Wed, 10 Nov 2010 17:04:54 -0800
>> On 11/9/2010 6:58 PM, Gale Andrews wrote:
>>>
>>> | From Bill Wharrie <bi...@go...> 
>>> | Tue, 9 Nov 2010 14:17:48 -0500
>>>>
>>>> On 3-Nov-10, at 2:48 PM, Gale Andrews wrote:
>>>>
>>>> <snip>
>> I looked into this, and it's another bug introduced by Roger's commit
>> 10680. When I said it was okay for him to make these changes, it was
>> with the understanding that they would all be under
>> EXPERIMENTAL_MIDI_OUT and not threaten our code stability with that
>> turned off.
>>
>> In fixing bug 250 and looking into this, I've found he did a *lot* of it
>> under USE_MIDI and even more with no flag at all. I'm disappointed in
>> this and am going to back out his changes.
> 
> More generally, I wouldn't personally regard USE_MIDI as a must for 2.0. 
> Does this switch on the extra MIDI features that 1.2 doesn't have (MIDI
> "cut and paste editing" and export) or also control MIDI import? Neither 
> the 1.2 or 1.3.13 current MIDI features are going to seriously impress 
> MIDI users. In fact I think the MIDI "features" in 1.3.13 look very 
> unfinished, and will always do until we at least get stable MIDI playback. 
> 

I don't know, offhand. Rather than having me look into it, as I wasn't
following those decisions, please ask on -devel and cc Roger. I just
started a "problems with recent MIDI code" thread there addressing the
issue of backing out his changes, so that's an appropriate place to ask,
imo.

As partial as the MIDI implementation is, I'm fine with turning it off
completely.

Thanks,
Vaughan