Re: [Audacity-quality] linux/win TipPanel patch testing needed (WAS: TipPanel slowness on mac)
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Al D. <bus...@gm...> - 2010-10-27 05:45:19
|
On Tuesday, October 26, 2010 20:51:44 Michael Chinen wrote: > On Tue, Oct 26, 2010 at 6:06 AM, Vaughan Johnson > > <va...@au...> wrote: > > Neither LL or DM, I think, is keeping up with wx changes > > regarding Audacity, so I vote "go for it"! I think is is indeed > > a wxPanel. > > I played around by changing the TooltipPanel to the wxPanel version > (which is now in linux) more and realized there were some buggy > redrawing issues. > I think some of it may be related to what Roger was noticing in the > thread "More on EXPERIMENTAL_MIDI_OUT" > > So instead I decided to keep the wxFrame for TooltipPanel, but just > use one shared instance over all projects and sliders instead of > (100 * number of projects) instances of wxFrame. With this method > there is no longer the five second wait to create new projects on > the mac. I think this should be okay as long as there is no > reason to have two slider tooltips on the screen. > > I am attaching it as a patch first because it affects the other > platforms on which it should be tested before committing. > The patch also changes the linux version to use wxFrame because I > suspect it will fix some redrawing issues (such as the green > playbar being glitched while playing and moving the slider.) > I also changed the windows version to use a shared wxPopupWindow. > There is one bit I am unsure of, and quite possibly the sliders > won't have the tip. > > Can someone on each platform please try testing it? Here's a > guide. Here are my results, on Linux. Specifically, Kubuntu 10.10. I'm running a debug build of Audacity under GDB and displaying in Xephyr, a nested X server; the window manager running in Xephyr is not compositing, which may be significant). > 1.Play with the gain, pan, input/output level sliders > pre-patch. > 2.Create a new project and note if it takes longer than > a second. Pre-patch, sliders work fine and new project creation is pretty quick within Xephyr, shorter than a second. Since I've heard of performance issues here, and there's window creation happening, I tried outside of Xephyr, under a compositing WM, and it takes around a second to complete project opening. There also is a delay of a few seconds (under a compositing WM but not using a traditional one) when quitting Audacity with about a dozen projects open. > 3.Apply the patch (from the src dir.) > 4.Play with the gain, pan, input/output level sliders pre-patch. I got a compile error with the patch -- I noticed that you had said you switched TipPanel to derive from wxFrame on Linux and that wasn't in the patch so I added it, and commented out some Mac-specific stuff in TipPanel::Show(). That makes the compile work... I'm attaching the error text as an attachment so email formatting doesn't get in the way. > 5.Create a new project and note if it takes longer than a second. Project creation is noticeably faster, both under Xephyr and not. It is almost instantaneous under Xephyr, and pretty snappy anyway outside. > 6.Play with the sliders on the second project. > 7.Close the first project. > 8.Play again with the sliders on the second project. > 9.Generate some audio, and while the audio is playing move the > gain/pan sliders. > 10.Quit and make sure the application exits. All this works as expected (I did all this stuff, plus creating about 12 projects and playing with sliders randomly). Once there was a segfault reported on quit but unfortunately I was running outside the debugger -- I sometimes see segfaults when quitting Audacity, so it's not necessarily related, and I haven't found a way to repro it. > > These tests are to try and make it crash or not be drawn and some > stage. But also please let me know if it looks funny. > Here are the "looks funny issues": 1. Initially after starting Audacity there's a TipPanel window on the screen (upper-left of my display separate from the Audacity window) with text "Output Volume 000000". Once I drag any slider thumb it goes away. This is true both within Xephyr and outside. 2. Outside of Xephyr (using KWin with compositing enabled) when the TipPanel appears it grabs focus from the Project window, has a drop- shadow, and has a "pop-in" effect when it appears -- as if it were a normal window and not just a tooltip-like thing. 3. Within Xephyr (using wm2) it looks like the window decorations are half-drawn. This may be a wm2 bug for all I know (wm2 has a few bugs, and is sort of weird generally). My guess is that #2 and #3 are both related to my commenting out the Mac-specific stuff. Maybe the changes I made to fix the compile error also caused #1. If you don't have a Linux box handy I might be able to look at this next weekend, but probably not before then, as I imagine I'll have to study some documentation. -Al > Thanks, > Michael |