Re: [Audacity-devel] TipPanel slowness on mac
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2010-10-26 04:06:20
|
Neither LL or DM, I think, is keeping up with wx changes regarding Audacity, so I vote "go for it"! I think is is indeed a wxPanel. - V On 10/24/2010 5:41 PM, Michael Chinen wrote: > While profiling the mac when you have lots of projects open, I also > noticed that creating a new empty project also takes a few seconds, so > I profiled this as well. > It turns out over 50% of stack frames were landing in the TipPanel > constructor, which is ultimately called by TrackPanel::MakeMoreSlider > making 100 new LWSlider objects. > On the mac there is a #ifdef to make the TipPanel class inherit from > wxFrame instead of wxPanel (linux) or wxPopupWindow(win). > The comment by leland from rev 6371 suggests there's redrawing problems > > 6371 llucius #elif defined(__WXMAC__) > 6371 llucius // On the Mac, we use a wxFrame as a wxPanel will > appear to fall behind > 6371 llucius // whatever window it is hovering above if that > window is refreshed. A frame > 6371 llucius // does not have this problem. One unfortunate side > effect is that a shadow > 6371 llucius // now appears below the tip panel. > 6371 llucius class TipPanel : public wxFrame > 2146 dmazzoni #else > 1947 dmazzoni class TipPanel : public wxPanel > > I wondered if this was fixed in new wxMac and changed it to inherit > from the linux wxPanel. > It looks to work alright for me, even when I have audio playback going > and the tooltip touching the moving ruler below it. With the change > it runs a lot faster, and the delay to open new projects is barely > noticable. > > On the other hand, I might be misunderstanding what this class does. > Anything I should check for? > > Michael > |