Re: [Audacity-devel] Recent commits; 1.3.12 will need an RC4

[LRN <lr...@gm...>]

On 26.03.2010 21:13, Al Dimond wrote:
> I recognize that the three recent SVN commits (r10369, r10370, r10371) 
> are for crash issues and don't involve much code changing. But we are 
> frozen now, so those should have been approved by another developer.
>
> I haven't been following the import filer/plugin issues (ie the 
> "Importing multiple MP3 files with FFMPEG" thread) and so I'm not 
> really in a position to review those patches; if we're safer with 
> r10369/r10370 than without those patches should be applied to 1.3.12. 
> LRN, in your judgement, is that the case?
>   
One is mostly tested by Gale in nightlies (except for LastOpenType
writing reordering in ShowOpenDialog), and another is a one-liner
(pretty safe to apply, IMHO). My optinion - apply both to 1.3.12
> r10371 looks like a bit of a hack but probably a safe one, and maybe 
> prevents a crash?
Prevents division-by-zero (which is an obvious crash-maker) in
ImportMP3. ImportMP3 doesn't crash with that (on Windows).
> I still get a crash on Linux when importing a zero-
> byte MP3 but based on the backtrace it appears to be using the FFmpeg 
> importer, not ImportMP3.cpp.
Doesn't crash for me. I've stepped through it, and it quits at this line:
wxLogMessage(wxT("FFmpeg : av_open_input_file() failed for file
%s"),mName.c_str());
After that ImportMP3 attempts to open the file (since ImportFFmpeg fails
at early stage).
ImportMP3 doesn't make any checks on file and claims it to be
importable. Then the underlying maddecoder fails to decode the file (not
surprising) and the importing process fails (but ImportMP3 returns
eProgressSuccess for some reason, so the failure is not indicated in any
kind, just nothing is imported).
So, as far as Windows goes, zero-sized mp3s are safe enough.
> I don't know how to select that (maybe 
> the answer is in that thread I've been ignoring).
>   
File->Import->Audio. Choose "MP3 files" (if you want ImportMP3) filter
in drop-down list, select a file, press OK.